From af862a9caff4610a7b2e44b61dad8c19486de1f9 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Tue, 16 Apr 2019 01:26:28 +0300 Subject: [PATCH] Remove redundant AbstractOutput::internal() method Summary: We already have AbstractOutput::isInternal() method. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D20587 --- abstract_output.h | 3 --- plugins/platforms/drm/drm_output.cpp | 2 +- plugins/platforms/drm/drm_output.h | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/abstract_output.h b/abstract_output.h index 6a9b4602f0..f6bd238d73 100644 --- a/abstract_output.h +++ b/abstract_output.h @@ -150,9 +150,6 @@ protected: void setOrientation(Qt::ScreenOrientation set) { m_orientation = set; } - bool internal() const { - return m_internal; - } void setInternal(bool set) { m_internal = set; } diff --git a/plugins/platforms/drm/drm_output.cpp b/plugins/platforms/drm/drm_output.cpp index 8432f3c1c1..532dd4249e 100644 --- a/plugins/platforms/drm/drm_output.cpp +++ b/plugins/platforms/drm/drm_output.cpp @@ -248,7 +248,7 @@ bool DrmOutput::init(drmModeConnector *connector) setInternal(connector->connector_type == DRM_MODE_CONNECTOR_LVDS || connector->connector_type == DRM_MODE_CONNECTOR_eDP); setDpmsSupported(true); - if (internal()) { + if (isInternal()) { connect(kwinApp(), &Application::screensCreated, this, [this] { connect(screens()->orientationSensor(), &OrientationSensor::orientationChanged, this, &DrmOutput::automaticRotation); diff --git a/plugins/platforms/drm/drm_output.h b/plugins/platforms/drm/drm_output.h index 0c8ea71b44..f6012e3bae 100644 --- a/plugins/platforms/drm/drm_output.h +++ b/plugins/platforms/drm/drm_output.h @@ -165,7 +165,6 @@ private: DrmDumbBuffer *m_cursor[2] = {nullptr, nullptr}; int m_cursorIndex = 0; bool m_hasNewCursor = false; - bool m_internal = false; bool m_deleted = false; };