From b07dbedfdb941af7c42feccff9ebbba81aaa4b6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Tue, 8 Apr 2014 08:55:34 +0200 Subject: [PATCH] [effects/slidingpopups] Don't update property on window closed If the property changes the animation data is updated. As the last property change event will definately be delivered before an unmap notify we can be sure that the animation data is up to data. Reading the property again does not have any advantages. By removing it we get rid of at least one roundtrip to the X Server and it fixes one failed GetProperty error when it tries to read the property for an already destroyed unmanaged. REVIEW: 117431 --- effects/slidingpopups/slidingpopups.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/effects/slidingpopups/slidingpopups.cpp b/effects/slidingpopups/slidingpopups.cpp index ab369cba21..f6d9ec5aac 100644 --- a/effects/slidingpopups/slidingpopups.cpp +++ b/effects/slidingpopups/slidingpopups.cpp @@ -278,7 +278,6 @@ void SlidingPopupsEffect::slotWindowAdded(EffectWindow *w) void SlidingPopupsEffect::slotWindowClosed(EffectWindow* w) { - slotPropertyNotify(w, mAtom); if (w->isOnCurrentDesktop() && !w->isMinimized() && mWindowsData.contains(w)) { w->refWindow(); delete mAppearingWindows.take(w);