From b0a5918db9e281e8b680317eb35a7d20084e10c6 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Wed, 24 Jul 2024 15:09:45 +0000 Subject: [PATCH] effects/logout Avoid caching animation duration This is problematic as then we do not catch changes to animation speed settings, it also doesn't make the code more readable when it's only used in one place. BUG: 490703 --- src/plugins/logout/package/contents/code/main.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/plugins/logout/package/contents/code/main.js b/src/plugins/logout/package/contents/code/main.js index d23ed955ef..9dc5b37034 100644 --- a/src/plugins/logout/package/contents/code/main.js +++ b/src/plugins/logout/package/contents/code/main.js @@ -12,12 +12,6 @@ "use strict"; var logoutEffect = { - inDuration: animationTime(800), - outDuration: animationTime(400), - loadConfig: function () { - logoutEffect.inDuration = animationTime(800); - logoutEffect.outDuration = animationTime(400); - }, isLogoutWindow: function (window) { if (window.windowClass === "ksmserver-logout-greeter ksmserver-logout-greeter") { return true; @@ -35,7 +29,7 @@ var logoutEffect = { } window.inAnimation = animate({ window: window, - duration: logoutEffect.inDuration, + duration: animationTime(800), type: Effect.Opacity, from: 0.0, to: 1.0 @@ -52,14 +46,13 @@ var logoutEffect = { } window.outAnimation = animate({ window: window, - duration: logoutEffect.outDuration, + duration: animationTime(400), type: Effect.Opacity, from: 1.0, to: 0.0 }); }, init: function () { - logoutEffect.loadConfig(); effects.windowAdded.connect(logoutEffect.opened); effects.windowClosed.connect(logoutEffect.closed); }