yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move layer updating for setActive back to AbstractClient

Browse source 
AbstractClient now also supports mainClients, so we can do the
fullscreen window check on setActive in a general way. This ensures
that we do get proper stacking changes for activating fullscreen
shell clients.
This commit is contained in:
Martin Gräßlin 2015-10-01 17:21:56 +02:00
parent b587926803
commit b5255de4b6
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
abstract_client.cpp
View file

@ -180,6 +180,15 @@ void AbstractClient::setActive(bool act)
if (!m_active && shadeMode() == ShadeActivated) if (!m_active && shadeMode() == ShadeActivated)
setShade(ShadeNormal); setShade(ShadeNormal);
StackingUpdatesBlocker blocker(workspace());
workspace()->updateClientLayer(this); // active windows may get different layer
auto mainclients = mainClients();
for (auto it = mainclients.constBegin();
it != mainclients.constEnd();
++it)
if ((*it)->isFullScreen()) // fullscreens go high even if their transient is active
workspace()->updateClientLayer(*it);
doSetActive(); doSetActive();
emit activeChanged(); emit activeChanged();
updateMouseGrab(); updateMouseGrab();

9
activation.cpp
View file

@ -788,15 +788,6 @@ xcb_timestamp_t Client::userTime() const
void Client::doSetActive() void Client::doSetActive()
{ {
StackingUpdatesBlocker blocker(workspace());
workspace()->updateClientLayer(this); // active windows may get different layer
auto mainclients = mainClients();
for (auto it = mainclients.constBegin();
it != mainclients.constEnd();
++it)
if ((*it)->isFullScreen()) // fullscreens go high even if their transient is active
workspace()->updateClientLayer(*it);
updateUrgency(); // demand attention again if it's still urgent updateUrgency(); // demand attention again if it's still urgent
} }