yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid deleting an engine whilst components from our engine are still in use

Browse source 
Otherwise it can lead to crashes

Reviewed-by: Martin G
This commit is contained in:
David Edmundson 2015-01-28 14:12:25 +01:00
parent 63885cc5b3
commit b62bf43236
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
View file

@ -53,6 +53,7 @@ PreviewItem::PreviewItem(QQuickItem *parent)
PreviewItem::~PreviewItem() PreviewItem::~PreviewItem()
{ {
m_decoration->deleteLater();
if (m_bridge){ if (m_bridge){
m_bridge->unregisterPreviewItem(this); m_bridge->unregisterPreviewItem(this);
} }
@ -74,7 +75,7 @@ void PreviewItem::createDecoration()
if (m_bridge.isNull() || m_settings.isNull() || m_decoration) { if (m_bridge.isNull() || m_settings.isNull() || m_decoration) {
return; return;
} }
m_decoration = m_bridge->createDecoration(this); m_decoration = m_bridge->createDecoration(0);
if (!m_decoration) { if (!m_decoration) {
return; return;
} }