yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

do not call showOnScreenEdge for *all* clients

Browse source 
when managing them or they change their geometry
what will (aside the overehad) randomly show them
on screen

REVIEW: 124814
This commit is contained in:
Thomas Lübking 2015-08-19 11:24:22 +02:00
parent f96836b2df
commit b7bb7222f4
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
screenedge.cpp
View file

@ -1077,9 +1077,11 @@ void ScreenEdges::unreserve(ElectricBorder border, QObject *object)
void ScreenEdges::reserve(Client *client, ElectricBorder border) void ScreenEdges::reserve(Client *client, ElectricBorder border)
{ {
bool hadBorder = false;
auto it = m_edges.begin(); auto it = m_edges.begin();
while (it != m_edges.end()) { while (it != m_edges.end()) {
if ((*it)->client() == client) { if ((*it)->client() == client) {
hadBorder = true;
if ((*it)->border() == border) { if ((*it)->border() == border) {
if (client->isHiddenInternal() && !(*it)->isReserved()) { if (client->isHiddenInternal() && !(*it)->isReserved()) {
(*it)->reserve(); (*it)->reserve();
@ -1093,9 +1095,15 @@ void ScreenEdges::reserve(Client *client, ElectricBorder border)
it++; it++;
} }
} }
createEdgeForClient(client, border);
connect(client, &Client::geometryChanged, this, &ScreenEdges::handleClientGeometryChanged); if (border != ElectricNone) {
connect(client, &Client::geometryChanged, this, &ScreenEdges::handleClientGeometryChanged, Qt::UniqueConnection);
createEdgeForClient(client, border);
} else {
disconnect(client, &Client::geometryChanged, this, &ScreenEdges::handleClientGeometryChanged);
if (hadBorder) // show again
client->showOnScreenEdge();
}
} }
void ScreenEdges::createEdgeForClient(Client *client, ElectricBorder border) void ScreenEdges::createEdgeForClient(Client *client, ElectricBorder border)