From bc0502b3cac939c5e75e63385dc9b4e2f32e9925 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Wed, 22 Feb 2023 10:18:39 +0200 Subject: [PATCH] effects: Fix selecting hidden windows using keyboard WindowHeapDelegate used to have hidden property. It was renamed to activeHidden, but WindowHeap has not been adjusted to the new name. BUG: 466120 --- src/effects/private/qml/WindowHeap.qml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/effects/private/qml/WindowHeap.qml b/src/effects/private/qml/WindowHeap.qml index 7cd2db3c35..846a660866 100644 --- a/src/effects/private/qml/WindowHeap.qml +++ b/src/effects/private/qml/WindowHeap.qml @@ -161,7 +161,7 @@ FocusScope { function findFirstItem() { for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { const candidateItem = windowsInstantiator.objectAt(candidateIndex); - if (!candidateItem.hidden) { + if (!candidateItem.activeHidden) { return candidateIndex; } } @@ -180,7 +180,7 @@ FocusScope { case WindowHeap.Direction.Left: for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { const candidateItem = windowsInstantiator.objectAt(candidateIndex); - if (candidateItem.hidden) { + if (candidateItem.activeHidden) { continue; } @@ -205,7 +205,7 @@ FocusScope { case WindowHeap.Direction.Right: for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { const candidateItem = windowsInstantiator.objectAt(candidateIndex); - if (candidateItem.hidden) { + if (candidateItem.activeHidden) { continue; } @@ -230,7 +230,7 @@ FocusScope { case WindowHeap.Direction.Up: for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { const candidateItem = windowsInstantiator.objectAt(candidateIndex); - if (candidateItem.hidden) { + if (candidateItem.activeHidden) { continue; } @@ -255,7 +255,7 @@ FocusScope { case WindowHeap.Direction.Down: for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { const candidateItem = windowsInstantiator.objectAt(candidateIndex); - if (candidateItem.hidden) { + if (candidateItem.activeHidden) { continue; } @@ -361,7 +361,7 @@ FocusScope { // If the window heap has only one visible window, activate it. for (let i = 0; i < windowsInstantiator.count; ++i) { const candidateItem = windowsInstantiator.objectAt(i); - if (candidateItem.hidden) { + if (candidateItem.activeHidden) { continue; } else if (selectedItem) { selectedItem = null;