yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/x11: Use more UniqueCPtr

Browse source
This commit is contained in:
Vlad Zahorodnii 2023-03-09 17:08:36 +02:00
parent 19fec2a657
commit bd91f77212
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/backends/x11/windowed/x11_windowed_backend.cpp
View file

@ -211,14 +211,13 @@ bool X11WindowedBackend::initialize()
if (presentExtension && presentExtension->present) { if (presentExtension && presentExtension->present) {
m_presentOpcode = presentExtension->major_opcode; m_presentOpcode = presentExtension->major_opcode;
xcb_present_query_version_cookie_t cookie = xcb_present_query_version(m_connection, 1, 2); xcb_present_query_version_cookie_t cookie = xcb_present_query_version(m_connection, 1, 2);
xcb_present_query_version_reply_t *reply = xcb_present_query_version_reply(m_connection, cookie, nullptr); UniqueCPtr<xcb_present_query_version_reply_t> reply(xcb_present_query_version_reply(m_connection, cookie, nullptr));
if (!reply) { if (!reply) {
qCWarning(KWIN_X11WINDOWED) << "Requested Present extension version is unsupported"; qCWarning(KWIN_X11WINDOWED) << "Requested Present extension version is unsupported";
return false; return false;
} }
m_presentMajorVersion = reply->major_version; m_presentMajorVersion = reply->major_version;
m_presentMinorVersion = reply->minor_version; m_presentMinorVersion = reply->minor_version;
free(reply);
} else { } else {
qCWarning(KWIN_X11WINDOWED) << "Present X11 extension is unavailable"; qCWarning(KWIN_X11WINDOWED) << "Present X11 extension is unavailable";
return false; return false;
@ -227,7 +226,7 @@ bool X11WindowedBackend::initialize()
const xcb_query_extension_reply_t *shmExtension = xcb_get_extension_data(m_connection, &xcb_shm_id); const xcb_query_extension_reply_t *shmExtension = xcb_get_extension_data(m_connection, &xcb_shm_id);
if (shmExtension && shmExtension->present) { if (shmExtension && shmExtension->present) {
xcb_shm_query_version_cookie_t cookie = xcb_shm_query_version(m_connection); xcb_shm_query_version_cookie_t cookie = xcb_shm_query_version(m_connection);
xcb_shm_query_version_reply_t *reply = xcb_shm_query_version_reply(m_connection, cookie, nullptr); UniqueCPtr<xcb_shm_query_version_reply_t> reply(xcb_shm_query_version_reply(m_connection, cookie, nullptr));
if (!reply) { if (!reply) {
qCWarning(KWIN_X11WINDOWED) << "Requested SHM extension version is unsupported"; qCWarning(KWIN_X11WINDOWED) << "Requested SHM extension version is unsupported";
} else { } else {
@ -236,7 +235,6 @@ bool X11WindowedBackend::initialize()
} else { } else {
m_hasShm = true; m_hasShm = true;
} }
free(reply);
} }
} }