From bfccb15d2f20681d29a88b1fdc7c31b336edace9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Wed, 4 Mar 2015 07:43:21 +0100 Subject: [PATCH] [server] Don't set a parent on BufferInterface BufferInterface used to have a SurfaceInterface as parent. This could result in easily hitting the abort condition that the BufferInterface was still referenced when it gets deleted by just having one other user referencing the BufferInterface. There is no need to have the BufferInterface deleted when the SurfaceInterface to which it belongs gets deleted. The BufferInterface will get deleted once it's completely unreferenced and also has a destroy listener. --- src/wayland/server/buffer_interface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland/server/buffer_interface.cpp b/src/wayland/server/buffer_interface.cpp index 621605edb9..943804d3cd 100644 --- a/src/wayland/server/buffer_interface.cpp +++ b/src/wayland/server/buffer_interface.cpp @@ -126,7 +126,7 @@ BufferInterface::Private::~Private() } BufferInterface::BufferInterface(wl_resource *resource, SurfaceInterface *parent) - : QObject(parent) + : QObject() , d(new Private(this, resource, parent)) { }