yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[libinput] A not valid LibInput::Context should return -1 as filedescriptor

Browse source 
0 is a valid filedescriptor after all.

Autotest extended to cover this case.
This commit is contained in:
Martin Gräßlin 2016-06-02 16:23:23 +02:00
parent 2d9ff54e68
commit c04f193532
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
autotests/libinput/context_test.cpp
View file

@ -54,6 +54,8 @@ void TestContext::testCreateFailUdev()
// should not have a valid libinput
libinput *libinput = context;
QVERIFY(!libinput);
QVERIFY(!context.assignSeat("testSeat"));
QCOMPARE(context.fileDescriptor(), -1);
}
void TestContext::testAssignSeat_data()

2
libinput/context.cpp
View file

@ -81,7 +81,7 @@ bool Context::assignSeat(const char *seat)
int Context::fileDescriptor()
{
if (!isValid()) {
return 0;
return -1;
}
return libinput_get_fd(m_libinput);
}