yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move moveResizeGeom to AbstractClient

Browse source 
Biggest impact on Client::handleMoveResize which directly manipulated
the variable in various parts. I tried to keep the impact low.
This commit is contained in:
Martin Gräßlin 2015-10-16 11:13:41 +02:00
parent b4fc4d7235
commit c3f14521c1
4 changed files with 44 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
abstract_client.cpp
View file

@ -1062,6 +1062,7 @@ void AbstractClient::doMove(int, int)
void AbstractClient::updateInitialMoveResizeGeometry() void AbstractClient::updateInitialMoveResizeGeometry()
{ {
m_moveResize.initialGeometry = geometry(); m_moveResize.initialGeometry = geometry();
m_moveResize.geometry = m_moveResize.initialGeometry;
} }
} }

7
abstract_client.h
View file

@ -642,6 +642,12 @@ protected:
* Sets the initial move resize geometry to the current geometry. * Sets the initial move resize geometry to the current geometry.
**/ **/
void updateInitialMoveResizeGeometry(); void updateInitialMoveResizeGeometry();
QRect moveResizeGeometry() const {
return m_moveResize.geometry;
}
void setMoveResizeGeometry(const QRect &geo) {
m_moveResize.geometry = geo;
}
private: private:
void handlePaletteChange(); void handlePaletteChange();
@ -695,6 +701,7 @@ private:
QPoint offset; QPoint offset;
QPoint invertedOffset; QPoint invertedOffset;
QRect initialGeometry; QRect initialGeometry;
QRect geometry;
} m_moveResize; } m_moveResize;
}; };

1
client.h
View file

@ -637,7 +637,6 @@ private:
bool m_managed; bool m_managed;
Position mode; Position mode;
QRect moveResizeGeom;
Xcb::GeometryHints m_geometryHints; Xcb::GeometryHints m_geometryHints;
void sendSyntheticConfigureNotify(); void sendSyntheticConfigureNotify();
enum MappingState { enum MappingState {

60
geometry.cpp
View file

@ -2592,7 +2592,7 @@ void Client::positionGeometryTip()
if (!geometryTip) { if (!geometryTip) {
geometryTip = new GeometryTip(&m_geometryHints); geometryTip = new GeometryTip(&m_geometryHints);
} }
QRect wgeom(moveResizeGeom); // position of the frame, size of the window itself QRect wgeom(moveResizeGeometry()); // position of the frame, size of the window itself
wgeom.setWidth(wgeom.width() - (width() - clientSize().width())); wgeom.setWidth(wgeom.width() - (width() - clientSize().width()));
wgeom.setHeight(wgeom.height() - (height() - clientSize().height())); wgeom.setHeight(wgeom.height() - (height() - clientSize().height()));
if (isShade()) if (isShade())
@ -2658,7 +2658,6 @@ bool Client::startMoveResize()
s_haveResizeEffect = effects && static_cast<EffectsHandlerImpl*>(effects)->provides(Effect::Resize); s_haveResizeEffect = effects && static_cast<EffectsHandlerImpl*>(effects)->provides(Effect::Resize);
moveResizeStartScreen = screen(); moveResizeStartScreen = screen();
updateInitialMoveResizeGeometry(); updateInitialMoveResizeGeometry();
moveResizeGeom = geometry();
checkUnrestrictedMoveResize(); checkUnrestrictedMoveResize();
emit clientStartUserMovedResized(this); emit clientStartUserMovedResized(this);
if (ScreenEdges::self()->isDesktopSwitchingMovingClients()) if (ScreenEdges::self()->isDesktopSwitchingMovingClients())
@ -2674,6 +2673,7 @@ void Client::finishMoveResize(bool cancel)
if (cancel) if (cancel)
setGeometry(initialMoveResizeGeometry()); setGeometry(initialMoveResizeGeometry());
else { else {
const QRect &moveResizeGeom = moveResizeGeometry();
if (wasResize) { if (wasResize) {
const bool restoreH = maximizeMode() == MaximizeHorizontal && const bool restoreH = maximizeMode() == MaximizeHorizontal &&
moveResizeGeom.width() != initialMoveResizeGeometry().width(); moveResizeGeom.width() != initialMoveResizeGeometry().width();
@ -2751,6 +2751,7 @@ void Client::checkUnrestrictedMoveResize()
{ {
if (isUnrestrictedMoveResize()) if (isUnrestrictedMoveResize())
return; return;
const QRect &moveResizeGeom = moveResizeGeometry();
QRect desktopArea = workspace()->clientArea(WorkArea, moveResizeGeom.center(), desktop()); QRect desktopArea = workspace()->clientArea(WorkArea, moveResizeGeom.center(), desktop());
int left_marge, right_marge, top_marge, bottom_marge, titlebar_marge; int left_marge, right_marge, top_marge, bottom_marge, titlebar_marge;
// restricted move/resize - keep at least part of the titlebar always visible // restricted move/resize - keep at least part of the titlebar always visible
@ -2829,7 +2830,7 @@ void Client::handleMoveResize(const QPoint &local, const QPoint &global)
setMoveOffset(QPoint(double(moveOffset().x()) / double(oldGeo.width()) * double(geom_restore.width()), setMoveOffset(QPoint(double(moveOffset().x()) / double(oldGeo.width()) * double(geom_restore.width()),
double(moveOffset().y()) / double(oldGeo.height()) * double(geom_restore.height()))); double(moveOffset().y()) / double(oldGeo.height()) * double(geom_restore.height())));
if (rules()->checkMaximize(MaximizeRestore) == MaximizeRestore) if (rules()->checkMaximize(MaximizeRestore) == MaximizeRestore)
moveResizeGeom = geom_restore; setMoveResizeGeometry(geom_restore);
handleMoveResize(local.x(), local.y(), global.x(), global.y()); // fix position handleMoveResize(local.x(), local.y(), global.x(), global.y()); // fix position
} else if (quickTileMode() == QuickTileNone && isResizable()) { } else if (quickTileMode() == QuickTileNone && isResizable()) {
checkQuickTilingMaximizationZones(global.x(), global.y()); checkQuickTilingMaximizationZones(global.x(), global.y());
@ -2868,11 +2869,12 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
// the bottomleft corner should be at is at (topleft.x(), bottomright().y()) // the bottomleft corner should be at is at (topleft.x(), bottomright().y())
QPoint topleft = globalPos - moveOffset(); QPoint topleft = globalPos - moveOffset();
QPoint bottomright = globalPos + invertedMoveOffset(); QPoint bottomright = globalPos + invertedMoveOffset();
QRect previousMoveResizeGeom = moveResizeGeom; QRect previousMoveResizeGeom = moveResizeGeometry();
// TODO move whole group when moving its leader or when the leader is not mapped? // TODO move whole group when moving its leader or when the leader is not mapped?
auto titleBarRect = [this](bool &transposed, int &requiredPixels) -> QRect { auto titleBarRect = [this](bool &transposed, int &requiredPixels) -> QRect {
const QRect &moveResizeGeom = moveResizeGeometry();
QRect r(moveResizeGeom); QRect r(moveResizeGeom);
r.moveTopLeft(QPoint(0,0)); r.moveTopLeft(QPoint(0,0));
switch (titlebarPosition()) { switch (titlebarPosition()) {
@ -2906,31 +2908,31 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
auto calculateMoveResizeGeom = [this, &topleft, &bottomright, &orig, &sizemode]() { auto calculateMoveResizeGeom = [this, &topleft, &bottomright, &orig, &sizemode]() {
switch(mode) { switch(mode) {
case PositionTopLeft: case PositionTopLeft:
moveResizeGeom = QRect(topleft, orig.bottomRight()) ; setMoveResizeGeometry(QRect(topleft, orig.bottomRight()));
break; break;
case PositionBottomRight: case PositionBottomRight:
moveResizeGeom = QRect(orig.topLeft(), bottomright) ; setMoveResizeGeometry(QRect(orig.topLeft(), bottomright));
break; break;
case PositionBottomLeft: case PositionBottomLeft:
moveResizeGeom = QRect(QPoint(topleft.x(), orig.y()), QPoint(orig.right(), bottomright.y())) ; setMoveResizeGeometry(QRect(QPoint(topleft.x(), orig.y()), QPoint(orig.right(), bottomright.y())));
break; break;
case PositionTopRight: case PositionTopRight:
moveResizeGeom = QRect(QPoint(orig.x(), topleft.y()), QPoint(bottomright.x(), orig.bottom())) ; setMoveResizeGeometry(QRect(QPoint(orig.x(), topleft.y()), QPoint(bottomright.x(), orig.bottom())));
break; break;
case PositionTop: case PositionTop:
moveResizeGeom = QRect(QPoint(orig.left(), topleft.y()), orig.bottomRight()) ; setMoveResizeGeometry(QRect(QPoint(orig.left(), topleft.y()), orig.bottomRight()));
sizemode = SizemodeFixedH; // try not to affect height sizemode = SizemodeFixedH; // try not to affect height
break; break;
case PositionBottom: case PositionBottom:
moveResizeGeom = QRect(orig.topLeft(), QPoint(orig.right(), bottomright.y())) ; setMoveResizeGeometry(QRect(orig.topLeft(), QPoint(orig.right(), bottomright.y())));
sizemode = SizemodeFixedH; sizemode = SizemodeFixedH;
break; break;
case PositionLeft: case PositionLeft:
moveResizeGeom = QRect(QPoint(topleft.x(), orig.top()), orig.bottomRight()) ; setMoveResizeGeometry(QRect(QPoint(topleft.x(), orig.top()), orig.bottomRight()));
sizemode = SizemodeFixedW; sizemode = SizemodeFixedW;
break; break;
case PositionRight: case PositionRight:
moveResizeGeom = QRect(orig.topLeft(), QPoint(bottomright.x(), orig.bottom())) ; setMoveResizeGeometry(QRect(orig.topLeft(), QPoint(bottomright.x(), orig.bottom())));
sizemode = SizemodeFixedW; sizemode = SizemodeFixedW;
break; break;
case PositionCenter: case PositionCenter:
@ -2943,7 +2945,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
// first resize (without checking constrains), then snap, then check bounds, then check constrains // first resize (without checking constrains), then snap, then check bounds, then check constrains
calculateMoveResizeGeom(); calculateMoveResizeGeom();
// adjust new size to snap to other windows/borders // adjust new size to snap to other windows/borders
moveResizeGeom = workspace()->adjustClientSize(this, moveResizeGeom, mode); setMoveResizeGeometry(workspace()->adjustClientSize(this, moveResizeGeometry(), mode));
if (!isUnrestrictedMoveResize()) { if (!isUnrestrictedMoveResize()) {
// Make sure the titlebar isn't behind a restricted area. We don't need to restrict // Make sure the titlebar isn't behind a restricted area. We don't need to restrict
@ -2955,10 +2957,10 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
int requiredPixels; int requiredPixels;
QRect bTitleRect = titleBarRect(transposed, requiredPixels); QRect bTitleRect = titleBarRect(transposed, requiredPixels);
int lastVisiblePixels = -1; int lastVisiblePixels = -1;
QRect lastTry = moveResizeGeom; QRect lastTry = moveResizeGeometry();
bool titleFailed = false; bool titleFailed = false;
for (;;) { for (;;) {
const QRect titleRect(bTitleRect.translated(moveResizeGeom.topLeft())); const QRect titleRect(bTitleRect.translated(moveResizeGeometry().topLeft()));
int visiblePixels = 0; int visiblePixels = 0;
int realVisiblePixels = 0; int realVisiblePixels = 0;
foreach (const QRect &rect, availableArea.rects()) { foreach (const QRect &rect, availableArea.rects()) {
@ -2977,11 +2979,12 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
break; // we won't become better break; // we won't become better
else { else {
if (!titleFailed) if (!titleFailed)
moveResizeGeom = lastTry; setMoveResizeGeometry(lastTry);
titleFailed = true; titleFailed = true;
} }
} }
lastVisiblePixels = realVisiblePixels; lastVisiblePixels = realVisiblePixels;
QRect moveResizeGeom = moveResizeGeometry();
lastTry = moveResizeGeom; lastTry = moveResizeGeom;
// Not visible enough, move the window to the closest valid point. We bruteforce // Not visible enough, move the window to the closest valid point. We bruteforce
@ -3026,15 +3029,16 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
moveResizeGeom.setRight(moveResizeGeom.right() + sign(previousMoveResizeGeom.right() - moveResizeGeom.right())); moveResizeGeom.setRight(moveResizeGeom.right() + sign(previousMoveResizeGeom.right() - moveResizeGeom.right()));
else else
break; // no position changed - that's certainly not good break; // no position changed - that's certainly not good
setMoveResizeGeometry(moveResizeGeom);
} }
} }
// Always obey size hints, even when in "unrestricted" mode // Always obey size hints, even when in "unrestricted" mode
QSize size = adjustedSize(moveResizeGeom.size(), sizemode); QSize size = adjustedSize(moveResizeGeometry().size(), sizemode);
// the new topleft and bottomright corners (after checking size constrains), if they'll be needed // the new topleft and bottomright corners (after checking size constrains), if they'll be needed
topleft = QPoint(moveResizeGeom.right() - size.width() + 1, moveResizeGeom.bottom() - size.height() + 1); topleft = QPoint(moveResizeGeometry().right() - size.width() + 1, moveResizeGeometry().bottom() - size.height() + 1);
bottomright = QPoint(moveResizeGeom.left() + size.width() - 1, moveResizeGeom.top() + size.height() - 1); bottomright = QPoint(moveResizeGeometry().left() + size.width() - 1, moveResizeGeometry().top() + size.height() - 1);
orig = moveResizeGeom; orig = moveResizeGeometry();
// if aspect ratios are specified, both dimensions may change. // if aspect ratios are specified, both dimensions may change.
// Therefore grow to the right/bottom if needed. // Therefore grow to the right/bottom if needed.
@ -3046,7 +3050,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
calculateMoveResizeGeom(); calculateMoveResizeGeom();
if (moveResizeGeom.size() != previousMoveResizeGeom.size()) if (moveResizeGeometry().size() != previousMoveResizeGeom.size())
update = true; update = true;
} else if (isMove()) { } else if (isMove()) {
assert(mode == PositionCenter); assert(mode == PositionCenter);
@ -3054,21 +3058,24 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
// Special moving of maximized windows on Xinerama screens // Special moving of maximized windows on Xinerama screens
int screen = screens()->number(globalPos); int screen = screens()->number(globalPos);
if (isFullScreen()) if (isFullScreen())
moveResizeGeom = workspace()->clientArea(FullScreenArea, screen, 0); setMoveResizeGeometry(workspace()->clientArea(FullScreenArea, screen, 0));
else { else {
moveResizeGeom = workspace()->clientArea(MaximizeArea, screen, 0); QRect moveResizeGeom = workspace()->clientArea(MaximizeArea, screen, 0);
QSize adjSize = adjustedSize(moveResizeGeom.size(), SizemodeMax); QSize adjSize = adjustedSize(moveResizeGeom.size(), SizemodeMax);
if (adjSize != moveResizeGeom.size()) { if (adjSize != moveResizeGeom.size()) {
QRect r(moveResizeGeom); QRect r(moveResizeGeom);
moveResizeGeom.setSize(adjSize); moveResizeGeom.setSize(adjSize);
moveResizeGeom.moveCenter(r.center()); moveResizeGeom.moveCenter(r.center());
} }
setMoveResizeGeometry(moveResizeGeom);
} }
} else { } else {
// first move, then snap, then check bounds // first move, then snap, then check bounds
QRect moveResizeGeom = moveResizeGeometry();
moveResizeGeom.moveTopLeft(topleft); moveResizeGeom.moveTopLeft(topleft);
moveResizeGeom.moveTopLeft(workspace()->adjustClientPosition(this, moveResizeGeom.topLeft(), moveResizeGeom.moveTopLeft(workspace()->adjustClientPosition(this, moveResizeGeom.topLeft(),
isUnrestrictedMoveResize())); isUnrestrictedMoveResize()));
setMoveResizeGeometry(moveResizeGeom);
if (!isUnrestrictedMoveResize()) { if (!isUnrestrictedMoveResize()) {
const QRegion strut = workspace()->restrictedMoveArea(desktop()); // Strut areas const QRegion strut = workspace()->restrictedMoveArea(desktop()); // Strut areas
@ -3078,6 +3085,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
int requiredPixels; int requiredPixels;
QRect bTitleRect = titleBarRect(transposed, requiredPixels); QRect bTitleRect = titleBarRect(transposed, requiredPixels);
for (;;) { for (;;) {
QRect moveResizeGeom = moveResizeGeometry();
const QRect titleRect(bTitleRect.translated(moveResizeGeom.topLeft())); const QRect titleRect(bTitleRect.translated(moveResizeGeom.topLeft()));
int visiblePixels = 0; int visiblePixels = 0;
foreach (const QRect &rect, availableArea.rects()) { foreach (const QRect &rect, availableArea.rects()) {
@ -3110,6 +3118,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
} }
if (newTitleTop > -1) { if (newTitleTop > -1) {
moveResizeGeom.moveTop(newTitleTop); // invalid position, possibly on screen change moveResizeGeom.moveTop(newTitleTop); // invalid position, possibly on screen change
setMoveResizeGeometry(moveResizeGeom);
break; break;
} }
} }
@ -3123,6 +3132,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
// Move it back // Move it back
moveResizeGeom.translate(dx, dy); moveResizeGeom.translate(dx, dy);
setMoveResizeGeometry(moveResizeGeom);
if (moveResizeGeom == previousMoveResizeGeom) { if (moveResizeGeom == previousMoveResizeGeom) {
break; // Prevent lockup break; // Prevent lockup
@ -3130,7 +3140,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
} }
} }
} }
if (moveResizeGeom.topLeft() != previousMoveResizeGeom.topLeft()) if (moveResizeGeometry().topLeft() != previousMoveResizeGeom.topLeft())
update = true; update = true;
} else } else
abort(); abort();
@ -3151,6 +3161,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
syncRequest.isPending = true; // limit the resizes to 30Hz to take pointless load from X11 syncRequest.isPending = true; // limit the resizes to 30Hz to take pointless load from X11
syncRequest.timeout->start(33); // and the client, the mouse is still moved at full speed syncRequest.timeout->start(33); // and the client, the mouse is still moved at full speed
} // and no human can control faster resizes anyway } // and no human can control faster resizes anyway
const QRect &moveResizeGeom = moveResizeGeometry();
m_client.setGeometry(0, 0, moveResizeGeom.width() - (borderLeft() + borderRight()), moveResizeGeom.height() - (borderTop() + borderBottom())); m_client.setGeometry(0, 0, moveResizeGeom.width() - (borderLeft() + borderRight()), moveResizeGeom.height() - (borderTop() + borderBottom()));
} else } else
performMoveResize(); performMoveResize();
@ -3162,6 +3173,7 @@ void Client::handleMoveResize(int x, int y, int x_root, int y_root)
void Client::performMoveResize() void Client::performMoveResize()
{ {
const QRect &moveResizeGeom = moveResizeGeometry();
if (isMove() || (isResize() && !s_haveResizeEffect)) { if (isMove() || (isResize() && !s_haveResizeEffect)) {
setGeometry(moveResizeGeom); setGeometry(moveResizeGeom);
} }