From c3f2b68581d5b9a4afaa543a3f78f4f84b0f65e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Fri, 26 Oct 2012 09:36:51 +0200 Subject: [PATCH] Protect access to EffectFrame if not used Caused a crash when Show Text was disabled. --- effects/mouseclick/mouseclick.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/effects/mouseclick/mouseclick.cpp b/effects/mouseclick/mouseclick.cpp index 5eb5e59aac..41472374ef 100644 --- a/effects/mouseclick/mouseclick.cpp +++ b/effects/mouseclick/mouseclick.cpp @@ -196,7 +196,10 @@ void MouseClickEffect::repaint() int ymax = 0; int yfontMax = 0; foreach (MouseEvent* click, m_clicks) { - QRect fontGeo = click->m_frame->geometry(); + QRect fontGeo; + if (click->m_frame) { + fontGeo = click->m_frame->geometry(); + } xmin = qMin(xmin, click->m_pos.x()); ymin = qMin(ymin, click->m_pos.y()); xmax = qMax(xmax, click->m_pos.x() + (fontGeo.width() + 10));