From c9a719e109fc7b941baa582f95960c87d581e2de Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Thu, 17 Jun 2021 14:01:48 -0600 Subject: [PATCH] [effects] Use standard arrow cursor in Present Windows & Desktop Grid The pointing finger cursor is used to show that a piece of text is a clickable link, and it is inappropriate to use it in other contexts. Regular UI elements that do something when single-clicked continue to use the standard arrow cursor in other contexts, so let's follow that convention in the Present Windows and Desktop Grid effects too. BUG: 421928 FIXED-IN: 5.23 --- src/effects/desktopgrid/desktopgrid.cpp | 4 ++-- src/effects/presentwindows/presentwindows.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/effects/desktopgrid/desktopgrid.cpp b/src/effects/desktopgrid/desktopgrid.cpp index 153da09939..1793c47c40 100644 --- a/src/effects/desktopgrid/desktopgrid.cpp +++ b/src/effects/desktopgrid/desktopgrid.cpp @@ -610,7 +610,7 @@ void DesktopGridEffect::windowInputMouseEvent(QEvent* e) } } if (wasWindowMove || wasDesktopMove) { // reset pointer - effects->defineCursor(Qt::PointingHandCursor); + effects->defineCursor(Qt::ArrowCursor); } else { // click -> exit const int desk = posToDesktop(me->pos()); if (desk > effects->numberOfDesktops()) @@ -1036,7 +1036,7 @@ void DesktopGridEffect::setup() return; if (!keyboardGrab) { keyboardGrab = effects->grabKeyboard(this); - effects->startMouseInterception(this, Qt::PointingHandCursor); + effects->startMouseInterception(this, Qt::ArrowCursor); effects->setActiveFullScreenEffect(this); } setHighlightedDesktop(effects->currentDesktop()); diff --git a/src/effects/presentwindows/presentwindows.cpp b/src/effects/presentwindows/presentwindows.cpp index b2a31c9c72..3101398c75 100644 --- a/src/effects/presentwindows/presentwindows.cpp +++ b/src/effects/presentwindows/presentwindows.cpp @@ -1650,7 +1650,7 @@ void PresentWindowsEffect::setActive(bool active) } // Create temporary input window to catch mouse events - effects->startMouseInterception(this, Qt::PointingHandCursor); + effects->startMouseInterception(this, Qt::ArrowCursor); m_hasKeyboardGrab = effects->grabKeyboard(this); effects->setActiveFullScreenEffect(this);