yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

catch nullptr effects when deleting shadows

Browse source 
the shadow can be deleted deferred from an update
there's a slight chance, to be eg. triggered by clients
blocking compositing, that the compositor is suspended in the same
cycle and the effects pointer (and scene and context) thus gone

CCBUG: 356938
FIXED-IN: 5.6
REVIEW: 126441
This commit is contained in:
Thomas Lübking 2015-12-21 00:18:00 +01:00
parent 070b85bbcf
commit cae90bb035
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scene_opengl.cpp
View file

@ -2195,9 +2195,11 @@ SceneOpenGLShadow::SceneOpenGLShadow(Toplevel *toplevel)
SceneOpenGLShadow::~SceneOpenGLShadow() SceneOpenGLShadow::~SceneOpenGLShadow()
{ {
effects->makeOpenGLContextCurrent(); if (effects) {
DecorationShadowTextureCache::instance().unregister(this); effects->makeOpenGLContextCurrent();
m_texture.reset(); DecorationShadowTextureCache::instance().unregister(this);
m_texture.reset();
}
} }
void SceneOpenGLShadow::buildQuads() void SceneOpenGLShadow::buildQuads()