yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[GenericScriptedConfig] Remove unused parameter

Browse source 
The passed value is always the same and never used
This commit is contained in:
Nicolas Fella 2021-07-21 21:22:48 +02:00
parent 55c6de1790
commit cff33e7e40
2 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/scripting/genericscriptedconfig.cpp
View file

@ -30,18 +30,17 @@ QObject *GenericScriptedConfigFactory::create(const char *iface, QWidget *parent
Q_UNUSED(iface)
Q_UNUSED(parent)
if (keyword.startsWith(QLatin1String("kwin4_effect_"))) {
return new ScriptedEffectConfig(QStringLiteral("kcm_kwin4_genericscripted"), keyword, parentWidget, args);
return new ScriptedEffectConfig(keyword, parentWidget, args);
} else {
return new ScriptingConfig(QStringLiteral("kcm_kwin4_genericscripted"), keyword, parentWidget, args);
return new ScriptingConfig(keyword, parentWidget, args);
}
}
GenericScriptedConfig::GenericScriptedConfig(const QString &componentName, const QString &keyword, QWidget *parent, const QVariantList &args)
GenericScriptedConfig::GenericScriptedConfig(const QString &keyword, QWidget *parent, const QVariantList &args)
: KCModule(parent, args)
, m_packageName(keyword)
, m_translator(new KLocalizedTranslator(this))
{
Q_UNUSED(componentName);
QCoreApplication::instance()->installTranslator(m_translator);
}
@ -109,8 +108,8 @@ void GenericScriptedConfig::reload()
{
}
ScriptedEffectConfig::ScriptedEffectConfig(const QString &componentName, const QString &keyword, QWidget *parent, const QVariantList &args)
: GenericScriptedConfig(componentName, keyword, parent, args)
ScriptedEffectConfig::ScriptedEffectConfig(const QString &keyword, QWidget *parent, const QVariantList &args)
: GenericScriptedConfig(keyword, parent, args)
{
createUi();
}
@ -137,8 +136,8 @@ void ScriptedEffectConfig::reload()
interface.reconfigureEffect(packageName());
}
ScriptingConfig::ScriptingConfig(const QString &componentName, const QString &keyword, QWidget *parent, const QVariantList &args)
: GenericScriptedConfig(componentName, keyword, parent, args)
ScriptingConfig::ScriptingConfig(const QString &keyword, QWidget *parent, const QVariantList &args)
: GenericScriptedConfig(keyword, parent, args)
{
createUi();
}

6
src/scripting/genericscriptedconfig.h
View file

@ -34,7 +34,7 @@ class GenericScriptedConfig : public KCModule
Q_OBJECT
public:
GenericScriptedConfig(const QString &componentName, const QString &keyword, QWidget *parent, const QVariantList &args);
GenericScriptedConfig(const QString &keyword, QWidget *parent, const QVariantList &args);
~GenericScriptedConfig() override;
public Q_SLOTS:
@ -56,7 +56,7 @@ class ScriptedEffectConfig : public GenericScriptedConfig
{
Q_OBJECT
public:
ScriptedEffectConfig(const QString &componentName, const QString &keyword, QWidget *parent, const QVariantList &args);
ScriptedEffectConfig(const QString &keyword, QWidget *parent, const QVariantList &args);
~ScriptedEffectConfig() override;
protected:
QString typeName() const override;
@ -68,7 +68,7 @@ class ScriptingConfig : public GenericScriptedConfig
{
Q_OBJECT
public:
ScriptingConfig(const QString &componentName, const QString &keyword, QWidget *parent, const QVariantList &args);
ScriptingConfig(const QString &keyword, QWidget *parent, const QVariantList &args);
~ScriptingConfig() override;
protected: