yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

opengl: Correct order of transforms in GLTexturePrivate::updateMatrix

Browse source 
The textureToTransformMatrix should be applied first, otherwise the scale
transform is going to change the winding order of rotations.

In practice though, it shouldn't matter because these matrices are used
to downscale or upscale uv coordinates.
This commit is contained in:
Vlad Zahorodnii 2024-01-18 23:02:30 +02:00
parent 428758d33a
commit cffacc514d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/opengl/gltexture.cpp
View file

@ -500,14 +500,14 @@ void GLTexturePrivate::updateMatrix()
}
m_matrix[NormalizedCoordinates].translate(0.5, 0.5);
m_matrix[NormalizedCoordinates] *= textureToBufferMatrix;
// our Y axis is flipped vs OpenGL
m_matrix[NormalizedCoordinates].scale(1, -1);
m_matrix[NormalizedCoordinates] *= textureToBufferMatrix;
m_matrix[NormalizedCoordinates].translate(-0.5, -0.5);
m_matrix[UnnormalizedCoordinates].translate(m_size.width() / 2, m_size.height() / 2);
m_matrix[UnnormalizedCoordinates] *= textureToBufferMatrix;
m_matrix[UnnormalizedCoordinates].scale(1, -1);
m_matrix[UnnormalizedCoordinates] *= textureToBufferMatrix;
m_matrix[UnnormalizedCoordinates].translate(-m_size.width() / 2, -m_size.height() / 2);
}