From d0c93b5bc586ff353620cdf9f6a9970c27a3e658 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Wed, 4 Nov 2020 00:02:15 +0200 Subject: [PATCH] Post invalid_positioner error to the right resource The invalid_positioner error is defined for the xdg_wm_base interface, not xdg_surface. --- src/wayland/xdgshell_interface.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/wayland/xdgshell_interface.cpp b/src/wayland/xdgshell_interface.cpp index c0fcc779bd..2376d3829c 100644 --- a/src/wayland/xdgshell_interface.cpp +++ b/src/wayland/xdgshell_interface.cpp @@ -216,7 +216,9 @@ void XdgSurfaceInterfacePrivate::xdg_surface_get_popup(Resource *resource, uint3 XdgPositioner positioner = XdgPositioner::get(positionerResource); if (!positioner.isComplete()) { - wl_resource_post_error(resource->handle, QtWaylandServer::xdg_wm_base::error_invalid_positioner, + auto shellPrivate = XdgShellInterfacePrivate::get(shell); + wl_resource_post_error(shellPrivate->resourceForXdgSurface(q)->handle, + QtWaylandServer::xdg_wm_base::error_invalid_positioner, "xdg_positioner is incomplete"); return; }