From d27416983da13f4f350c2d0301c964ec2342b70e Mon Sep 17 00:00:00 2001 From: Hugo Pereira Da Costa Date: Mon, 7 Jan 2013 11:34:19 +0100 Subject: [PATCH] Fixed Krazy warning about explicit constructors. Fixed krazy warning about invalid ifdef guard in include Fixed Krazy warning about signal/slot normalization. fixed Krazy spelling warning in comments. --- .../config/oxygenanimationconfigwidget.cpp | 4 +-- clients/oxygen/config/oxygenconfig.cpp | 2 +- clients/oxygen/config/oxygenconfigwidget.cpp | 32 +++++++++---------- clients/oxygen/config/oxygenconfigwidget.h | 4 +-- .../oxygen/config/oxygenexceptiondialog.cpp | 20 ++++++------ 5 files changed, 31 insertions(+), 31 deletions(-) diff --git a/clients/oxygen/config/oxygenanimationconfigwidget.cpp b/clients/oxygen/config/oxygenanimationconfigwidget.cpp index 79ccddc221..32ddc93578 100644 --- a/clients/oxygen/config/oxygenanimationconfigwidget.cpp +++ b/clients/oxygen/config/oxygenanimationconfigwidget.cpp @@ -67,11 +67,11 @@ namespace Oxygen layout->addItem( new QSpacerItem( 0, 0, QSizePolicy::Minimum, QSizePolicy::MinimumExpanding ), _row, 1, 1, 1 ); ++_row; - connect( animationsEnabled(), SIGNAL( toggled( bool ) ), SLOT(updateChanged()) ); + connect( animationsEnabled(), SIGNAL(toggled(bool)), SLOT(updateChanged()) ); foreach( AnimationConfigItem* item, findChildren() ) { item->QWidget::setEnabled( false ); - connect( animationsEnabled(), SIGNAL( toggled( bool ) ), item, SLOT(setEnabled(bool)) ); + connect( animationsEnabled(), SIGNAL(toggled(bool)), item, SLOT(setEnabled(bool)) ); } } diff --git a/clients/oxygen/config/oxygenconfig.cpp b/clients/oxygen/config/oxygenconfig.cpp index 063c447028..037be09e71 100644 --- a/clients/oxygen/config/oxygenconfig.cpp +++ b/clients/oxygen/config/oxygenconfig.cpp @@ -69,7 +69,7 @@ namespace Oxygen _configWidget = new ConfigWidget( parent ); load(); - connect( _configWidget, SIGNAL( changed( bool ) ), SLOT(updateChanged()) ); + connect( _configWidget, SIGNAL(changed(bool)), SLOT(updateChanged()) ); _configWidget->show(); } diff --git a/clients/oxygen/config/oxygenconfigwidget.cpp b/clients/oxygen/config/oxygenconfigwidget.cpp index 137b371690..0fd5ec1901 100644 --- a/clients/oxygen/config/oxygenconfigwidget.cpp +++ b/clients/oxygen/config/oxygenconfigwidget.cpp @@ -63,31 +63,31 @@ namespace Oxygen toggleExpertModeInternal( false ); // connections - connect( ui._expertModeButton, SIGNAL( clicked( void ) ), SLOT( toggleExpertModeInternal( void ) ) ); - connect( _animationConfigWidget, SIGNAL( layoutChanged( void ) ), SLOT(updateLayout( void ) ) ); + connect( ui._expertModeButton, SIGNAL(clicked()), SLOT(toggleExpertModeInternal()) ); + connect( _animationConfigWidget, SIGNAL(layoutChanged()), SLOT(updateLayout()) ); // track ui changes - connect( ui.titleAlignment, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.buttonSize, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.frameBorder, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.blendColor, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); + connect( ui.titleAlignment, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.buttonSize, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.frameBorder, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.blendColor, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); - connect( ui.titleOutline, SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); - connect( ui.drawSizeGrip, SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); - connect( ui.narrowButtonSpacing, SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); - connect( ui.closeFromMenuButton, SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); - connect( ui.separatorMode, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); + connect( ui.titleOutline, SIGNAL(clicked()), SLOT(updateChanged()) ); + connect( ui.drawSizeGrip, SIGNAL(clicked()), SLOT(updateChanged()) ); + connect( ui.narrowButtonSpacing, SIGNAL(clicked()), SLOT(updateChanged()) ); + connect( ui.closeFromMenuButton, SIGNAL(clicked()), SLOT(updateChanged()) ); + connect( ui.separatorMode, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); // track exception changes - connect( ui.exceptions, SIGNAL( changed( bool ) ), SLOT( updateChanged( void ) ) ); + connect( ui.exceptions, SIGNAL(changed(bool)), SLOT(updateChanged()) ); // track shadow configuration changes - connect( shadowConfigurations[0], SIGNAL( changed( bool ) ), SLOT( updateChanged( void ) ) ); - connect( shadowConfigurations[1], SIGNAL( changed( bool ) ), SLOT( updateChanged( void ) ) ); + connect( shadowConfigurations[0], SIGNAL(changed(bool)), SLOT(updateChanged()) ); + connect( shadowConfigurations[1], SIGNAL(changed(bool)), SLOT(updateChanged()) ); // track animations changes - connect( ui.animationsEnabled, SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); - connect( _animationConfigWidget, SIGNAL( changed( bool ) ), SLOT( updateChanged( void ) ) ); + connect( ui.animationsEnabled, SIGNAL(clicked()), SLOT(updateChanged()) ); + connect( _animationConfigWidget, SIGNAL(changed(bool)), SLOT(updateChanged()) ); } diff --git a/clients/oxygen/config/oxygenconfigwidget.h b/clients/oxygen/config/oxygenconfigwidget.h index 875140363b..a4aada1c47 100644 --- a/clients/oxygen/config/oxygenconfigwidget.h +++ b/clients/oxygen/config/oxygenconfigwidget.h @@ -1,5 +1,5 @@ -#ifndef oxygenconfigurationui_h -#define oxygenconfigurationui_h +#ifndef oxygenconfigwidget_h +#define oxygenconfigwidget_h ////////////////////////////////////////////////////////////////////////////// // oxygenconfigurationui.h // ------------------- diff --git a/clients/oxygen/config/oxygenexceptiondialog.cpp b/clients/oxygen/config/oxygenexceptiondialog.cpp index 812d3a1aee..1d2b1b6dbf 100644 --- a/clients/oxygen/config/oxygenexceptiondialog.cpp +++ b/clients/oxygen/config/oxygenexceptiondialog.cpp @@ -51,21 +51,21 @@ namespace Oxygen _checkBoxes.insert( DrawSeparator, ui.separatorCheckBox ); // detect window properties - connect( ui.detectDialogButton, SIGNAL( clicked( void ) ), SLOT(selectWindowProperties()) ); + connect( ui.detectDialogButton, SIGNAL(clicked()), SLOT(selectWindowProperties()) ); // connections - connect( ui.exceptionType, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.exceptionEditor, SIGNAL( textChanged( const QString& ) ), SLOT( updateChanged( void ) ) ); - connect( ui.frameBorderComboBox, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.blendColorComboBox, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.sizeGripComboBox, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.titleOutlineComboBox, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); - connect( ui.separatorComboBox, SIGNAL( currentIndexChanged( int ) ), SLOT( updateChanged( void ) ) ); + connect( ui.exceptionType, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.exceptionEditor, SIGNAL(textChanged(QString)), SLOT(updateChanged()) ); + connect( ui.frameBorderComboBox, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.blendColorComboBox, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.sizeGripComboBox, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.titleOutlineComboBox, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); + connect( ui.separatorComboBox, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); for( CheckBoxMap::iterator iter = _checkBoxes.begin(); iter != _checkBoxes.end(); ++iter ) - { connect( iter.value(), SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); } + { connect( iter.value(), SIGNAL(clicked()), SLOT(updateChanged()) ); } - connect( ui.hideTitleBar, SIGNAL( clicked( void ) ), SLOT( updateChanged( void ) ) ); + connect( ui.hideTitleBar, SIGNAL(clicked()), SLOT(updateChanged()) ); } //___________________________________________