yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugins/magiclamp: Make it look good with hidden panels

Browse source 
If the panel is hidden, the animation can be clipped some distance away
from the screen edge. To fix that, move the icon offscreen.
This commit is contained in:
Vlad Zahorodnii 2023-05-18 06:53:57 +00:00
parent 2ff040a744
commit d3c82fa103
4 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/effects.cpp
View file

@ -1960,6 +1960,7 @@ WINDOW_HELPER(bool, isLockScreen, isLockScreen)
WINDOW_HELPER(pid_t, pid, pid)
WINDOW_HELPER(QUuid, internalId, internalId)
WINDOW_HELPER(bool, isMinimized, isMinimized)
WINDOW_HELPER(bool, isHidden, isHiddenInternal)
WINDOW_HELPER(bool, isModal, isModal)
WINDOW_HELPER(bool, isFullScreen, isFullScreen)
WINDOW_HELPER(bool, keepAbove, keepAbove)

1
src/effects.h
View file

@ -373,6 +373,7 @@ public:
bool isDeleted() const override;
bool isMinimized() const override;
bool isHidden() const override;
double opacity() const override;
QStringList activities() const override;

1
src/libkwineffects/kwineffects.h
View file

@ -2324,6 +2324,7 @@ public:
virtual void unrefWindow() = 0;
virtual bool isDeleted() const = 0;
virtual bool isHidden() const = 0;
virtual bool isMinimized() const = 0;
virtual double opacity() const = 0;

19
src/plugins/magiclamp/magiclamp.cpp
View file

@ -162,6 +162,25 @@ void MagicLampEffect::apply(EffectWindow *w, int mask, WindowPaintData &data, Wi
position = Right;
}
}
// If the panel is hidden, move the icon offscreen so the animation looks correct.
if (panel->isHidden()) {
const QRectF panelScreen = effects->clientArea(ScreenArea, panel);
switch (position) {
case Bottom:
icon.moveTop(panelScreen.y() + panelScreen.height());
break;
case Top:
icon.moveTop(panelScreen.y() - icon.height());
break;
case Left:
icon.moveLeft(panelScreen.x() - icon.width());
break;
case Right:
icon.moveLeft(panelScreen.x() + panelScreen.width());
break;
}
}
} else {
// we did not find a panel, so it might be autohidden
QRectF iconScreen = effects->clientArea(ScreenArea, icon.topLeft(), effects->currentDesktop());