yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Why doesn't my system crash when deleting uninitialized data? In

Browse source 
unrelated news the fade effect is broken again... This time it prevents
windows from ever being deleted. This commit message wins the "most
unrelated" award.
BUG: 185239

svn path=/trunk/KDE/kdebase/workspace/; revision=930448
This commit is contained in:
Lucas Murray 2009-02-23 14:24:20 +00:00
parent 1e616c6078
commit d4f16a8dca
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
effects/presentwindows/presentwindows.cpp
View file

@ -249,6 +249,8 @@ void PresentWindowsEffect::paintWindow( EffectWindow *w, int mask, QRegion regio
void PresentWindowsEffect::windowAdded( EffectWindow *w )
{
if( !m_activated )
return;
m_windowData[w].visible = isVisibleWindow( w );
m_windowData[w].opacity = 0.0;
m_windowData[w].highlight = 0.0;
@ -269,21 +271,22 @@ void PresentWindowsEffect::windowAdded( EffectWindow *w )
void PresentWindowsEffect::windowClosed( EffectWindow *w )
{
if( !m_activated )
return;
if( m_highlightedWindow == w )
setHighlightedWindow( findFirstWindow() );
m_windowData[w].visible = false; // TODO: Fix this so they do actually fade out
rearrangeWindows();
}
void PresentWindowsEffect::windowDeleted( EffectWindow *w )
{
if( m_windowData.contains( w ))
{
delete m_windowData[w].textFrame;
delete m_windowData[w].iconFrame;
m_windowData.remove( w );
}
if( !m_activated )
return;
delete m_windowData[w].textFrame;
delete m_windowData[w].iconFrame;
m_windowData.remove( w );
m_motionManager.unmanage( w );
rearrangeWindows();
}
bool PresentWindowsEffect::borderActivated( ElectricBorder border )