Merge branch 'Plasma/5.15'

This commit is contained in:
Vlad Zagorodniy 2019-03-11 09:23:51 +02:00
commit db1035fa47
2 changed files with 12 additions and 2 deletions

View file

@ -43,7 +43,17 @@ EffectsHandlerImplX11::EffectsHandlerImplX11(Compositor *compositor, Scene *scen
);
}
EffectsHandlerImplX11::~EffectsHandlerImplX11() = default;
EffectsHandlerImplX11::~EffectsHandlerImplX11()
{
// EffectsHandlerImpl tries to unload all effects when it's destroyed.
// The routine that unloads effects makes some calls (indirectly) to
// doUngrabKeyboard and doStopMouseInterception, which are virtual.
// Given that any call to a virtual function in the destructor of a base
// class will never go to a derived class, we have to unload effects
// here. Yeah, this is quite a bit ugly but it's fine; someday, X11
// will be dead (or not?).
unloadAllEffects();
}
bool EffectsHandlerImplX11::doGrabKeyboard()
{

View file

@ -35,7 +35,7 @@ class EffectsHandlerImplX11 : public EffectsHandlerImpl
Q_OBJECT
public:
explicit EffectsHandlerImplX11(Compositor *compositor, Scene *scene);
virtual ~EffectsHandlerImplX11();
~EffectsHandlerImplX11() override;
void defineCursor(Qt::CursorShape shape) override;