yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

launcher: Fix a file descriptor leak

Browse source 
The file descriptor must be closed after sending a ReleaseDevice request.
This commit is contained in:
Vlad Zahorodnii 2020-10-13 20:49:49 +03:00 committed by Aleix Pol Gonzalez
parent f369a3557c
commit dbf52ebda5
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
logind.cpp
View file

@ -378,14 +378,15 @@ void LogindIntegration::releaseDevice(int fd)
struct stat st;
if (fstat(fd, &st) < 0) {
qCDebug(KWIN_CORE) << "Could not stat the file descriptor";
return;
} else {
QDBusMessage message = QDBusMessage::createMethodCall(m_sessionControllerService,
m_sessionPath,
m_sessionControllerSessionInterface,
QStringLiteral("ReleaseDevice"));
message.setArguments(QVariantList({QVariant(major(st.st_rdev)), QVariant(minor(st.st_rdev))}));
m_bus.asyncCall(message);
}
QDBusMessage message = QDBusMessage::createMethodCall(m_sessionControllerService,
m_sessionPath,
m_sessionControllerSessionInterface,
QStringLiteral("ReleaseDevice"));
message.setArguments(QVariantList({QVariant(major(st.st_rdev)), QVariant(minor(st.st_rdev))}));
m_bus.asyncCall(message);
close(fd);
}
void LogindIntegration::pauseDevice(uint devMajor, uint devMinor, const QString &type)