yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

effects/overview: Implement the searchText backing property

Browse source 
It is used in QML code, just like in windowview (Present Windows)
effect, but developers forgot to copy the implementation in C++
backend.

BUG: 459202
FIXED-IN: 5.26
This commit is contained in:
ivan tkachenko 2022-09-17 02:58:22 +03:00
parent a3c6db3ee7
commit de6c0289a0
No known key found for this signature in database
GPG key ID: AF72731B7C654CB3
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/effects/overview/overvieweffect.cpp
View file

@ -236,6 +236,7 @@ void OverviewEffect::activate()
setPartialActivationFactor(0.0);
// This one should be the last.
m_searchText = QString();
setRunning(true);
}
@ -251,6 +252,7 @@ void OverviewEffect::partialActivate(qreal factor)
setGestureInProgress(true);
// This one should be the last.
m_searchText = QString();
setRunning(true);
}

5
src/effects/overview/overvieweffect.h
View file

@ -21,6 +21,7 @@ class OverviewEffect : public QuickSceneEffect
Q_PROPERTY(qreal partialActivationFactor READ partialActivationFactor NOTIFY partialActivationFactorChanged)
// More efficient from a property binding pov rather than binding to partialActivationFactor !== 0
Q_PROPERTY(bool gestureInProgress READ gestureInProgress NOTIFY gestureInProgressChanged)
Q_PROPERTY(QString searchText MEMBER m_searchText NOTIFY searchTextChanged)
public:
enum class Status {
@ -61,6 +62,7 @@ Q_SIGNALS:
void partialActivationFactorChanged();
void gestureInProgressChanged();
void ignoreMinimizedChanged();
void searchTextChanged();
public Q_SLOTS:
void activate();
@ -84,9 +86,10 @@ private:
QList<QKeySequence> m_toggleShortcut;
QList<ElectricBorder> m_borderActivate;
QList<ElectricBorder> m_touchBorderActivate;
QString m_searchText;
Status m_status = Status::Inactive;
qreal m_partialActivationFactor = 0;
bool m_blurBackground = false;
Status m_status = Status::Inactive;
int m_animationDuration = 400;
int m_layout = 1;
bool m_gestureInProgress = false;

6
src/effects/windowview/windowvieweffect.cpp
View file

@ -335,7 +335,7 @@ void WindowViewEffect::activate(const QStringList &windowIds)
}
if (!internalIds.isEmpty()) {
m_windowIds = internalIds;
m_searchText = "";
m_searchText = QString();
setRunning(true);
}
}
@ -353,7 +353,7 @@ void WindowViewEffect::activate()
setPartialActivationFactor(0);
// This one should be the last.
m_searchText = "";
m_searchText = QString();
setRunning(true);
}
@ -369,7 +369,7 @@ void WindowViewEffect::partialActivate(qreal factor)
setGestureInProgress(true);
// This one should be the last.
m_searchText = "";
m_searchText = QString();
setRunning(true);
}