yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix flickering in slide effect with multi screen

Browse source 
The slide effect translates all windows as we switch desktop. In a multi
screen setup we don't want windows to enter a different screen during
this animation.

The current code masks everything to the current output. This is broken
for any window that spans across screens even slightly. It will not be
visible during the transform then appear on top at the end.

The new algorithm is, for each screen in each window we crop the painted
area to the intersection of the screen and the screen's translated
position.
This commit is contained in:
David Edmundson 2022-07-04 16:02:22 +01:00
parent 298424d089
commit df1938b8af
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/effects/slide/slide.cpp
View file

@ -282,16 +282,20 @@ void SlideEffect::paintWindow(EffectWindow *w, int mask, QRegion region, WindowP
}
for (EffectScreen *screen : effects->screens()) {
QPoint translation = getDrawCoords(m_paintCtx.translation, screen);
QPoint translation;
if (isTranslated(w)) {
translation = getDrawCoords(m_paintCtx.translation, screen);
data += translation;
}
const QRect screenArea = screen->geometry();
const QRect croppedScreenArea = screenArea.translated(translation).intersected(screenArea);
effects->paintWindow(
w,
mask,
// Only paint the region that intersects the current screen and desktop.
region.intersected(effects->clientArea(ScreenArea, w)).intersected(effects->clientArea(ScreenArea, screen, effects->currentDesktop())),
region.intersected(croppedScreenArea),
data);
if (isTranslated(w)) {