From e0c3b4eed35b6db0f32cb6aefe6f5b4cfd96172d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20L=C3=BCbking?= Date: Tue, 5 May 2015 00:03:06 +0200 Subject: [PATCH] window aperture always needs to cancel even if the window is invisible fade out instead of NOOP or "restorage" BUG: 347174 REVIEW: 123636 --- .../package/contents/code/main.js | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/effects/windowaperture/package/contents/code/main.js b/effects/windowaperture/package/contents/code/main.js index f5fe4b0265..52396a6781 100644 --- a/effects/windowaperture/package/contents/code/main.js +++ b/effects/windowaperture/package/contents/code/main.js @@ -39,7 +39,26 @@ var badBadWindowsEffect = { break; // ignore invisible windows and such that do not have to be restored - if (!w.visible || (!showing && w.offToCornerId === undefined)) { + if (!w.visible) { + if (!(showing || w.offToCornerId === undefined)) { // we still need to stop this + cancel(w.offToCornerId); + delete w.offToCornerId; + effects.setElevatedWindow(w, false); + if (!w.dock) { + animate({ + window: w, + duration: badBadWindowsEffect.duration, + animations: [{ + type: Effect.Opacity, + from: 0.2, + to: 0.0 + }] + }); + } + } + continue; + } + if (!showing && w.offToCornerId === undefined) { continue; }