yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pass-by-value -> reference-to-count fixes

Browse source 
svn path=/trunk/KDE/kdebase/workspace/; revision=707741
This commit is contained in:
Arto Hytönen 2007-09-02 20:01:17 +00:00
parent 8f6cd4277f
commit e1c6433c8e
16 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bridge.cpp
View file

@ -80,7 +80,7 @@ bool Bridge::isSetShade() const
return c->shadeMode() != ShadeNone;
}
void Bridge::showWindowMenu( QPoint p )
void Bridge::showWindowMenu( const QPoint &p )
{
c->workspace()->showWindowMenu( p, c );
}

2
bridge.h
View file

@ -41,7 +41,7 @@ class Bridge : public KDecorationBridge
virtual QIcon icon() const;
virtual QString caption() const;
virtual void processMousePressEvent( QMouseEvent* );
virtual void showWindowMenu( QPoint );
virtual void showWindowMenu( const QPoint & );
virtual void showWindowMenu( const QRect & );
virtual void performWindowOperation( WindowOperation );
virtual void setMask( const QRegion&, int );

2
client.h
View file

@ -209,7 +209,7 @@ class Client
KShortcut shortcut() const;
void setShortcut( const QString& cut );
bool performMouseCommand( Options::MouseCommand, QPoint globalPos, bool handled = false );
bool performMouseCommand( Options::MouseCommand, const QPoint &globalPos, bool handled = false );
QRect adjustedClientArea( const QRect& desktop, const QRect& area ) const;

2
clients/b2/b2client.cpp
View file

@ -456,7 +456,7 @@ void B2Client::init()
titlebar->installEventFilter(this);
}
void B2Client::addButtons(const QString& s, const QString tips[],
void B2Client::addButtons(const QString& s, const QString &tips[],
B2Titlebar* tb, QBoxLayout* titleLayout)
{
if (s.length() <= 0)

2
clients/plastik/misc.cpp
View file

@ -67,7 +67,7 @@ QColor alphaBlendColors(const QColor &bgColor, const QColor &fgColor, const int
return result;
}
QImage recolorImage(QImage *img, QColor color) {
QImage recolorImage(QImage *img, const QColor &color) {
QImage destImg(img->width(),img->height(), QImage::Format_ARGB32);
for (int x = 0; x < img->width(); x++) {
for (int y = 0; y < img->height(); y++) {

2
effects/boxswitch.cpp
View file

@ -465,7 +465,7 @@ void BoxSwitchEffect::paintFrame()
#endif
}
void BoxSwitchEffect::paintHighlight( QRect area )
void BoxSwitchEffect::paintHighlight( const QRect &area )
{
QColor color = KColorScheme( KColorScheme::Selection ).background();
color.setAlphaF( 0.9 );

2
effects/magnifier.cpp
View file

@ -110,7 +110,7 @@ void MagnifierEffect::postPaintScreen()
effects->postPaintScreen();
}
QRect MagnifierEffect::magnifierArea( QPoint pos ) const
QRect MagnifierEffect::magnifierArea( const QPoint &pos ) const
{
return QRect( pos.x() - magnifier_size.width() / 2, pos.y() - magnifier_size.height() / 2,
magnifier_size.width(), magnifier_size.height());

4
kcmkwin/kwindecoration/buttons.cpp
View file

@ -261,7 +261,7 @@ int ButtonDropSiteItem::height()
return 20;
}
void ButtonDropSiteItem::draw(QPainter *p, const QPalette& cg, QRect r)
void ButtonDropSiteItem::draw(QPainter *p, const QPalette& cg, const QRect &r)
{
// p->fillRect(r, cg.base() );
if (m_button.supported)
@ -529,7 +529,7 @@ void ButtonDropSite::recalcItemGeometry()
}
}
ButtonDropSiteItem *ButtonDropSite::buttonAt(QPoint p) {
ButtonDropSiteItem *ButtonDropSite::buttonAt(const QPoint &p) {
// try to find the item in the left button list
for (ButtonList::const_iterator it = buttonsLeft.begin(); it != buttonsLeft.end(); ++it) {
if ( (*it)->rect.contains(p) ) {

2
kcmkwin/kwindecoration/preview.cpp
View file

@ -342,7 +342,7 @@ void KDecorationPreviewBridge::showWindowMenu( const QRect &)
{
}
void KDecorationPreviewBridge::showWindowMenu( QPoint )
void KDecorationPreviewBridge::showWindowMenu( const QPoint & )
{
}

2
lib/kdecoration_p.h
View file

@ -81,7 +81,7 @@ class KDecorationBridge : public KDecorationDefines
virtual QString caption() const = 0;
virtual void processMousePressEvent( QMouseEvent* ) = 0;
virtual void showWindowMenu( const QRect &) = 0;
virtual void showWindowMenu( QPoint ) = 0;
virtual void showWindowMenu( const QPoint & ) = 0;
virtual void performWindowOperation( WindowOperation ) = 0;
virtual void setMask( const QRegion&, int ) = 0;
virtual bool isPreview() const = 0;

2
popupinfo.cpp
View file

@ -131,7 +131,7 @@ void PopupInfo::reconfigure()
m_delayTime = cg.readEntry("PopupHideDelay", 350 );
}
void PopupInfo::showInfo(QString infoString)
void PopupInfo::showInfo(const QString &infoString)
{
if (m_show)
{

2
popupinfo.h
View file

@ -28,7 +28,7 @@ class PopupInfo : public QWidget
void reset();
void hide();
void showInfo(QString infoString);
void showInfo(const QString &infoString);
void reconfigure();

4
tools/decobenchmark/preview.cpp
View file

@ -291,11 +291,11 @@ void KDecorationPreviewBridge::processMousePressEvent( QMouseEvent* )
{
}
void KDecorationPreviewBridge::showWindowMenu( const QRect &)
void KDecorationPreviewBridge::showWindowMenu( const QRect & )
{
}
void KDecorationPreviewBridge::showWindowMenu( QPoint )
void KDecorationPreviewBridge::showWindowMenu( const QPoint & )
{
}

2
useractions.cpp
View file

@ -534,7 +534,7 @@ void Workspace::performWindowOperation( Client* c, Options::WindowOperation op )
/*!
Performs a mouse command on this client (see options.h)
*/
bool Client::performMouseCommand( Options::MouseCommand command, QPoint globalPos, bool handled )
bool Client::performMouseCommand( Options::MouseCommand command, const QPoint &globalPos, bool handled )
{
bool replay = false;
switch (command)

6
workspace.cpp
View file

@ -1630,7 +1630,7 @@ void Workspace::checkActiveScreen( const Client* c )
// called e.g. when a user clicks on a window, set active screen to be the screen
// where the click occurred
void Workspace::setActiveScreenMouse( QPoint mousepos )
void Workspace::setActiveScreenMouse( const QPoint &mousepos )
{
if( !options->xineramaEnabled )
return;
@ -1644,7 +1644,7 @@ QRect Workspace::screenGeometry( int screen ) const
return qApp->desktop()->screenGeometry( screen );
}
int Workspace::screenNumber( QPoint pos ) const
int Workspace::screenNumber( const QPoint &pos ) const
{
if( !options->xineramaEnabled )
return 0;
@ -1855,7 +1855,7 @@ WId Workspace::getMouseEmulationWindow()
/*!
Sends a faked mouse event to the specified window. Returns the new button state.
*/
unsigned int Workspace::sendFakedMouseEvent( QPoint pos, WId w, MouseEmulation type, int button, unsigned int state )
unsigned int Workspace::sendFakedMouseEvent( const QPoint &pos, WId w, MouseEmulation type, int button, unsigned int state )
{
if ( !w )
return state;

6
workspace.h
View file

@ -153,9 +153,9 @@ class Workspace : public QObject, public KDecorationDefines
int activeScreen() const;
int numScreens() const;
void checkActiveScreen( const Client* c );
void setActiveScreenMouse( QPoint mousepos );
void setActiveScreenMouse( const QPoint &mousepos );
QRect screenGeometry( int screen ) const;
int screenNumber( QPoint pos ) const;
int screenNumber( const QPoint &pos ) const;
QWidget* desktopWidget();
// for TabBox
@ -529,7 +529,7 @@ class Workspace : public QObject, public KDecorationDefines
// mouse emulation
WId getMouseEmulationWindow();
enum MouseEmulation { EmuPress, EmuRelease, EmuMove };
unsigned int sendFakedMouseEvent( QPoint pos, WId win, MouseEmulation type, int button, unsigned int state ); // returns the new state
unsigned int sendFakedMouseEvent( const QPoint &pos, WId win, MouseEmulation type, int button, unsigned int state ); // returns the new state
void tabBoxKeyPress( int key );
void tabBoxKeyRelease( const XKeyEvent& ev );