yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

autotests: Make testSlidingPopups quicker

Browse source 
The test waits longer than needed to determine whether effects stopped
playing animations

Before

    Executed in   22.41 secs      fish           external
       usr time  997.42 millis  722.00 micros  996.70 millis
       sys time  744.81 millis   79.00 micros  744.73 millis

After

    Executed in    9.71 secs      fish           external
       usr time  894.42 millis    1.03 millis  893.38 millis
       sys time  689.80 millis    0.11 millis  689.69 millis
This commit is contained in:
Vlad Zahorodnii 2023-01-11 22:50:39 +02:00
parent 3a6986b855
commit e689ab5ebd
1 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
autotests/integration/effects/slidingpopups_test.cpp
View file

@ -156,9 +156,6 @@ void SlidingPopupsTest::testWithOtherEffect()
QVERIFY(!slidingPoupus->isActive());
QVERIFY(!otherEffect->isActive());
// give the compositor some time to render
QTest::qWait(50);
QSignalSpy windowAddedSpy(effects, &EffectsHandler::windowAdded);
// create an xcb window
@ -209,8 +206,7 @@ void SlidingPopupsTest::testWithOtherEffect()
// wait till effect ends
QTRY_VERIFY(!slidingPoupus->isActive());
QTest::qWait(300);
QVERIFY(!otherEffect->isActive());
QTRY_VERIFY(!otherEffect->isActive());
// and destroy the window again
xcb_unmap_window(c.get(), windowId);
@ -228,8 +224,7 @@ void SlidingPopupsTest::testWithOtherEffect()
QVERIFY(windowDeletedSpy.wait());
QCOMPARE(windowDeletedSpy.count(), 1);
QTRY_VERIFY(!slidingPoupus->isActive());
QTest::qWait(300);
QVERIFY(!slidingPoupus->isActive());
QVERIFY(!otherEffect->isActive());
xcb_destroy_window(c.get(), windowId);
c.reset();
@ -322,8 +317,7 @@ void SlidingPopupsTest::testWithOtherEffectWayland()
// wait till effect ends
QTRY_VERIFY(!slidingPoupus->isActive());
QTest::qWait(300);
QVERIFY(!otherEffect->isActive());
QTRY_VERIFY(!otherEffect->isActive());
// and destroy the window again
shellSurface.reset();
@ -341,8 +335,7 @@ void SlidingPopupsTest::testWithOtherEffectWayland()
QVERIFY(windowDeletedSpy.wait());
QCOMPARE(windowDeletedSpy.count(), 1);
QTRY_VERIFY(!slidingPoupus->isActive());
QTest::qWait(300);
QVERIFY(!slidingPoupus->isActive());
QVERIFY(!otherEffect->isActive());
}