From e9e936b6c1bde338fb51ea3ada0897ad70055c44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Mon, 12 Sep 2016 10:42:36 +0200 Subject: [PATCH] [kwinglutils] Skip ShaderManager::selfTest for NVIDIA Quadro hardware Summary: The self test fails with NVDIDA 370.23 or newer on Quadro hardware. Most likely there is a bug in our code as the same things work later on. But without the hardware we are not able to reproduce and investigate properly. Given that all we currently can do is to skip the self test. We encourage users to investigate this properly and to help us to identify the root issue, so that we can fix it. CCBUG: 367766 Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2744 --- libkwineffects/kwinglutils.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libkwineffects/kwinglutils.cpp b/libkwineffects/kwinglutils.cpp index bd84db725f..4893013d4d 100644 --- a/libkwineffects/kwinglutils.cpp +++ b/libkwineffects/kwinglutils.cpp @@ -706,6 +706,10 @@ bool ShaderManager::selfTest() qCWarning(LIBKWINGLUTILS) << "Framebuffer objects not supported - skipping shader tests"; return true; } + if (GLPlatform::instance()->isNvidia() && GLPlatform::instance()->glRendererString().contains("Quadro")) { + qCWarning(LIBKWINGLUTILS) << "Skipping self test as it is reported to return false positive results on Quadro hardware"; + return true; + } // Create the source texture QImage image(2, 2, QImage::Format_ARGB32_Premultiplied);