yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add safety guards in FocusChain::move{After,Before}Window()

Browse source 
If the `window` is the same as the `reference`, the `window` will be
inserted at index "-1", which is wrong.
This commit is contained in:
Vlad Zahorodnii 2024-08-21 15:59:05 +03:00
parent 22e10f6efb
commit ef9d3a1cd0
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/focuschain.cpp
View file

@ -139,6 +139,9 @@ void FocusChain::moveAfterWindow(Window *window, Window *reference)
if (!window->wantsTabFocus()) { if (!window->wantsTabFocus()) {
return; return;
} }
if (reference == window) {
return;
}
for (auto it = m_desktopFocusChains.begin(); for (auto it = m_desktopFocusChains.begin();
it != m_desktopFocusChains.end(); it != m_desktopFocusChains.end();
@ -159,6 +162,9 @@ void FocusChain::moveBeforeWindow(Window *window, Window *reference)
if (!window->wantsTabFocus()) { if (!window->wantsTabFocus()) {
return; return;
} }
if (reference == window) {
return;
}
for (auto it = m_desktopFocusChains.begin(); for (auto it = m_desktopFocusChains.begin();
it != m_desktopFocusChains.end(); it != m_desktopFocusChains.end();