yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

shortcut rendering textures for empty an rect

Browse source 
it makes no sense and there's a good chance
that in this case m_vbo is still nullptr and
it will not be created since d->m_cachedSize
will be an empty size as well
-> nullptr access -> crash

BUG: 337090
FIXED-IN: 5.2
This commit is contained in:
Thomas Lübking 2015-01-08 00:25:46 +01:00
parent 8de4e4d84e
commit f61d3ade84
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libkwineffects/kwingltexture.cpp
View file

@ -447,6 +447,8 @@ void GLTexture::unbind()
void GLTexture::render(QRegion region, const QRect& rect, bool hardwareClipping) void GLTexture::render(QRegion region, const QRect& rect, bool hardwareClipping)
{ {
Q_D(GLTexture); Q_D(GLTexture);
if (rect.isEmpty())
return; // nothing to paint and m_vbo is likely nullptr and d->m_cachedSize empty as well, #337090
if (rect.size() != d->m_cachedSize) { if (rect.size() != d->m_cachedSize) {
d->m_cachedSize = rect.size(); d->m_cachedSize = rect.size();
QRect r(rect); QRect r(rect);