Initialize variables in ctor
The not initialized boolean value seemed to have evaluated to true and causing the animation to stop and therefore the darkening not to apply. Giving a default value to the EffectWindow pointer doesn't hurt either. Patch does not apply to 4.6 branch, because of that only in master. BUG: 264552 FIXED-IN: 4.7.0
This commit is contained in:
parent
db14f3d798
commit
f6233828fe
1 changed files with 4 additions and 0 deletions
|
@ -29,6 +29,8 @@ DashboardEffect::DashboardEffect()
|
|||
: transformWindow(false)
|
||||
, activateAnimation(false)
|
||||
, deactivateAnimation(false)
|
||||
, retransformWindow(false)
|
||||
, window(NULL)
|
||||
{
|
||||
// propagate that the effect is loaded
|
||||
propagate();
|
||||
|
@ -114,6 +116,7 @@ void DashboardEffect::postPaintScreen()
|
|||
retransformWindow = false;
|
||||
transformWindow = false;
|
||||
effects->addRepaintFull();
|
||||
window = NULL;
|
||||
effects->setActiveFullScreenEffect(0);
|
||||
}
|
||||
|
||||
|
@ -128,6 +131,7 @@ void DashboardEffect::postPaintScreen()
|
|||
if (timeline.currentValue() == 0.0) {
|
||||
deactivateAnimation = false;
|
||||
transformWindow = false;
|
||||
window = NULL;
|
||||
effects->setActiveFullScreenEffect(0);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue