yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Initialize variables in ctor

Browse source 
The not initialized boolean value seemed to have evaluated to true
and causing the animation to stop and therefore the darkening not
to apply.

Giving a default value to the EffectWindow pointer doesn't hurt either.

Patch does not apply to 4.6 branch, because of that only in master.
BUG: 264552
FIXED-IN: 4.7.0
This commit is contained in:
Martin Gräßlin 2011-03-17 20:02:52 +01:00
parent db14f3d798
commit f6233828fe
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
effects/dashboard/dashboard.cpp
View file

@ -29,6 +29,8 @@ DashboardEffect::DashboardEffect()
: transformWindow(false) : transformWindow(false)
, activateAnimation(false) , activateAnimation(false)
, deactivateAnimation(false) , deactivateAnimation(false)
, retransformWindow(false)
, window(NULL)
{ {
// propagate that the effect is loaded // propagate that the effect is loaded
propagate(); propagate();
@ -114,6 +116,7 @@ void DashboardEffect::postPaintScreen()
retransformWindow = false; retransformWindow = false;
transformWindow = false; transformWindow = false;
effects->addRepaintFull(); effects->addRepaintFull();
window = NULL;
effects->setActiveFullScreenEffect(0); effects->setActiveFullScreenEffect(0);
} }
@ -128,6 +131,7 @@ void DashboardEffect::postPaintScreen()
if (timeline.currentValue() == 0.0) { if (timeline.currentValue() == 0.0) {
deactivateAnimation = false; deactivateAnimation = false;
transformWindow = false; transformWindow = false;
window = NULL;
effects->setActiveFullScreenEffect(0); effects->setActiveFullScreenEffect(0);
} }