yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix transient placement for decorated parents

Browse source 
Need to add client pos to the transient's position. The offset is
relative to the parent surface, but the client doesn't know about the
size of the decoration, thus KWin needs to add it.
This commit is contained in:
Martin Gräßlin 2016-03-03 13:36:01 +01:00
parent f2873dcd36
commit fa774230f3
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
autotests/wayland/transient_placement.cpp
View file

@ -297,7 +297,6 @@ void TransientPlacementTest::testDecorationPosition()
QVERIFY(transient->hasTransientPlacementHint()); QVERIFY(transient->hasTransientPlacementHint());
QFETCH(QRect, expectedGeometry); QFETCH(QRect, expectedGeometry);
expectedGeometry.translate(parent->clientPos()); expectedGeometry.translate(parent->clientPos());
QEXPECT_FAIL("", "Fix me", Continue);
QCOMPARE(transient->geometry(), expectedGeometry); QCOMPARE(transient->geometry(), expectedGeometry);
} }

2
placement.cpp
View file

@ -497,7 +497,7 @@ void Placement::placeOnScreenDisplay(AbstractClient* c, QRect& area)
void Placement::placeTransient(AbstractClient *c) void Placement::placeTransient(AbstractClient *c)
{ {
// TODO: apply sanity checks? // TODO: apply sanity checks?
c->move(c->transientFor()->pos() + c->transientPlacementHint()); c->move(c->transientFor()->pos() + c->transientFor()->clientPos() + c->transientPlacementHint());
} }
void Placement::placeDialog(AbstractClient* c, QRect& area, Policy nextPlacement) void Placement::placeDialog(AbstractClient* c, QRect& area, Policy nextPlacement)