plugins/overview: Allow switching between modes using shortcuts while already active

Overview and Grid modes have shortcuts assigned to them. While they
provide a way to toggle the overview effect between on and off state, in
other words overview <-> off or grid <-> off, it's not possible to move
between the modes by pressing those shortcuts, e.g. off -> overview ->
grid -> overview -> grid -> ... -> off.

The culprit seems to be that EffectTogglableState has two "inactive"
states - Inactive and Stopped. It's counter-intuitive and needs a further
cleanup.

To make switching between overview modes work, this change makes
EffectTogglableState::toggle() toggle the state based on the Active state.
There's only one active state.

CCBUG: 481335
This commit is contained in:
Vlad Zahorodnii 2024-02-15 15:08:00 +02:00
parent 0991cded05
commit fc92544cb3

View file

@ -111,7 +111,7 @@ void EffectTogglableState::partialDeactivate(qreal factor)
void EffectTogglableState::toggle()
{
if (m_status == Status::Inactive) {
if (m_status != Status::Active) {
activate();
Q_EMIT activated();
} else {