From fe5f7fb2f6e06f1a11afbdcf36b3cc4e45534550 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Thu, 20 Mar 2014 09:17:50 +0100 Subject: [PATCH] [kwin] Drop Predicate based Workspace::forEachClient Migrates the last usage to the lambda based variant. --- workspace.cpp | 6 +++--- workspace.h | 18 ------------------ 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/workspace.cpp b/workspace.cpp index 2347edcb51..50df1d6cd2 100644 --- a/workspace.cpp +++ b/workspace.cpp @@ -772,7 +772,6 @@ bool Workspace::waitForCompositingSetup() /** * Reread settings */ -KWIN_PROCEDURE(CheckBorderSizesProcedure, Client, cl->checkBorderSizes(true)); void Workspace::slotReconfigure() { @@ -794,9 +793,10 @@ void Workspace::slotReconfigure() deco->destroyPreviousPlugin(); connect(deco->factory(), &KDecorationFactory::recreateDecorations, deco, &DecorationPlugin::recreateDecorations); } else { - forEachClient(CheckBorderSizesProcedure()); - foreach (Client * c, clients) + foreach (Client * c, clients) { + c->checkBorderSizes(true); c->triggerDecorationRepaint(); + } } RuleBook::self()->load(); diff --git a/workspace.h b/workspace.h index dce815aeec..f3ef7b9e73 100644 --- a/workspace.h +++ b/workspace.h @@ -73,8 +73,6 @@ public: bool hasClient(const Client*); template Client* findClient(T predicate) const; - template void forEachClient(T1 procedure, T2 predicate); - template void forEachClient(T procedure); void forEachClient(std::function func); Unmanaged *findUnmanaged(std::function func) const; /** @@ -671,16 +669,6 @@ inline Client* Workspace::findClient(T predicate) const return NULL; } -template< typename T1, typename T2 > -inline void Workspace::forEachClient(T1 procedure, T2 predicate) -{ - for (ClientList::ConstIterator it = clients.constBegin(); it != clients.constEnd(); ++it) - if (predicate(const_cast(*it))) - procedure(*it); - for (ClientList::ConstIterator it = desktops.constBegin(); it != desktops.constEnd(); ++it) - if (predicate(const_cast(*it))) - procedure(*it); -} inline void Workspace::forEachClient(std::function< void (Client*) > func) @@ -689,12 +677,6 @@ void Workspace::forEachClient(std::function< void (Client*) > func) std::for_each(desktops.constBegin(), desktops.constEnd(), func); } -template< typename T > -inline void Workspace::forEachClient(T procedure) -{ - return forEachClient(procedure, TruePredicate()); -} - inline void Workspace::forEachUnmanaged(std::function< void (Unmanaged*) > func) {