yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Emphasize minimization in MinimizeAll script

Browse source 
Summary:
MinimizeAll should work as follows:

> As long as there's something to minimize, do that.
> Otherwise unminimize only the windows we minimized
> on last invocation.

Quote above is from Comment 11 by Thomas Lübking of BUG: 356161.

But current code does not fulfill these duties. Try next case: run minimizeall on some windows, then click on one of windows, then run minimizeall again. All windows would be unminimized!

I have tried to make small changes to original code of main.js, but i can't because i don't understand it.

Thats why i wrote my own version. Then i changed my version to version of zzag, because his code is more simple. I have tested both versions.

BUG: 356161

Reviewers: colomar, #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: romangg, zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24044
This commit is contained in:
Anton Smerkov 2019-09-18 18:09:42 +03:00 committed by Vlad Zahorodnii
parent 2ad37c449f
commit fec0ab818d
1 changed files with 26 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
scripts/minimizeall/contents/code/main.js
View file

@ -26,28 +26,38 @@ function isRelevant(client) {
(!client.activities.length || client.activities.indexOf(workspace.currentActivity.toString()) > -1);
}
var minimizeAllWindows = function() {
function minimizeAllWindows() {
var allClients = workspace.clientList();
var clients = [];
var relevantClients = [];
var minimize = false;
for (var i = 0; i < allClients.length; ++i) {
if (isRelevant(allClients[i])) {
clients.push(allClients[i]);
if (!allClients[i].minimized && allClients[i].minimizedForMinimizeAll !== true) {
minimize = true;
}
}
}
for (var i = 0; i < clients.length; ++i) {
if ((minimize == clients[i].minimized) || // no change required at all
(!minimize && clients[i].minimizedForMinimizeAll !== true)) { // unminimize, but not this one
delete clients[i].minimizedForMinimizeAll;
if (!isRelevant(allClients[i])) {
continue;
}
clients[i].minimized = minimize;
clients[i].minimizedForMinimizeAll = minimize;
if (!allClients[i].minimized) {
minimize = true;
}
relevantClients.push(allClients[i]);
}
for (var i = 0; i < relevantClients.length; ++i) {
var wasMinimizedByScript = relevantClients[i].minimizedByScript;
delete relevantClients[i].minimizedByScript;
if (minimize) {
if (relevantClients[i].minimized) {
continue;
}
relevantClients[i].minimized = true;
relevantClients[i].minimizedByScript = true;
} else {
if (!wasMinimizedByScript) {
continue;
}
relevantClients[i].minimized = false;
}
}
clients = [];
}
function init() {