From fff32f64e696357c4983d42624f2128b15eb7ef4 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Fri, 27 Aug 2021 10:16:16 +0300 Subject: [PATCH] effects: Drop EffectsHandler::screenGeometryChanged() It's confusing to have two signals (virtualScreenGeometryChanged() and screenGeometryChanged()) that indicate the same thing. --- src/effects.cpp | 3 --- src/libkwineffects/kwineffects.h | 9 --------- 2 files changed, 12 deletions(-) diff --git a/src/effects.cpp b/src/effects.cpp index abdc85e6e8..0ba21ee354 100644 --- a/src/effects.cpp +++ b/src/effects.cpp @@ -191,9 +191,6 @@ EffectsHandlerImpl::EffectsHandlerImpl(Compositor *compositor, Scene *scene) connect(Screens::self(), &Screens::countChanged, this, &EffectsHandler::numberScreensChanged); connect(Screens::self(), &Screens::sizeChanged, this, &EffectsHandler::virtualScreenSizeChanged); connect(Screens::self(), &Screens::geometryChanged, this, &EffectsHandler::virtualScreenGeometryChanged); - connect(Screens::self(), &Screens::geometryChanged, this, [this]() { - Q_EMIT screenGeometryChanged(Screens::self()->size()); - }); #ifdef KWIN_BUILD_ACTIVITIES if (Activities *activities = Activities::self()) { connect(activities, &Activities::added, this, &EffectsHandler::activityAdded); diff --git a/src/libkwineffects/kwineffects.h b/src/libkwineffects/kwineffects.h index d2cfa875cd..14225b4a09 100644 --- a/src/libkwineffects/kwineffects.h +++ b/src/libkwineffects/kwineffects.h @@ -1642,15 +1642,6 @@ Q_SIGNALS: */ void propertyNotify(KWin::EffectWindow* w, long atom); - /** - * Signal emitted after the screen geometry changed (e.g. add of a monitor). - * Effects using displayWidth()/displayHeight() to cache information should - * react on this signal and update the caches. - * @param size The new screen size - * @since 4.8 - */ - void screenGeometryChanged(const QSize &size); - /** * This signal is emitted when the global * activity is changed