Commit graph

38 commits

Author SHA1 Message Date
Méven Car
5498ed9565 KCM/Kwinoptions: Port focus tab to KConfigXT
Summary:
* remove singleton of KWinOptionsSettings

Depends on D27477

Test Plan:
* No functional change
* default / reset button work as expected.

Reviewers: ervin, bport, hchain, crossi, #kwin, zzag

Reviewed By: ervin, #kwin, zzag

Subscribers: zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27934
2020-03-30 10:13:16 +02:00
Méven Car
d571457bbe KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT
Summary: Depends on D27463

Reviewers: crossi, bport, ervin, #kwin, zzag

Reviewed By: ervin, #kwin, zzag

Subscribers: zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27477
2020-03-19 12:40:01 +01:00
Vlad Zagorodniy
8af2fa73dc Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.

The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.

Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.

A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!

The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.

The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.

Test Plan: Compiles.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, apol, romangg, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 20:03:22 +03:00
Aleix Pol
c72e519d9c Remove KDE/ prefix in include directories
It's unneeded and deprecated since KF5.
2014-03-17 16:24:10 +01:00
Bhushan Shah
be8920d76c kwin is now free of KDE4Support
REVIEW: 115760
2014-02-16 00:31:01 +05:30
Martin Gräßlin
4413859084 [kwinoptions] Drop componentData() 2013-09-30 07:29:38 +02:00
Martin Gräßlin
d70ad3b275 [kwinoptions] slots -> Q_SLOTS 2013-09-30 07:26:46 +02:00
Martin Gräßlin
60c42b7a34 s/KLocale/KLocalizedString/g
Many headers included KLocale to use i18n and co. But those methods are
defined in KLocalizedString and not in KLocale.

With KF5 klocale.h does no longer include KLocalizedString causing lots
of compile errors.
2013-03-07 13:59:15 +01:00
Martin Gräßlin
7c2a0f2188 Introduce ui-file for inactive window mouse actions in KWin configuration
Thanks to Alexander Jones for creating the ui file.
2012-10-04 17:26:34 +02:00
Martin Gräßlin
142fa54b2b Introduce ui-file for titlebar mouse actions in KWin's configuration
Thanks to Alexander Jones for creating the ui file.
2012-10-04 17:26:34 +02:00
Martin Gräßlin
0a7e48f7aa KWin uses kdelibs coding style. 2011-01-31 20:07:03 +01:00
Christoph Feck
12bba19ee1 Fix Apply button getting disabled when changing tabs
BUG: 163817

svn path=/trunk/KDE/kdebase/workspace/; revision=1062180
2009-12-14 03:18:43 +00:00
Lucas Murray
424d358fd2 Less Krazy warnings please.
svn path=/trunk/KDE/kdebase/workspace/; revision=1042583
2009-10-30 08:10:35 +00:00
A. Lynn Spehr
2893eac8fe Added setting to control whether scrolling on a background window focuses it.
Patch by Alex Danila. Approved by lmurray. 
BUG: 164261

svn path=/trunk/KDE/kdebase/workspace/; revision=964140
2009-05-06 06:38:54 +00:00
Lukas Kropatschek
8eeddd6c55 some krazy include issue fixes
svn path=/trunk/KDE/kdebase/workspace/; revision=814568
2008-05-30 17:47:24 +00:00
Pino Toscano
258f144577 fix some grid layouts and port them away from q3 classes
svn path=/trunk/KDE/kdebase/workspace/; revision=707349
2007-09-01 15:58:40 +00:00
Luboš Luňák
f52b8e48cd branches/work/kwin_composite becomes new trunk kwin.
svn path=/trunk/KDE/kdebase/workspace/; revision=659202
2007-04-29 17:35:43 +00:00
Luboš Luňák
2b7e1f4993 Remove kwin, kwin_composite will become new trunk kwin, missing merges
from trunk will be merged in.


svn path=/trunk/KDE/kdebase/workspace/; revision=659200
2007-04-29 17:34:49 +00:00
Laurent Montel
2178c6dc31 Include fix
svn path=/trunk/KDE/kdebase/workspace/; revision=656565
2007-04-21 18:28:47 +00:00
Matthias Kretz
3003c4ecf8 merge the kinstance-redesign branch back to trunk.
svn path=/trunk/KDE/kdebase/workspace/; revision=628276
2007-01-29 17:14:20 +00:00
Laurent Montel
7f7ce52d78 #include <q...h> -> #include <Q...>
svn path=/trunk/KDE/kdebase/workspace/; revision=539617
2006-05-11 08:04:23 +00:00
Laurent Montel
e138e585dc deprecated--
svn path=/trunk/KDE/kdebase/workspace/; revision=516301
2006-03-06 15:51:12 +00:00
Script Kiddy
19e65c92dc Fix FSF address
(mainly s/Steet/Street/;s/Cambridge/Boston/ )

svn path=/trunk/KDE/kdebase/workspace/; revision=490222
2005-12-21 06:45:09 +00:00
Stephan Kulow
7fff57dbcf ported the KCModules
svn path=/trunk/KDE/kdebase/workspace/; revision=473152
2005-10-22 19:12:01 +00:00
Dirk Mueller
e20f2bd6b2 SVN_SILENT: fix typo
svn path=/trunk/KDE/kdebase/kdm/; revision=467416
2005-10-05 08:44:32 +00:00
Laurent Montel
a166c8e3d4 QToolTip::add -> setToolTip
svn path=/trunk/KDE/kdebase/workspace/; revision=462520
2005-09-21 09:14:36 +00:00
Dirk Mueller
da212229af SVN_SILENT update FSF address
svn path=/trunk/KDE/kdebase/kwin/; revision=433335
2005-07-10 13:44:16 +00:00
Luboš Luňák
fc90a04635 Make it possible to do all kinds of strange things when mousewheeling
the titlebar or Alt+mousewheeling the window.
FEATURE:44318
FEATURE:66519
FEATURE:76188


svn path=/trunk/KDE/kdebase/kwin/; revision=410058
2005-05-06 15:20:49 +00:00
Luboš Luňák
68cde4a2ef Split the actions tab into two.
svn path=/trunk/KDE/kdebase/kwin/; revision=409955
2005-05-06 08:47:48 +00:00
Luboš Luňák
43f9553004 Adding yet another option, this time for what happens when clicking
the maximize button.

svn path=/trunk/kdebase/kwin/; revision=342186
2004-08-28 15:27:22 +00:00
Matthias Kretz
e3fd05e402 Remove calls to KCModule::setChanged so that I may remove that method before
the 3.2 release again.

svn path=/trunk/kdebase/kcontrol/; revision=265646
2003-11-08 23:43:53 +00:00
Luboš Luňák
d4cec4d60a Merging back kcm modules from kwin_iii to HEAD.
svn path=/trunk/kdebase/kwin/; revision=251618
2003-09-16 19:34:03 +00:00
Waldo Bastian
20932da805 CVS_SILENT
Updated address of FSF

svn path=/trunk/kdebase/ksysguard/; revision=212185
2003-03-07 22:11:39 +00:00
Waldo Bastian
2877125bb1 * Don't delete the config twice
* Keep the individual panels working.

svn path=/trunk/kdebase/kwin/; revision=178335
2002-09-16 20:54:23 +00:00
Luboš Luňák
b9debb8836 Oops, I forgot this one.
svn path=/trunk/kdebase/kwin/; revision=173371
2002-08-23 08:20:05 +00:00
Charles Samuels
6ba1276a75 the Windows Branch:
TODO:
	Icons, again.  Fix the problem of the "Advanced" tab.

svn path=/trunk/kdebase/kwin/; revision=165323
2002-07-07 00:38:19 +00:00
Simon Hausmann
d8d4f8bfa1 - pass the right instance to KCModule
- don't leak a KConfig object
- don't use a KCModule widget for each tab

svn path=/trunk/kdebase/kwin/; revision=133741
2002-01-25 10:02:11 +00:00
Karol Szwed
4fdde98724 Completing move of kwm and kwindecoration to kwin/kcmkwin as discussed
on the kwin mailing list.

- kwm has been renamed and moved to kwin/kcmkwin/kwinoptions.
- kwindecoration has been moved to  kwin/kcmkwin/kwindecoration.

svn path=/trunk/kdebase/kcontrol/; revision=131923
2002-01-16 12:26:03 +00:00