Commit graph

67 commits

Author SHA1 Message Date
Luboš Luňák
78b84121d7 Make group transients transient only for windows in the same group that
were mapped before it, not for new ones. This greatly minimizes
the posibility of loops and avoids all those problems in #67914
causes by so many dialogs not having their parent specified.

svn path=/trunk/kdebase/kwin/; revision=272281
2003-12-10 11:27:20 +00:00
Luboš Luňák
74741dee7e The change done in r2.9 made the test for two windows belonging to the same
app too restrictive, now it fails e.g. with xmms equivalizer and playlist.

svn path=/trunk/kdebase/kwin/; revision=270836
2003-12-02 18:11:24 +00:00
Luboš Luňák
8f181d8b52 checkGroupTransients() uses hasTransient() to break loops, so it must detect them,
fixes #69094

svn path=/trunk/kdebase/kwin/; revision=269892
2003-11-27 14:37:55 +00:00
Luboš Luňák
fe0ab6d200 Avoid making windows transient to themselves.
Don't worry about creating loops with group transients, checkGroupTransients()
will check for them and has better chances to break them correctly.

svn path=/trunk/kdebase/kwin/; revision=269292
2003-11-24 14:24:04 +00:00
Luboš Luňák
225f12f1d3 Attempt number 3251 at finally fixing #67914. This window grouping
will have to be reworked for 3.3.

svn path=/trunk/kdebase/kwin/; revision=268607
2003-11-21 14:05:20 +00:00
Luboš Luňák
b2b60d647f Change Client::checkGroupTransients() to really do what it's supposed to do,
including indirect transiency.
Should finally fix #67914 and all its dupes.

svn path=/trunk/kdebase/kwin/; revision=268157
2003-11-19 12:10:48 +00:00
Luboš Luňák
0fb3d41e26 If two windows are the same, they belong to the same application.
Second part for #68553.

svn path=/trunk/kdebase/kwin/; revision=268142
2003-11-19 10:44:36 +00:00
Luboš Luňák
e7c55a0c89 Ouch ... thanks to Ossi for noticing.
svn path=/trunk/kdebase/kwin/; revision=266865
2003-11-13 18:27:31 +00:00
Luboš Luňák
33e9753f6b If windows don't have _NET_WM_PID set, don't rely on pid1==pid2 when
finding out if they're the same app.
CCMAIL: 68087-done@bugs.kde.org

svn path=/trunk/kdebase/kwin/; revision=266853
2003-11-13 17:19:49 +00:00
Luboš Luňák
6c3176c74c Avoid transient loops with group transients.
CCMAIL: 67914-done@bugs.kde.org

svn path=/trunk/kdebase/kwin/; revision=266527
2003-11-12 09:02:37 +00:00
Luboš Luňák
70645a691a When a new window appears in a group, make sure group transients are
transient for it.

svn path=/trunk/kdebase/kwin/; revision=266151
2003-11-10 18:08:59 +00:00
Luboš Luňák
3a23e0775d Fix focus stealing prevention for XV, just in case Coolo sometimes decides
to run it again.

svn path=/trunk/kdebase/kwin/; revision=261527
2003-10-24 09:00:40 +00:00
Luboš Luňák
80376961fc More debug output.
svn path=/trunk/kdebase/kwin/; revision=254812
2003-09-29 11:20:12 +00:00
Luboš Luňák
8a11c2ff74 Fix transiency loop with WM_TRANSIENT_FOR poiting to itself (e.g. with
ssh-askpass), and put the Only True assert() (TM) back.

svn path=/trunk/kdebase/kwin/; revision=253636
2003-09-24 16:56:49 +00:00
David Faure
d9066553de KWin crashing on every KDE startup isn't fun.... Some info:
kdeinit: kwin -session 110a000002000106431633100000023760005_1064355176_942460: /mnt/devel/kde/kdecvs/kdebase/kwin/group.cpp:537: void KWinInternal::Cli
ent::addTransient(KWinInternal::Client*): Assertion `cl != this' failed.
(the debug output before that includes a backtrace to _ZN12KWinInternal9Workspace21allowClientActivationEPKNS_6ClientEmbb

#7  0x4141c745 in __assert_fail ()
#8  0x4157fdea in KWinInternal::Client::addTransient(KWinInternal::Client*) ()
#9  0x4157f211 in KWinInternal::Client::setTransient(unsigned long) ()
#10 0x4157feda in KWinInternal::Client::checkTransient(unsigned long) ()
#11 0x4157e7dd in KWinInternal::Workspace::checkTransients(unsigned long) ()
#12 0x415538f2 in KWinInternal::Workspace::addClient(KWinInternal::Client*, KWinInternal::allowed_t) ()
#13 0x415536e4 in KWinInternal::Workspace::createClient(unsigned long, bool) ()
#14 0x415721f5 in KWinInternal::Workspace::workspaceEvent(_XEvent*) ()

svn path=/trunk/kdebase/kwin/; revision=253509
2003-09-24 08:23:39 +00:00
Luboš Luňák
1e61c406f9 Temporary fix for #64516.
svn path=/trunk/kdebase/kwin/; revision=252394
2003-09-19 14:53:39 +00:00
Luboš Luňák
10f405c73d Merging kwin core from kwin_iii back to HEAD.
svn path=/trunk/kdebase/kwin/; revision=251608
2003-09-16 19:28:03 +00:00