1. The I18N_ARGUMENT_MISSING that appears when moving or resizing one
window. The problem happens because when declaring the variables
myResizeString, myCoordString[0] and myCoordString_[1] i18nc tries to
replace %1, %2, %3, and %4, but those arguments are not passed here.
Using #define we avoid the argument passsage.
2. Replace QString::arg() with direct formating, which is better for
performance.
I know we should avoid #define but in this case I think it is the best
option. If anyone has a better alternative feel free to change this
commit.
EffectsHandlerImpl connects to the Workspace signal clientActivated.
The emitting of the signal is slightly moved from before the activation logic
to after the activation logic. This might change behavior in the scripting
component, but the previous code looked wrong.
Client and Unmanaged use a signal to notify that they are about to be closed.
The EffectsHandlerImpl is connected to those signals and emits the appropriate
windowClosed signal to which the effects are connected.
All previously existing windowAdded methods are renamed to slotWindowAdded.
EffectsHandlerImpl is connected to Workspace's clientAdded signal, which is
emitted a little bit earlier than the previous direct method call. This might
change behavior.
Another signal is added to Workspace to signal that an unmanaged is added.
The first signal used between EffectsHandler and Effects.
The signal is actually emitted by the EffectsHandlerImpl and only
the interested effects connect to this signal.
EffectsHandlerImpl itself is also notified by a signal from Workspace,
allowing to remove one of the many if (effects) checks.
moved all caches to Private; added protected accessor, and updated daughter classes
accordingly. Also renamed variables for consistency with other classes
Looks like everything that needed merging (66de4e47..1021789c) was already
backported or forward-ported by hand (or was a scripty commit), so this
merge does no changes, just as if I had used -s ours.
* COMPOSITE_TODO lists many tasks already implemented or not valid any more,
it's easier to just write a new document with concrete tasks in the wiki
* NEWCOLORSCHEME.README has been unchanged since it's first introduction in 2000.
Does not sound any "new" to me and lists changes compared to KWM
* clients/PORTING: all important clients have been ported and what is not yet
ported will probably never get ported. The unported decos have been moved
to unmaintained some time ago.
* clients/REQUIREMENTS_FOR_CVS: well the requirements are not valid any more.
Messages from kdecorations library are extracted to libkdecorations.pot.
Messages from kwineffects library are extracted to libkwineffects.pot.
Currently there are no messages yet in kwineffects, so it's for future use.
Second part of cleaning up the lib directory: the effects library
now lives in libkwineffects/ directory.
For existing effects nothing changes as the install path is unchanged.
The change obsoletes the lib/ directory.
As glplatform.h has not yet been exported I dared to export it and
adjust the places where it is used.
CCMAIL: kwin@kde.org
The KDecoration library lives in libkdecorations/ now.
Installation pathes are unchanged, so this does not influence 3rd party
decorations.
The changes in the KWin main directory are required due to incorrect
includes.
CCMAIL: kwin@kde.org
Since the EffectFrames have been moved into KWin core nothing in the
Effects lib actually used Plasma. The only remaining method is moved
to core as it's not used in the Effects. The Effects itself still
link against Plasma, so nothing changes for them.
The Plasma includes in the kwineffects header seemed to pull in
quite some additional headers, so the includes in some effects have
to be adjusted (most often KConfigGroup). This should speed up the
compilation of the library and the effects.
* origin/aseigo/activityrunner:
extract messages
Service objects are owned by the caller
SVN_SILENT made messages (.desktop file)
match on name, not id
shh
crash fix + skip current
switch to a controller
less debug
add activity runner to build
make it possible to connect to this easier
first draft of an activity runner
add a new function fallbackPainting to GLVertexBufferPrivate class
replace the hard-coded index values for vertex and texCoords attributes in corePainting
Reviewed by: Martin Gräßlin <mgraesslin@kde.org>
