/* KWin - the KDE window manager This file is part of the KDE project. SPDX-FileCopyrightText: 2018 Vlad Zahorodnii SPDX-License-Identifier: GPL-2.0-or-later */ #include "kwin_wayland_test.h" #include "atoms.h" #include "core/platform.h" #include "deleted.h" #include "main.h" #include "wayland_server.h" #include "window.h" #include "workspace.h" #include "x11window.h" #include #include #include #include using namespace KWin; static const QString s_socketName = QStringLiteral("wayland_test_kwin_stacking_order-0"); class StackingOrderTest : public QObject { Q_OBJECT private Q_SLOTS: void initTestCase(); void init(); void cleanup(); void testTransientIsAboveParent(); void testRaiseTransient(); void testDeletedTransient(); void testGroupTransientIsAboveWindowGroup(); void testRaiseGroupTransient(); void testDeletedGroupTransient(); void testDontKeepAboveNonModalDialogGroupTransients(); void testKeepAbove(); void testKeepBelow(); }; void StackingOrderTest::initTestCase() { qRegisterMetaType(); qRegisterMetaType(); QSignalSpy applicationStartedSpy(kwinApp(), &Application::started); QVERIFY(applicationStartedSpy.isValid()); kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024)); QVERIFY(waylandServer()->init(s_socketName)); kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig)); kwinApp()->start(); QVERIFY(applicationStartedSpy.wait()); } void StackingOrderTest::init() { QVERIFY(Test::setupWaylandConnection()); } void StackingOrderTest::cleanup() { Test::destroyWaylandConnection(); } void StackingOrderTest::testTransientIsAboveParent() { // This test verifies that transients are always above their parents. // Create the parent. std::unique_ptr parentSurface = Test::createSurface(); QVERIFY(parentSurface); Test::XdgToplevel *parentShellSurface = Test::createXdgToplevelSurface(parentSurface.get(), parentSurface.get()); QVERIFY(parentShellSurface); Window *parent = Test::renderAndWaitForShown(parentSurface.get(), QSize(256, 256), Qt::blue); QVERIFY(parent); QVERIFY(parent->isActive()); QVERIFY(!parent->isTransient()); // Initially, the stacking order should contain only the parent window. QCOMPARE(workspace()->stackingOrder(), (QList{parent})); // Create the transient. std::unique_ptr transientSurface = Test::createSurface(); QVERIFY(transientSurface); Test::XdgToplevel *transientShellSurface = Test::createXdgToplevelSurface(transientSurface.get(), transientSurface.get()); QVERIFY(transientShellSurface); transientShellSurface->set_parent(parentShellSurface->object()); Window *transient = Test::renderAndWaitForShown(transientSurface.get(), QSize(128, 128), Qt::red); QVERIFY(transient); QVERIFY(transient->isActive()); QVERIFY(transient->isTransient()); // The transient should be above the parent. QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient})); // The transient still stays above the parent if we activate the latter. workspace()->activateWindow(parent); QTRY_VERIFY(parent->isActive()); QTRY_VERIFY(!transient->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient})); } void StackingOrderTest::testRaiseTransient() { // This test verifies that both the parent and the transient will be // raised if either one of them is activated. // Create the parent. std::unique_ptr parentSurface = Test::createSurface(); QVERIFY(parentSurface); Test::XdgToplevel *parentShellSurface = Test::createXdgToplevelSurface(parentSurface.get(), parentSurface.get()); QVERIFY(parentShellSurface); Window *parent = Test::renderAndWaitForShown(parentSurface.get(), QSize(256, 256), Qt::blue); QVERIFY(parent); QVERIFY(parent->isActive()); QVERIFY(!parent->isTransient()); // Initially, the stacking order should contain only the parent window. QCOMPARE(workspace()->stackingOrder(), (QList{parent})); // Create the transient. std::unique_ptr transientSurface = Test::createSurface(); QVERIFY(transientSurface); Test::XdgToplevel *transientShellSurface = Test::createXdgToplevelSurface(transientSurface.get(), transientSurface.get()); QVERIFY(transientShellSurface); transientShellSurface->set_parent(parentShellSurface->object()); Window *transient = Test::renderAndWaitForShown(transientSurface.get(), QSize(128, 128), Qt::red); QVERIFY(transient); QTRY_VERIFY(transient->isActive()); QVERIFY(transient->isTransient()); // The transient should be above the parent. QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient})); // Create a window that doesn't have any relationship to the parent or the transient. std::unique_ptr anotherSurface = Test::createSurface(); QVERIFY(anotherSurface); Test::XdgToplevel *anotherShellSurface = Test::createXdgToplevelSurface(anotherSurface.get(), anotherSurface.get()); QVERIFY(anotherShellSurface); Window *anotherWindow = Test::renderAndWaitForShown(anotherSurface.get(), QSize(128, 128), Qt::green); QVERIFY(anotherWindow); QVERIFY(anotherWindow->isActive()); QVERIFY(!anotherWindow->isTransient()); // The newly created surface has to be above both the parent and the transient. QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient, anotherWindow})); // If we activate the parent, the transient should be raised too. workspace()->activateWindow(parent); QTRY_VERIFY(parent->isActive()); QTRY_VERIFY(!transient->isActive()); QTRY_VERIFY(!anotherWindow->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{anotherWindow, parent, transient})); // Go back to the initial setup. workspace()->activateWindow(anotherWindow); QTRY_VERIFY(!parent->isActive()); QTRY_VERIFY(!transient->isActive()); QTRY_VERIFY(anotherWindow->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient, anotherWindow})); // If we activate the transient, the parent should be raised too. workspace()->activateWindow(transient); QTRY_VERIFY(!parent->isActive()); QTRY_VERIFY(transient->isActive()); QTRY_VERIFY(!anotherWindow->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{anotherWindow, parent, transient})); } struct WindowUnrefDeleter { void operator()(Deleted *d) { if (d != nullptr) { d->unrefWindow(); } } }; void StackingOrderTest::testDeletedTransient() { // This test verifies that deleted transients are kept above their // old parents. // Create the parent. std::unique_ptr parentSurface = Test::createSurface(); QVERIFY(parentSurface); Test::XdgToplevel *parentShellSurface = Test::createXdgToplevelSurface(parentSurface.get(), parentSurface.get()); QVERIFY(parentShellSurface); Window *parent = Test::renderAndWaitForShown(parentSurface.get(), QSize(256, 256), Qt::blue); QVERIFY(parent); QVERIFY(parent->isActive()); QVERIFY(!parent->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{parent})); // Create the first transient. std::unique_ptr transient1Surface = Test::createSurface(); QVERIFY(transient1Surface); Test::XdgToplevel *transient1ShellSurface = Test::createXdgToplevelSurface(transient1Surface.get(), transient1Surface.get()); QVERIFY(transient1ShellSurface); transient1ShellSurface->set_parent(parentShellSurface->object()); Window *transient1 = Test::renderAndWaitForShown(transient1Surface.get(), QSize(128, 128), Qt::red); QVERIFY(transient1); QTRY_VERIFY(transient1->isActive()); QVERIFY(transient1->isTransient()); QCOMPARE(transient1->transientFor(), parent); QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient1})); // Create the second transient. std::unique_ptr transient2Surface = Test::createSurface(); QVERIFY(transient2Surface); Test::XdgToplevel *transient2ShellSurface = Test::createXdgToplevelSurface(transient2Surface.get(), transient2Surface.get()); QVERIFY(transient2ShellSurface); transient2ShellSurface->set_parent(transient1ShellSurface->object()); Window *transient2 = Test::renderAndWaitForShown(transient2Surface.get(), QSize(128, 128), Qt::red); QVERIFY(transient2); QTRY_VERIFY(transient2->isActive()); QVERIFY(transient2->isTransient()); QCOMPARE(transient2->transientFor(), transient1); QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient1, transient2})); // Activate the parent, both transients have to be above it. workspace()->activateWindow(parent); QTRY_VERIFY(parent->isActive()); QTRY_VERIFY(!transient1->isActive()); QTRY_VERIFY(!transient2->isActive()); // Close the top-most transient. connect(transient2, &Window::windowClosed, this, [](Window *original, Deleted *deleted) { Q_UNUSED(original) deleted->refWindow(); }); QSignalSpy windowClosedSpy(transient2, &Window::windowClosed); QVERIFY(windowClosedSpy.isValid()); delete transient2ShellSurface; transient2Surface.reset(); QVERIFY(windowClosedSpy.wait()); std::unique_ptr deletedTransient( windowClosedSpy.first().at(1).value()); QVERIFY(deletedTransient.get()); // The deleted transient still has to be above its old parent (transient1). QTRY_VERIFY(parent->isActive()); QTRY_VERIFY(!transient1->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{parent, transient1, deletedTransient.get()})); } static xcb_window_t createGroupWindow(xcb_connection_t *conn, const QRect &geometry, xcb_window_t leaderWid = XCB_WINDOW_NONE) { xcb_window_t wid = xcb_generate_id(conn); xcb_create_window( conn, // c XCB_COPY_FROM_PARENT, // depth wid, // wid rootWindow(), // parent geometry.x(), // x geometry.y(), // y geometry.width(), // width geometry.height(), // height 0, // border_width XCB_WINDOW_CLASS_INPUT_OUTPUT, // _class XCB_COPY_FROM_PARENT, // visual 0, // value_mask nullptr // value_list ); xcb_size_hints_t sizeHints = {}; xcb_icccm_size_hints_set_position(&sizeHints, 1, geometry.x(), geometry.y()); xcb_icccm_size_hints_set_size(&sizeHints, 1, geometry.width(), geometry.height()); xcb_icccm_set_wm_normal_hints(conn, wid, &sizeHints); if (leaderWid == XCB_WINDOW_NONE) { leaderWid = wid; } xcb_change_property( conn, // c XCB_PROP_MODE_REPLACE, // mode wid, // window atoms->wm_client_leader, // property XCB_ATOM_WINDOW, // type 32, // format 1, // data_len &leaderWid // data ); return wid; } struct XcbConnectionDeleter { void operator()(xcb_connection_t *c) { xcb_disconnect(c); } }; void StackingOrderTest::testGroupTransientIsAboveWindowGroup() { // This test verifies that group transients are always above other // window group members. const QRect geometry = QRect(0, 0, 128, 128); std::unique_ptr conn( xcb_connect(nullptr, nullptr)); QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded); QVERIFY(windowCreatedSpy.isValid()); // Create the group leader. xcb_window_t leaderWid = createGroupWindow(conn.get(), geometry); xcb_map_window(conn.get(), leaderWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *leader = windowCreatedSpy.first().first().value(); QVERIFY(leader); QVERIFY(leader->isActive()); QCOMPARE(leader->window(), leaderWid); QVERIFY(!leader->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader})); // Create another group member. windowCreatedSpy.clear(); xcb_window_t member1Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member1Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member1 = windowCreatedSpy.first().first().value(); QVERIFY(member1); QVERIFY(member1->isActive()); QCOMPARE(member1->window(), member1Wid); QCOMPARE(member1->group(), leader->group()); QVERIFY(!member1->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1})); // Create yet another group member. windowCreatedSpy.clear(); xcb_window_t member2Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member2Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member2 = windowCreatedSpy.first().first().value(); QVERIFY(member2); QVERIFY(member2->isActive()); QCOMPARE(member2->window(), member2Wid); QCOMPARE(member2->group(), leader->group()); QVERIFY(!member2->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2})); // Create a group transient. windowCreatedSpy.clear(); xcb_window_t transientWid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_icccm_set_wm_transient_for(conn.get(), transientWid, rootWindow()); // Currently, we have some weird bug workaround: if a group transient // is a non-modal dialog, then it won't be kept above its window group. // We need to explicitly specify window type, otherwise the window type // will be deduced to _NET_WM_WINDOW_TYPE_DIALOG because we set transient // for before (the EWMH spec says to do that). xcb_atom_t net_wm_window_type = Xcb::Atom( QByteArrayLiteral("_NET_WM_WINDOW_TYPE"), false, conn.get()); xcb_atom_t net_wm_window_type_normal = Xcb::Atom( QByteArrayLiteral("_NET_WM_WINDOW_TYPE_NORMAL"), false, conn.get()); xcb_change_property( conn.get(), // c XCB_PROP_MODE_REPLACE, // mode transientWid, // window net_wm_window_type, // property XCB_ATOM_ATOM, // type 32, // format 1, // data_len &net_wm_window_type_normal // data ); xcb_map_window(conn.get(), transientWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *transient = windowCreatedSpy.first().first().value(); QVERIFY(transient); QVERIFY(transient->isActive()); QCOMPARE(transient->window(), transientWid); QCOMPARE(transient->group(), leader->group()); QVERIFY(transient->isTransient()); QVERIFY(transient->groupTransient()); QVERIFY(!transient->isDialog()); // See above why QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); // If we activate any member of the window group, the transient will be above it. workspace()->activateWindow(leader); QTRY_VERIFY(leader->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member1, member2, leader, transient})); workspace()->activateWindow(member1); QTRY_VERIFY(member1->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member2, leader, member1, transient})); workspace()->activateWindow(member2); QTRY_VERIFY(member2->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); workspace()->activateWindow(transient); QTRY_VERIFY(transient->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); } void StackingOrderTest::testRaiseGroupTransient() { const QRect geometry = QRect(0, 0, 128, 128); std::unique_ptr conn( xcb_connect(nullptr, nullptr)); QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded); QVERIFY(windowCreatedSpy.isValid()); // Create the group leader. xcb_window_t leaderWid = createGroupWindow(conn.get(), geometry); xcb_map_window(conn.get(), leaderWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *leader = windowCreatedSpy.first().first().value(); QVERIFY(leader); QVERIFY(leader->isActive()); QCOMPARE(leader->window(), leaderWid); QVERIFY(!leader->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader})); // Create another group member. windowCreatedSpy.clear(); xcb_window_t member1Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member1Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member1 = windowCreatedSpy.first().first().value(); QVERIFY(member1); QVERIFY(member1->isActive()); QCOMPARE(member1->window(), member1Wid); QCOMPARE(member1->group(), leader->group()); QVERIFY(!member1->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1})); // Create yet another group member. windowCreatedSpy.clear(); xcb_window_t member2Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member2Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member2 = windowCreatedSpy.first().first().value(); QVERIFY(member2); QVERIFY(member2->isActive()); QCOMPARE(member2->window(), member2Wid); QCOMPARE(member2->group(), leader->group()); QVERIFY(!member2->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2})); // Create a group transient. windowCreatedSpy.clear(); xcb_window_t transientWid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_icccm_set_wm_transient_for(conn.get(), transientWid, rootWindow()); // Currently, we have some weird bug workaround: if a group transient // is a non-modal dialog, then it won't be kept above its window group. // We need to explicitly specify window type, otherwise the window type // will be deduced to _NET_WM_WINDOW_TYPE_DIALOG because we set transient // for before (the EWMH spec says to do that). xcb_atom_t net_wm_window_type = Xcb::Atom( QByteArrayLiteral("_NET_WM_WINDOW_TYPE"), false, conn.get()); xcb_atom_t net_wm_window_type_normal = Xcb::Atom( QByteArrayLiteral("_NET_WM_WINDOW_TYPE_NORMAL"), false, conn.get()); xcb_change_property( conn.get(), // c XCB_PROP_MODE_REPLACE, // mode transientWid, // window net_wm_window_type, // property XCB_ATOM_ATOM, // type 32, // format 1, // data_len &net_wm_window_type_normal // data ); xcb_map_window(conn.get(), transientWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *transient = windowCreatedSpy.first().first().value(); QVERIFY(transient); QVERIFY(transient->isActive()); QCOMPARE(transient->window(), transientWid); QCOMPARE(transient->group(), leader->group()); QVERIFY(transient->isTransient()); QVERIFY(transient->groupTransient()); QVERIFY(!transient->isDialog()); // See above why QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); // Create a Wayland window that is not a member of the window group. std::unique_ptr anotherSurface = Test::createSurface(); QVERIFY(anotherSurface); Test::XdgToplevel *anotherShellSurface = Test::createXdgToplevelSurface(anotherSurface.get(), anotherSurface.get()); QVERIFY(anotherShellSurface); Window *anotherWindow = Test::renderAndWaitForShown(anotherSurface.get(), QSize(128, 128), Qt::green); QVERIFY(anotherWindow); QVERIFY(anotherWindow->isActive()); QVERIFY(!anotherWindow->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient, anotherWindow})); // If we activate the leader, then only it and the transient have to be raised. workspace()->activateWindow(leader); QTRY_VERIFY(leader->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member1, member2, anotherWindow, leader, transient})); // If another member of the window group is activated, then the transient will // be above that member and the leader. workspace()->activateWindow(member2); QTRY_VERIFY(member2->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member1, anotherWindow, leader, member2, transient})); // FIXME: If we activate the transient, only it will be raised. workspace()->activateWindow(anotherWindow); QTRY_VERIFY(anotherWindow->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member1, leader, member2, transient, anotherWindow})); workspace()->activateWindow(transient); QTRY_VERIFY(transient->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member1, leader, member2, anotherWindow, transient})); } void StackingOrderTest::testDeletedGroupTransient() { // This test verifies that deleted group transients are kept above their // old window groups. const QRect geometry = QRect(0, 0, 128, 128); std::unique_ptr conn( xcb_connect(nullptr, nullptr)); QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded); QVERIFY(windowCreatedSpy.isValid()); // Create the group leader. xcb_window_t leaderWid = createGroupWindow(conn.get(), geometry); xcb_map_window(conn.get(), leaderWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *leader = windowCreatedSpy.first().first().value(); QVERIFY(leader); QVERIFY(leader->isActive()); QCOMPARE(leader->window(), leaderWid); QVERIFY(!leader->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader})); // Create another group member. windowCreatedSpy.clear(); xcb_window_t member1Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member1Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member1 = windowCreatedSpy.first().first().value(); QVERIFY(member1); QVERIFY(member1->isActive()); QCOMPARE(member1->window(), member1Wid); QCOMPARE(member1->group(), leader->group()); QVERIFY(!member1->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1})); // Create yet another group member. windowCreatedSpy.clear(); xcb_window_t member2Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member2Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member2 = windowCreatedSpy.first().first().value(); QVERIFY(member2); QVERIFY(member2->isActive()); QCOMPARE(member2->window(), member2Wid); QCOMPARE(member2->group(), leader->group()); QVERIFY(!member2->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2})); // Create a group transient. windowCreatedSpy.clear(); xcb_window_t transientWid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_icccm_set_wm_transient_for(conn.get(), transientWid, rootWindow()); // Currently, we have some weird bug workaround: if a group transient // is a non-modal dialog, then it won't be kept above its window group. // We need to explicitly specify window type, otherwise the window type // will be deduced to _NET_WM_WINDOW_TYPE_DIALOG because we set transient // for before (the EWMH spec says to do that). xcb_atom_t net_wm_window_type = Xcb::Atom( QByteArrayLiteral("_NET_WM_WINDOW_TYPE"), false, conn.get()); xcb_atom_t net_wm_window_type_normal = Xcb::Atom( QByteArrayLiteral("_NET_WM_WINDOW_TYPE_NORMAL"), false, conn.get()); xcb_change_property( conn.get(), // c XCB_PROP_MODE_REPLACE, // mode transientWid, // window net_wm_window_type, // property XCB_ATOM_ATOM, // type 32, // format 1, // data_len &net_wm_window_type_normal // data ); xcb_map_window(conn.get(), transientWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *transient = windowCreatedSpy.first().first().value(); QVERIFY(transient); QVERIFY(transient->isActive()); QCOMPARE(transient->window(), transientWid); QCOMPARE(transient->group(), leader->group()); QVERIFY(transient->isTransient()); QVERIFY(transient->groupTransient()); QVERIFY(!transient->isDialog()); // See above why QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); // Unmap the transient. connect(transient, &X11Window::windowClosed, this, [](Window *original, Deleted *deleted) { Q_UNUSED(original) deleted->refWindow(); }); QSignalSpy windowClosedSpy(transient, &X11Window::windowClosed); QVERIFY(windowClosedSpy.isValid()); xcb_unmap_window(conn.get(), transientWid); xcb_flush(conn.get()); QVERIFY(windowClosedSpy.wait()); std::unique_ptr deletedTransient( windowClosedSpy.first().at(1).value()); QVERIFY(deletedTransient.get()); // The transient has to be above each member of the window group. QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, deletedTransient.get()})); } void StackingOrderTest::testDontKeepAboveNonModalDialogGroupTransients() { // Bug 76026 const QRect geometry = QRect(0, 0, 128, 128); std::unique_ptr conn( xcb_connect(nullptr, nullptr)); QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded); QVERIFY(windowCreatedSpy.isValid()); // Create the group leader. xcb_window_t leaderWid = createGroupWindow(conn.get(), geometry); xcb_map_window(conn.get(), leaderWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *leader = windowCreatedSpy.first().first().value(); QVERIFY(leader); QVERIFY(leader->isActive()); QCOMPARE(leader->window(), leaderWid); QVERIFY(!leader->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader})); // Create another group member. windowCreatedSpy.clear(); xcb_window_t member1Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member1Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member1 = windowCreatedSpy.first().first().value(); QVERIFY(member1); QVERIFY(member1->isActive()); QCOMPARE(member1->window(), member1Wid); QCOMPARE(member1->group(), leader->group()); QVERIFY(!member1->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1})); // Create yet another group member. windowCreatedSpy.clear(); xcb_window_t member2Wid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_map_window(conn.get(), member2Wid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *member2 = windowCreatedSpy.first().first().value(); QVERIFY(member2); QVERIFY(member2->isActive()); QCOMPARE(member2->window(), member2Wid); QCOMPARE(member2->group(), leader->group()); QVERIFY(!member2->isTransient()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2})); // Create a group transient. windowCreatedSpy.clear(); xcb_window_t transientWid = createGroupWindow(conn.get(), geometry, leaderWid); xcb_icccm_set_wm_transient_for(conn.get(), transientWid, rootWindow()); xcb_map_window(conn.get(), transientWid); xcb_flush(conn.get()); QVERIFY(windowCreatedSpy.wait()); X11Window *transient = windowCreatedSpy.first().first().value(); QVERIFY(transient); QVERIFY(transient->isActive()); QCOMPARE(transient->window(), transientWid); QCOMPARE(transient->group(), leader->group()); QVERIFY(transient->isTransient()); QVERIFY(transient->groupTransient()); QVERIFY(transient->isDialog()); QVERIFY(!transient->isModal()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); workspace()->activateWindow(leader); QTRY_VERIFY(leader->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member1, member2, transient, leader})); workspace()->activateWindow(member1); QTRY_VERIFY(member1->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{member2, transient, leader, member1})); workspace()->activateWindow(member2); QTRY_VERIFY(member2->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{transient, leader, member1, member2})); workspace()->activateWindow(transient); QTRY_VERIFY(transient->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{leader, member1, member2, transient})); } void StackingOrderTest::testKeepAbove() { // This test verifies that "keep-above" windows are kept above other windows. // Create the first window. std::unique_ptr surface1 = Test::createSurface(); QVERIFY(surface1); Test::XdgToplevel *shellSurface1 = Test::createXdgToplevelSurface(surface1.get(), surface1.get()); QVERIFY(shellSurface1); Window *window1 = Test::renderAndWaitForShown(surface1.get(), QSize(128, 128), Qt::green); QVERIFY(window1); QVERIFY(window1->isActive()); QVERIFY(!window1->keepAbove()); QCOMPARE(workspace()->stackingOrder(), (QList{window1})); // Create the second window. std::unique_ptr surface2 = Test::createSurface(); QVERIFY(surface2); Test::XdgToplevel *shellSurface2 = Test::createXdgToplevelSurface(surface2.get(), surface2.get()); QVERIFY(shellSurface2); Window *window2 = Test::renderAndWaitForShown(surface2.get(), QSize(128, 128), Qt::green); QVERIFY(window2); QVERIFY(window2->isActive()); QVERIFY(!window2->keepAbove()); QCOMPARE(workspace()->stackingOrder(), (QList{window1, window2})); // Go to the initial test position. workspace()->activateWindow(window1); QTRY_VERIFY(window1->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{window2, window1})); // Set the "keep-above" flag on the window2, it should go above other windows. { StackingUpdatesBlocker blocker(workspace()); window2->setKeepAbove(true); } QVERIFY(window2->keepAbove()); QVERIFY(!window2->isActive()); QCOMPARE(workspace()->stackingOrder(), (QList{window1, window2})); } void StackingOrderTest::testKeepBelow() { // This test verifies that "keep-below" windows are kept below other windows. // Create the first window. std::unique_ptr surface1 = Test::createSurface(); QVERIFY(surface1); Test::XdgToplevel *shellSurface1 = Test::createXdgToplevelSurface(surface1.get(), surface1.get()); QVERIFY(shellSurface1); Window *window1 = Test::renderAndWaitForShown(surface1.get(), QSize(128, 128), Qt::green); QVERIFY(window1); QVERIFY(window1->isActive()); QVERIFY(!window1->keepBelow()); QCOMPARE(workspace()->stackingOrder(), (QList{window1})); // Create the second window. std::unique_ptr surface2 = Test::createSurface(); QVERIFY(surface2); Test::XdgToplevel *shellSurface2 = Test::createXdgToplevelSurface(surface2.get(), surface2.get()); QVERIFY(shellSurface2); Window *window2 = Test::renderAndWaitForShown(surface2.get(), QSize(128, 128), Qt::green); QVERIFY(window2); QVERIFY(window2->isActive()); QVERIFY(!window2->keepBelow()); QCOMPARE(workspace()->stackingOrder(), (QList{window1, window2})); // Set the "keep-below" flag on the window2, it should go below other windows. { StackingUpdatesBlocker blocker(workspace()); window2->setKeepBelow(true); } QVERIFY(window2->isActive()); QVERIFY(window2->keepBelow()); QCOMPARE(workspace()->stackingOrder(), (QList{window2, window1})); } WAYLANDTEST_MAIN(StackingOrderTest) #include "stacking_order_test.moc"