02a0561016
Summary: KWindowSystem provides a plugin interface to have platform specific implementations. So far KWin relied on the implementation in KWayland-integration repository. This is something I find unsuited, for the following reasons: * any test in KWin for functionality set through the plugin would fail * it's not clear what's going on where * in worst case some code could deadlock * KWin shouldn't use KWindowSystem and only a small subset is allowed to be used The last point needs some further explanation. KWin internally does not and cannot use KWindowSystem. KWindowSystem (especially KWindowInfo) is exposing information which KWin sets. It's more than weird if KWin asks KWindowSystem for the state of a window it set itself. On X11 it's just slow, on Wayland it can result in roundtrips to KWin itself which is dangerous. But due to using Plasma components we have a few areas where we use KWindowSystem. E.g. a Plasma::Dialog sets a window type, the slide in direction, blur and background contrast. This we want to support and need to support. Other API elements we do not want, like for examples the available windows. KWin internal windows either have direct access to KWin or a scripting interface exposed providing (limited) access - there is just no need to have this in KWindowSystem. To make it more clear what KWin supports as API of KWindowSystem for internal windows this change implements a stripped down version of the kwayland-integration plugin. The main difference is that it does not use KWayland at all, but a QWindow internal side channel. To support this EffectWindow provides an accessor for internalWindow and the three already mentioned effects are adjusted to read from the internal QWindow and it's dynamic properties. This change is a first step for a further refactoring. I plan to split the internal window out of ShellClient into a dedicated class. I think there are nowadays too many special cases. If it moves out there is the question whether we really want to use Wayland for the internal windows or whether this is just historic ballast (after all we used to use qwayland for that in the beginning). As the change could introduce regressions I'm targetting 5.16. Test Plan: new test case for window type, manual testing using Alt+Tab for the effects integration. Sliding popups, blur and contrast worked fine. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D18228
1246 lines
52 KiB
C++
1246 lines
52 KiB
C++
/********************************************************************
|
||
KWin - the KDE window manager
|
||
This file is part of the KDE project.
|
||
|
||
Copyright (C) 2016 Martin Gräßlin <mgraesslin@kde.org>
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 2 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||
*********************************************************************/
|
||
#include "kwin_wayland_test.h"
|
||
#include "cursor.h"
|
||
#include "effects.h"
|
||
#include "deleted.h"
|
||
#include "platform.h"
|
||
#include "shell_client.h"
|
||
#include "screens.h"
|
||
#include "wayland_server.h"
|
||
#include "workspace.h"
|
||
|
||
#include <QDBusConnection>
|
||
|
||
#include <KWayland/Client/connection_thread.h>
|
||
#include <KWayland/Client/compositor.h>
|
||
#include <KWayland/Client/shell.h>
|
||
#include <KWayland/Client/output.h>
|
||
#include <KWayland/Client/server_decoration.h>
|
||
#include <KWayland/Client/surface.h>
|
||
#include <KWayland/Client/xdgshell.h>
|
||
#include <KWayland/Client/xdgdecoration.h>
|
||
#include <KWayland/Client/appmenu.h>
|
||
|
||
#include <KWayland/Server/clientconnection.h>
|
||
#include <KWayland/Server/display.h>
|
||
#include <KWayland/Server/shell_interface.h>
|
||
#include <KWayland/Server/xdgdecoration_interface.h>
|
||
|
||
// system
|
||
#include <sys/types.h>
|
||
#include <sys/socket.h>
|
||
#include <unistd.h>
|
||
|
||
using namespace KWin;
|
||
using namespace KWayland::Client;
|
||
|
||
static const QString s_socketName = QStringLiteral("wayland_test_kwin_shell_client-0");
|
||
|
||
class TestShellClient : public QObject
|
||
{
|
||
Q_OBJECT
|
||
private Q_SLOTS:
|
||
void initTestCase();
|
||
void init();
|
||
void cleanup();
|
||
|
||
void testMapUnmapMap_data();
|
||
void testMapUnmapMap();
|
||
void testDesktopPresenceChanged();
|
||
void testTransientPositionAfterRemap();
|
||
void testWindowOutputs_data();
|
||
void testWindowOutputs();
|
||
void testMinimizeActiveWindow_data();
|
||
void testMinimizeActiveWindow();
|
||
void testFullscreen_data();
|
||
void testFullscreen();
|
||
void testUserCanSetFullscreen_data();
|
||
void testUserCanSetFullscreen();
|
||
void testUserSetFullscreenWlShell();
|
||
void testUserSetFullscreenXdgShell_data();
|
||
void testUserSetFullscreenXdgShell();
|
||
void testMaximizedToFullscreen_data();
|
||
void testMaximizedToFullscreen();
|
||
void testWindowOpensLargerThanScreen_data();
|
||
void testWindowOpensLargerThanScreen();
|
||
void testHidden_data();
|
||
void testHidden();
|
||
void testDesktopFileName();
|
||
void testCaptionSimplified();
|
||
void testCaptionMultipleWindows();
|
||
void testUnresponsiveWindow_data();
|
||
void testUnresponsiveWindow();
|
||
void testX11WindowId_data();
|
||
void testX11WindowId();
|
||
void testAppMenu();
|
||
void testNoDecorationModeRequested_data();
|
||
void testNoDecorationModeRequested();
|
||
void testSendClientWithTransientToDesktop_data();
|
||
void testSendClientWithTransientToDesktop();
|
||
void testMinimizeWindowWithTransients_data();
|
||
void testMinimizeWindowWithTransients();
|
||
void testXdgDecoration_data();
|
||
void testXdgDecoration();
|
||
};
|
||
|
||
void TestShellClient::initTestCase()
|
||
{
|
||
qRegisterMetaType<KWin::Deleted*>();
|
||
qRegisterMetaType<KWin::ShellClient*>();
|
||
qRegisterMetaType<KWin::AbstractClient*>();
|
||
qRegisterMetaType<KWayland::Client::Output*>();
|
||
|
||
QSignalSpy workspaceCreatedSpy(kwinApp(), &Application::workspaceCreated);
|
||
QVERIFY(workspaceCreatedSpy.isValid());
|
||
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
||
QMetaObject::invokeMethod(kwinApp()->platform(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(int, 2));
|
||
QVERIFY(waylandServer()->init(s_socketName.toLocal8Bit()));
|
||
|
||
kwinApp()->start();
|
||
QVERIFY(workspaceCreatedSpy.wait());
|
||
QCOMPARE(screens()->count(), 2);
|
||
QCOMPARE(screens()->geometry(0), QRect(0, 0, 1280, 1024));
|
||
QCOMPARE(screens()->geometry(1), QRect(1280, 0, 1280, 1024));
|
||
waylandServer()->initWorkspace();
|
||
}
|
||
|
||
void TestShellClient::init()
|
||
{
|
||
QVERIFY(Test::setupWaylandConnection(Test::AdditionalWaylandInterface::Decoration |
|
||
Test::AdditionalWaylandInterface::XdgDecoration |
|
||
Test::AdditionalWaylandInterface::AppMenu));
|
||
|
||
screens()->setCurrent(0);
|
||
KWin::Cursor::setPos(QPoint(1280, 512));
|
||
}
|
||
|
||
void TestShellClient::cleanup()
|
||
{
|
||
Test::destroyWaylandConnection();
|
||
}
|
||
|
||
void TestShellClient::testMapUnmapMap_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testMapUnmapMap()
|
||
{
|
||
// this test verifies that mapping a previously mapped window works correctly
|
||
QSignalSpy clientAddedSpy(waylandServer(), &WaylandServer::shellClientAdded);
|
||
QVERIFY(clientAddedSpy.isValid());
|
||
QSignalSpy effectsWindowShownSpy(effects, &EffectsHandler::windowShown);
|
||
QVERIFY(effectsWindowShownSpy.isValid());
|
||
QSignalSpy effectsWindowHiddenSpy(effects, &EffectsHandler::windowHidden);
|
||
QVERIFY(effectsWindowHiddenSpy.isValid());
|
||
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
|
||
// now let's render
|
||
Test::render(surface.data(), QSize(100, 50), Qt::blue);
|
||
|
||
QVERIFY(clientAddedSpy.isEmpty());
|
||
QVERIFY(clientAddedSpy.wait());
|
||
auto client = clientAddedSpy.first().first().value<ShellClient*>();
|
||
QVERIFY(client);
|
||
QVERIFY(client->isShown(true));
|
||
QCOMPARE(client->isHiddenInternal(), false);
|
||
QCOMPARE(client->readyForPainting(), true);
|
||
QCOMPARE(client->depth(), 32);
|
||
QVERIFY(client->hasAlpha());
|
||
QCOMPARE(client->icon().name(), QStringLiteral("wayland"));
|
||
QCOMPARE(workspace()->activeClient(), client);
|
||
QVERIFY(effectsWindowShownSpy.isEmpty());
|
||
QVERIFY(client->isMaximizable());
|
||
QVERIFY(client->isMovable());
|
||
QVERIFY(client->isMovableAcrossScreens());
|
||
QVERIFY(client->isResizable());
|
||
QVERIFY(client->property("maximizable").toBool());
|
||
QVERIFY(client->property("moveable").toBool());
|
||
QVERIFY(client->property("moveableAcrossScreens").toBool());
|
||
QVERIFY(client->property("resizeable").toBool());
|
||
QCOMPARE(client->isInternal(), false);
|
||
QVERIFY(client->effectWindow());
|
||
QVERIFY(!client->effectWindow()->internalWindow());
|
||
QCOMPARE(client->internalId().isNull(), false);
|
||
const auto uuid = client->internalId();
|
||
QUuid deletedUuid;
|
||
QCOMPARE(deletedUuid.isNull(), true);
|
||
|
||
connect(client, &ShellClient::windowClosed, this, [&deletedUuid] (Toplevel *, Deleted *d) { deletedUuid = d->internalId(); });
|
||
|
||
// now unmap
|
||
QSignalSpy hiddenSpy(client, &ShellClient::windowHidden);
|
||
QVERIFY(hiddenSpy.isValid());
|
||
QSignalSpy windowClosedSpy(client, &ShellClient::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
surface->attachBuffer(Buffer::Ptr());
|
||
surface->commit(Surface::CommitFlag::None);
|
||
QVERIFY(hiddenSpy.wait());
|
||
QCOMPARE(client->readyForPainting(), true);
|
||
QCOMPARE(client->isHiddenInternal(), true);
|
||
QVERIFY(windowClosedSpy.isEmpty());
|
||
QVERIFY(!workspace()->activeClient());
|
||
QCOMPARE(effectsWindowHiddenSpy.count(), 1);
|
||
QCOMPARE(effectsWindowHiddenSpy.first().first().value<EffectWindow*>(), client->effectWindow());
|
||
|
||
QSignalSpy windowShownSpy(client, &ShellClient::windowShown);
|
||
QVERIFY(windowShownSpy.isValid());
|
||
Test::render(surface.data(), QSize(100, 50), Qt::blue, QImage::Format_RGB32);
|
||
QCOMPARE(clientAddedSpy.count(), 1);
|
||
QVERIFY(windowShownSpy.wait());
|
||
QCOMPARE(windowShownSpy.count(), 1);
|
||
QCOMPARE(clientAddedSpy.count(), 1);
|
||
QCOMPARE(client->readyForPainting(), true);
|
||
QCOMPARE(client->isHiddenInternal(), false);
|
||
QCOMPARE(client->depth(), 24);
|
||
QVERIFY(!client->hasAlpha());
|
||
QCOMPARE(workspace()->activeClient(), client);
|
||
QCOMPARE(effectsWindowShownSpy.count(), 1);
|
||
QCOMPARE(effectsWindowShownSpy.first().first().value<EffectWindow*>(), client->effectWindow());
|
||
|
||
// let's unmap again
|
||
surface->attachBuffer(Buffer::Ptr());
|
||
surface->commit(Surface::CommitFlag::None);
|
||
QVERIFY(hiddenSpy.wait());
|
||
QCOMPARE(hiddenSpy.count(), 2);
|
||
QCOMPARE(client->readyForPainting(), true);
|
||
QCOMPARE(client->isHiddenInternal(), true);
|
||
QCOMPARE(client->internalId(), uuid);
|
||
QVERIFY(windowClosedSpy.isEmpty());
|
||
QCOMPARE(effectsWindowHiddenSpy.count(), 2);
|
||
QCOMPARE(effectsWindowHiddenSpy.last().first().value<EffectWindow*>(), client->effectWindow());
|
||
|
||
shellSurface.reset();
|
||
surface.reset();
|
||
QVERIFY(windowClosedSpy.wait());
|
||
QCOMPARE(windowClosedSpy.count(), 1);
|
||
QCOMPARE(effectsWindowHiddenSpy.count(), 2);
|
||
QCOMPARE(deletedUuid.isNull(), false);
|
||
QCOMPARE(deletedUuid, uuid);
|
||
}
|
||
|
||
void TestShellClient::testDesktopPresenceChanged()
|
||
{
|
||
// this test verifies that the desktop presence changed signals are properly emitted
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<ShellSurface> shellSurface(Test::createShellSurface(surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QCOMPARE(c->desktop(), 1);
|
||
effects->setNumberOfDesktops(4);
|
||
QSignalSpy desktopPresenceChangedClientSpy(c, &ShellClient::desktopPresenceChanged);
|
||
QVERIFY(desktopPresenceChangedClientSpy.isValid());
|
||
QSignalSpy desktopPresenceChangedWorkspaceSpy(workspace(), &Workspace::desktopPresenceChanged);
|
||
QVERIFY(desktopPresenceChangedWorkspaceSpy.isValid());
|
||
QSignalSpy desktopPresenceChangedEffectsSpy(effects, &EffectsHandler::desktopPresenceChanged);
|
||
QVERIFY(desktopPresenceChangedEffectsSpy.isValid());
|
||
|
||
// let's change the desktop
|
||
workspace()->sendClientToDesktop(c, 2, false);
|
||
QCOMPARE(c->desktop(), 2);
|
||
QCOMPARE(desktopPresenceChangedClientSpy.count(), 1);
|
||
QCOMPARE(desktopPresenceChangedWorkspaceSpy.count(), 1);
|
||
QCOMPARE(desktopPresenceChangedEffectsSpy.count(), 1);
|
||
|
||
// verify the arguments
|
||
QCOMPARE(desktopPresenceChangedClientSpy.first().at(0).value<AbstractClient*>(), c);
|
||
QCOMPARE(desktopPresenceChangedClientSpy.first().at(1).toInt(), 1);
|
||
QCOMPARE(desktopPresenceChangedWorkspaceSpy.first().at(0).value<AbstractClient*>(), c);
|
||
QCOMPARE(desktopPresenceChangedWorkspaceSpy.first().at(1).toInt(), 1);
|
||
QCOMPARE(desktopPresenceChangedEffectsSpy.first().at(0).value<EffectWindow*>(), c->effectWindow());
|
||
QCOMPARE(desktopPresenceChangedEffectsSpy.first().at(1).toInt(), 1);
|
||
QCOMPARE(desktopPresenceChangedEffectsSpy.first().at(2).toInt(), 2);
|
||
}
|
||
|
||
void TestShellClient::testTransientPositionAfterRemap()
|
||
{
|
||
// this test simulates the situation that a transient window gets reused and the parent window
|
||
// moved between the two usages
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<ShellSurface> shellSurface(Test::createShellSurface(surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
|
||
// create the Transient window
|
||
QScopedPointer<Surface> transientSurface(Test::createSurface());
|
||
QScopedPointer<ShellSurface> transientShellSurface(Test::createShellSurface(transientSurface.data()));
|
||
transientShellSurface->setTransient(surface.data(), QPoint(5, 10));
|
||
auto transient = Test::renderAndWaitForShown(transientSurface.data(), QSize(50, 40), Qt::blue);
|
||
QVERIFY(transient);
|
||
QCOMPARE(transient->geometry(), QRect(c->geometry().topLeft() + QPoint(5, 10), QSize(50, 40)));
|
||
|
||
// unmap the transient
|
||
QSignalSpy windowHiddenSpy(transient, &ShellClient::windowHidden);
|
||
QVERIFY(windowHiddenSpy.isValid());
|
||
transientSurface->attachBuffer(Buffer::Ptr());
|
||
transientSurface->commit(Surface::CommitFlag::None);
|
||
QVERIFY(windowHiddenSpy.wait());
|
||
|
||
// now move the parent surface
|
||
c->setGeometry(c->geometry().translated(5, 10));
|
||
|
||
// now map the transient again
|
||
QSignalSpy windowShownSpy(transient, &ShellClient::windowShown);
|
||
QVERIFY(windowShownSpy.isValid());
|
||
Test::render(transientSurface.data(), QSize(50, 40), Qt::blue);
|
||
QVERIFY(windowShownSpy.wait());
|
||
QCOMPARE(transient->geometry(), QRect(c->geometry().topLeft() + QPoint(5, 10), QSize(50, 40)));
|
||
}
|
||
|
||
void TestShellClient::testWindowOutputs_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testWindowOutputs()
|
||
{
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
auto size = QSize(200,200);
|
||
|
||
QSignalSpy outputEnteredSpy(surface.data(), &Surface::outputEntered);
|
||
QSignalSpy outputLeftSpy(surface.data(), &Surface::outputLeft);
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), size, Qt::blue);
|
||
//move to be in the first screen
|
||
c->setGeometry(QRect(QPoint(100,100), size));
|
||
//we don't don't know where the compositor first placed this window,
|
||
//this might fire, it might not
|
||
outputEnteredSpy.wait(5);
|
||
outputEnteredSpy.clear();
|
||
|
||
QCOMPARE(surface->outputs().count(), 1);
|
||
QCOMPARE(surface->outputs().first()->globalPosition(), QPoint(0,0));
|
||
|
||
//move to overlapping both first and second screen
|
||
c->setGeometry(QRect(QPoint(1250,100), size));
|
||
QVERIFY(outputEnteredSpy.wait());
|
||
QCOMPARE(outputEnteredSpy.count(), 1);
|
||
QCOMPARE(outputLeftSpy.count(), 0);
|
||
QCOMPARE(surface->outputs().count(), 2);
|
||
QVERIFY(surface->outputs()[0] != surface->outputs()[1]);
|
||
|
||
//move entirely into second screen
|
||
c->setGeometry(QRect(QPoint(1400,100), size));
|
||
QVERIFY(outputLeftSpy.wait());
|
||
QCOMPARE(outputEnteredSpy.count(), 1);
|
||
QCOMPARE(outputLeftSpy.count(), 1);
|
||
QCOMPARE(surface->outputs().count(), 1);
|
||
QCOMPARE(surface->outputs().first()->globalPosition(), QPoint(1280,0));
|
||
}
|
||
|
||
void TestShellClient::testMinimizeActiveWindow_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testMinimizeActiveWindow()
|
||
{
|
||
// this test verifies that when minimizing the active window it gets deactivated
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QCOMPARE(workspace()->activeClient(), c);
|
||
QVERIFY(c->wantsInput());
|
||
QVERIFY(c->wantsTabFocus());
|
||
QVERIFY(c->isShown(true));
|
||
|
||
workspace()->slotWindowMinimize();
|
||
QVERIFY(!c->isShown(true));
|
||
QVERIFY(c->wantsInput());
|
||
QVERIFY(c->wantsTabFocus());
|
||
QVERIFY(!c->isActive());
|
||
QVERIFY(!workspace()->activeClient());
|
||
QVERIFY(c->isMinimized());
|
||
|
||
// unminimize again
|
||
c->unminimize();
|
||
QVERIFY(!c->isMinimized());
|
||
QVERIFY(c->isActive());
|
||
QVERIFY(c->wantsInput());
|
||
QVERIFY(c->wantsTabFocus());
|
||
QVERIFY(c->isShown(true));
|
||
QCOMPARE(workspace()->activeClient(), c);
|
||
}
|
||
|
||
void TestShellClient::testFullscreen_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
QTest::addColumn<ServerSideDecoration::Mode>("decoMode");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell << ServerSideDecoration::Mode::Client;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5 << ServerSideDecoration::Mode::Client;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6 << ServerSideDecoration::Mode::Client;
|
||
QTest::newRow("xdgShellWmBase") << Test::ShellSurfaceType::XdgShellStable << ServerSideDecoration::Mode::Client;
|
||
|
||
QTest::newRow("wlShell - deco") << Test::ShellSurfaceType::WlShell << ServerSideDecoration::Mode::Server;
|
||
QTest::newRow("xdgShellV5 - deco") << Test::ShellSurfaceType::XdgShellV5 << ServerSideDecoration::Mode::Server;
|
||
QTest::newRow("xdgShellV6 - deco") << Test::ShellSurfaceType::XdgShellV6 << ServerSideDecoration::Mode::Server;
|
||
QTest::newRow("xdgShellWmBase - deco") << Test::ShellSurfaceType::XdgShellStable << ServerSideDecoration::Mode::Server;
|
||
|
||
}
|
||
|
||
void TestShellClient::testFullscreen()
|
||
{
|
||
// this test verifies that a window can be properly fullscreened
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
|
||
ShellSurface* wlShellSurface = nullptr;
|
||
XdgShellSurface *xdgShellSurface = nullptr;
|
||
// fullscreen the window
|
||
switch (type) {
|
||
case Test::ShellSurfaceType::WlShell:
|
||
wlShellSurface = qobject_cast<ShellSurface*>(shellSurface.data());
|
||
break;
|
||
case Test::ShellSurfaceType::XdgShellV5:
|
||
case Test::ShellSurfaceType::XdgShellV6:
|
||
case Test::ShellSurfaceType::XdgShellStable:
|
||
xdgShellSurface = qobject_cast<XdgShellSurface*>(shellSurface.data());
|
||
break;
|
||
default:
|
||
Q_UNREACHABLE();
|
||
break;
|
||
}
|
||
QVERIFY(wlShellSurface || xdgShellSurface);
|
||
QVERIFY(!(wlShellSurface && xdgShellSurface));
|
||
|
||
// create deco
|
||
QScopedPointer<ServerSideDecoration> deco(Test::waylandServerSideDecoration()->create(surface.data()));
|
||
QSignalSpy decoSpy(deco.data(), &ServerSideDecoration::modeChanged);
|
||
QVERIFY(decoSpy.isValid());
|
||
QVERIFY(decoSpy.wait());
|
||
QFETCH(ServerSideDecoration::Mode, decoMode);
|
||
deco->requestMode(decoMode);
|
||
QVERIFY(decoSpy.wait());
|
||
QCOMPARE(deco->mode(), decoMode);
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QCOMPARE(c->layer(), NormalLayer);
|
||
QVERIFY(!c->isFullScreen());
|
||
QCOMPARE(c->clientSize(), QSize(100, 50));
|
||
QCOMPARE(c->isDecorated(), decoMode == ServerSideDecoration::Mode::Server);
|
||
QCOMPARE(c->sizeForClientSize(c->clientSize()), c->geometry().size());
|
||
QSignalSpy fullscreenChangedSpy(c, &ShellClient::fullScreenChanged);
|
||
QVERIFY(fullscreenChangedSpy.isValid());
|
||
QSignalSpy geometryChangedSpy(c, &ShellClient::geometryChanged);
|
||
QVERIFY(geometryChangedSpy.isValid());
|
||
QSignalSpy sizeChangeRequestedSpy(shellSurface.data(), SIGNAL(sizeChanged(QSize)));
|
||
QVERIFY(sizeChangeRequestedSpy.isValid());
|
||
QSignalSpy configureRequestedSpy(shellSurface.data(), SIGNAL(configureRequested(QSize, KWayland::Client::XdgShellSurface::States, quint32)));
|
||
if (xdgShellSurface) {
|
||
QVERIFY(configureRequestedSpy.isValid());
|
||
}
|
||
|
||
if (wlShellSurface) {
|
||
wlShellSurface->setFullscreen();
|
||
}
|
||
if (xdgShellSurface) {
|
||
xdgShellSurface->setFullscreen(true);
|
||
}
|
||
|
||
QVERIFY(fullscreenChangedSpy.wait());
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
QCOMPARE(sizeChangeRequestedSpy.count(), 1);
|
||
QCOMPARE(sizeChangeRequestedSpy.first().first().toSize(), QSize(screens()->size(0)));
|
||
// TODO: should switch to fullscreen once it's updated
|
||
QVERIFY(c->isFullScreen());
|
||
QCOMPARE(c->clientSize(), QSize(100, 50));
|
||
QVERIFY(geometryChangedSpy.isEmpty());
|
||
|
||
if (xdgShellSurface) {
|
||
for (const auto &it: configureRequestedSpy) {
|
||
xdgShellSurface->ackConfigure(it[2].toInt());
|
||
}
|
||
}
|
||
|
||
Test::render(surface.data(), sizeChangeRequestedSpy.first().first().toSize(), Qt::red);
|
||
QVERIFY(geometryChangedSpy.wait());
|
||
QCOMPARE(geometryChangedSpy.count(), 1);
|
||
QVERIFY(c->isFullScreen());
|
||
QVERIFY(!c->isDecorated());
|
||
QCOMPARE(c->geometry(), QRect(QPoint(0, 0), sizeChangeRequestedSpy.first().first().toSize()));
|
||
QCOMPARE(c->layer(), ActiveLayer);
|
||
|
||
// swap back to normal
|
||
if (wlShellSurface) {
|
||
wlShellSurface->setToplevel();
|
||
}
|
||
if (xdgShellSurface) {
|
||
xdgShellSurface->setFullscreen(false);
|
||
}
|
||
QVERIFY(fullscreenChangedSpy.wait());
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
QCOMPARE(sizeChangeRequestedSpy.count(), 2);
|
||
QCOMPARE(sizeChangeRequestedSpy.last().first().toSize(), QSize(100, 50));
|
||
// TODO: should switch to fullscreen once it's updated
|
||
QVERIFY(!c->isFullScreen());
|
||
QCOMPARE(c->layer(), NormalLayer);
|
||
QCOMPARE(c->isDecorated(), decoMode == ServerSideDecoration::Mode::Server);
|
||
}
|
||
|
||
void TestShellClient::testUserCanSetFullscreen_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
QTest::addColumn<bool>("expected");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell << false;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5 << true;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6 << true;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable << true;
|
||
|
||
}
|
||
|
||
void TestShellClient::testUserCanSetFullscreen()
|
||
{
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QVERIFY(!c->isFullScreen());
|
||
QTEST(c->userCanSetFullScreen(), "expected");
|
||
}
|
||
|
||
void TestShellClient::testUserSetFullscreenWlShell()
|
||
{
|
||
// wlshell cannot sync fullscreen to the client
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<ShellSurface> shellSurface(Test::createShellSurface(surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QVERIFY(!c->isFullScreen());
|
||
QSignalSpy fullscreenChangedSpy(c, &AbstractClient::fullScreenChanged);
|
||
QVERIFY(fullscreenChangedSpy.isValid());
|
||
c->setFullScreen(true);
|
||
QCOMPARE(fullscreenChangedSpy.count(), 0);
|
||
QVERIFY(!c->isFullScreen());
|
||
}
|
||
|
||
void TestShellClient::testUserSetFullscreenXdgShell_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testUserSetFullscreenXdgShell()
|
||
{
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<XdgShellSurface> shellSurface(dynamic_cast<XdgShellSurface*>(Test::createShellSurface(type, surface.data())));
|
||
QVERIFY(!shellSurface.isNull());
|
||
QSignalSpy configureRequestedSpy(shellSurface.data(), &XdgShellSurface::configureRequested);
|
||
QVERIFY(configureRequestedSpy.isValid());
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QVERIFY(!c->isFullScreen());
|
||
|
||
// two, one for initial sync, second as it becomes active
|
||
QTRY_COMPARE(configureRequestedSpy.count(), 2);
|
||
|
||
QSignalSpy fullscreenChangedSpy(c, &AbstractClient::fullScreenChanged);
|
||
QVERIFY(fullscreenChangedSpy.isValid());
|
||
c->setFullScreen(true);
|
||
QCOMPARE(c->isFullScreen(), true);
|
||
configureRequestedSpy.clear();
|
||
QVERIFY(configureRequestedSpy.wait());
|
||
QCOMPARE(configureRequestedSpy.count(), 1);
|
||
QCOMPARE(configureRequestedSpy.first().at(0).toSize(), screens()->size(0));
|
||
const auto states = configureRequestedSpy.first().at(1).value<KWayland::Client::XdgShellSurface::States>();
|
||
QVERIFY(states.testFlag(KWayland::Client::XdgShellSurface::State::Fullscreen));
|
||
QVERIFY(states.testFlag(KWayland::Client::XdgShellSurface::State::Activated));
|
||
QVERIFY(!states.testFlag(KWayland::Client::XdgShellSurface::State::Maximized));
|
||
QVERIFY(!states.testFlag(KWayland::Client::XdgShellSurface::State::Resizing));
|
||
QCOMPARE(fullscreenChangedSpy.count(), 1);
|
||
QVERIFY(c->isFullScreen());
|
||
|
||
shellSurface->ackConfigure(configureRequestedSpy.first().at(2).value<quint32>());
|
||
|
||
// unset fullscreen again
|
||
c->setFullScreen(false);
|
||
QCOMPARE(c->isFullScreen(), false);
|
||
configureRequestedSpy.clear();
|
||
QVERIFY(configureRequestedSpy.wait());
|
||
QCOMPARE(configureRequestedSpy.count(), 1);
|
||
QCOMPARE(configureRequestedSpy.first().at(0).toSize(), QSize(100, 50));
|
||
QVERIFY(!configureRequestedSpy.first().at(1).value<KWayland::Client::XdgShellSurface::States>().testFlag(KWayland::Client::XdgShellSurface::State::Fullscreen));
|
||
QCOMPARE(fullscreenChangedSpy.count(), 2);
|
||
QVERIFY(!c->isFullScreen());
|
||
}
|
||
|
||
void TestShellClient::testMaximizedToFullscreen_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
QTest::addColumn<ServerSideDecoration::Mode>("decoMode");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell << ServerSideDecoration::Mode::Client;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5 << ServerSideDecoration::Mode::Client;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6 << ServerSideDecoration::Mode::Client;
|
||
QTest::newRow("xdgShellWmBase") << Test::ShellSurfaceType::XdgShellStable << ServerSideDecoration::Mode::Client;
|
||
|
||
QTest::newRow("wlShell - deco") << Test::ShellSurfaceType::WlShell << ServerSideDecoration::Mode::Server;
|
||
QTest::newRow("xdgShellV5 - deco") << Test::ShellSurfaceType::XdgShellV5 << ServerSideDecoration::Mode::Server;
|
||
QTest::newRow("xdgShellV6 - deco") << Test::ShellSurfaceType::XdgShellV6 << ServerSideDecoration::Mode::Server;
|
||
QTest::newRow("xdgShellWmBase - deco") << Test::ShellSurfaceType::XdgShellStable << ServerSideDecoration::Mode::Server;
|
||
}
|
||
|
||
void TestShellClient::testMaximizedToFullscreen()
|
||
{
|
||
// this test verifies that a window can be properly fullscreened after maximizing
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
|
||
ShellSurface* wlShellSurface = nullptr;
|
||
XdgShellSurface *xdgShellSurface = nullptr;
|
||
// fullscreen the window
|
||
switch (type) {
|
||
case Test::ShellSurfaceType::WlShell:
|
||
wlShellSurface = qobject_cast<ShellSurface*>(shellSurface.data());
|
||
break;
|
||
case Test::ShellSurfaceType::XdgShellV5:
|
||
case Test::ShellSurfaceType::XdgShellV6:
|
||
case Test::ShellSurfaceType::XdgShellStable:
|
||
xdgShellSurface = qobject_cast<XdgShellSurface*>(shellSurface.data());
|
||
break;
|
||
default:
|
||
Q_UNREACHABLE();
|
||
break;
|
||
}
|
||
QVERIFY(wlShellSurface || xdgShellSurface);
|
||
QVERIFY(!(wlShellSurface && xdgShellSurface));
|
||
|
||
// create deco
|
||
QScopedPointer<ServerSideDecoration> deco(Test::waylandServerSideDecoration()->create(surface.data()));
|
||
QSignalSpy decoSpy(deco.data(), &ServerSideDecoration::modeChanged);
|
||
QVERIFY(decoSpy.isValid());
|
||
QVERIFY(decoSpy.wait());
|
||
QFETCH(ServerSideDecoration::Mode, decoMode);
|
||
deco->requestMode(decoMode);
|
||
QVERIFY(decoSpy.wait());
|
||
QCOMPARE(deco->mode(), decoMode);
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QVERIFY(!c->isFullScreen());
|
||
QCOMPARE(c->clientSize(), QSize(100, 50));
|
||
QCOMPARE(c->isDecorated(), decoMode == ServerSideDecoration::Mode::Server);
|
||
QSignalSpy fullscreenChangedSpy(c, &ShellClient::fullScreenChanged);
|
||
QVERIFY(fullscreenChangedSpy.isValid());
|
||
QSignalSpy geometryChangedSpy(c, &ShellClient::geometryChanged);
|
||
QVERIFY(geometryChangedSpy.isValid());
|
||
QSignalSpy sizeChangeRequestedSpy(shellSurface.data(), SIGNAL(sizeChanged(QSize)));
|
||
QVERIFY(sizeChangeRequestedSpy.isValid());
|
||
QSignalSpy configureRequestedSpy(shellSurface.data(), SIGNAL(configureRequested(QSize, KWayland::Client::XdgShellSurface::States, quint32)));
|
||
if (xdgShellSurface) {
|
||
QVERIFY(configureRequestedSpy.isValid());
|
||
}
|
||
|
||
// change to maximize
|
||
if (wlShellSurface) {
|
||
wlShellSurface->setMaximized();
|
||
}
|
||
if (xdgShellSurface) {
|
||
xdgShellSurface->setMaximized(true);
|
||
}
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
QCOMPARE(sizeChangeRequestedSpy.count(), 1);
|
||
|
||
if (xdgShellSurface) {
|
||
for (const auto &it: configureRequestedSpy) {
|
||
xdgShellSurface->ackConfigure(it[2].toInt());
|
||
}
|
||
}
|
||
Test::render(surface.data(), sizeChangeRequestedSpy.last().first().toSize(), Qt::red);
|
||
QVERIFY(geometryChangedSpy.wait());
|
||
|
||
QCOMPARE(c->maximizeMode(), MaximizeFull);
|
||
QCOMPARE(geometryChangedSpy.isEmpty(), false);
|
||
geometryChangedSpy.clear();
|
||
|
||
// fullscreen the window
|
||
if (wlShellSurface) {
|
||
wlShellSurface->setFullscreen();
|
||
}
|
||
if (xdgShellSurface) {
|
||
xdgShellSurface->setFullscreen(true);
|
||
}
|
||
QVERIFY(fullscreenChangedSpy.wait());
|
||
if (decoMode == ServerSideDecoration::Mode::Server) {
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
QCOMPARE(sizeChangeRequestedSpy.count(), 2);
|
||
}
|
||
QCOMPARE(sizeChangeRequestedSpy.last().first().toSize(), QSize(screens()->size(0)));
|
||
// TODO: should switch to fullscreen once it's updated
|
||
QVERIFY(c->isFullScreen());
|
||
|
||
if (xdgShellSurface) {
|
||
for (const auto &it: configureRequestedSpy) {
|
||
xdgShellSurface->ackConfigure(it[2].toInt());
|
||
}
|
||
}
|
||
// render at the new size
|
||
Test::render(surface.data(), sizeChangeRequestedSpy.last().first().toSize(), Qt::red);
|
||
|
||
QVERIFY(c->isFullScreen());
|
||
QVERIFY(!c->isDecorated());
|
||
QCOMPARE(c->geometry(), QRect(QPoint(0, 0), sizeChangeRequestedSpy.last().first().toSize()));
|
||
sizeChangeRequestedSpy.clear();
|
||
|
||
// swap back to normal
|
||
switch (type) {
|
||
case Test::ShellSurfaceType::WlShell:
|
||
qobject_cast<ShellSurface*>(shellSurface.data())->setToplevel();
|
||
break;
|
||
case Test::ShellSurfaceType::XdgShellV5:
|
||
case Test::ShellSurfaceType::XdgShellV6:
|
||
case Test::ShellSurfaceType::XdgShellStable:
|
||
qobject_cast<XdgShellSurface*>(shellSurface.data())->setFullscreen(false);
|
||
qobject_cast<XdgShellSurface*>(shellSurface.data())->setMaximized(false);
|
||
break;
|
||
}
|
||
QVERIFY(fullscreenChangedSpy.wait());
|
||
if (decoMode == ServerSideDecoration::Mode::Server) {
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
// XDG will legitimately get two updates. They might be batched
|
||
if (xdgShellSurface && sizeChangeRequestedSpy.count() == 1) {
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
}
|
||
|
||
// fails as we don't correctly call setMaximize(false)
|
||
// but realistically the only toolkits that support the deco also use XDGShell
|
||
QEXPECT_FAIL("wlShell - deco", "With decoration incorrect geometry requested", Continue);
|
||
|
||
QCOMPARE(sizeChangeRequestedSpy.last().first().toSize(), QSize(100, 50));
|
||
}
|
||
// TODO: should switch to fullscreen once it's updated
|
||
QVERIFY(!c->isFullScreen());
|
||
QCOMPARE(c->isDecorated(), decoMode == ServerSideDecoration::Mode::Server);
|
||
}
|
||
|
||
void TestShellClient::testWindowOpensLargerThanScreen_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testWindowOpensLargerThanScreen()
|
||
{
|
||
// this test creates a window which is as large as the screen, but is decorated
|
||
// the window should get resized to fit into the screen, BUG: 366632
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
QSignalSpy sizeChangeRequestedSpy(shellSurface.data(), SIGNAL(sizeChanged(QSize)));
|
||
QVERIFY(sizeChangeRequestedSpy.isValid());
|
||
|
||
// create deco
|
||
QScopedPointer<ServerSideDecoration> deco(Test::waylandServerSideDecoration()->create(surface.data()));
|
||
QSignalSpy decoSpy(deco.data(), &ServerSideDecoration::modeChanged);
|
||
QVERIFY(decoSpy.isValid());
|
||
QVERIFY(decoSpy.wait());
|
||
deco->requestMode(ServerSideDecoration::Mode::Server);
|
||
QVERIFY(decoSpy.wait());
|
||
QCOMPARE(deco->mode(), ServerSideDecoration::Mode::Server);
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), screens()->size(0), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QCOMPARE(c->clientSize(), screens()->size(0));
|
||
QVERIFY(c->isDecorated());
|
||
QEXPECT_FAIL("", "BUG 366632", Continue);
|
||
QVERIFY(sizeChangeRequestedSpy.wait());
|
||
}
|
||
|
||
void TestShellClient::testHidden_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testHidden()
|
||
{
|
||
// this test verifies that when hiding window it doesn't get shown
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->isActive());
|
||
QCOMPARE(workspace()->activeClient(), c);
|
||
QVERIFY(c->wantsInput());
|
||
QVERIFY(c->wantsTabFocus());
|
||
QVERIFY(c->isShown(true));
|
||
|
||
c->hideClient(true);
|
||
QVERIFY(!c->isShown(true));
|
||
QVERIFY(!c->isActive());
|
||
QVERIFY(c->wantsInput());
|
||
QVERIFY(c->wantsTabFocus());
|
||
|
||
// unhide again
|
||
c->hideClient(false);
|
||
QVERIFY(c->isShown(true));
|
||
QVERIFY(c->wantsInput());
|
||
QVERIFY(c->wantsTabFocus());
|
||
|
||
//QCOMPARE(workspace()->activeClient(), c);
|
||
}
|
||
|
||
void TestShellClient::testDesktopFileName()
|
||
{
|
||
QIcon::setThemeName(QStringLiteral("breeze"));
|
||
// this test verifies that desktop file name is passed correctly to the window
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
// only xdg-shell as ShellSurface misses the setter
|
||
QScopedPointer<XdgShellSurface> shellSurface(qobject_cast<XdgShellSurface*>(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV5, surface.data())));
|
||
shellSurface->setAppId(QByteArrayLiteral("org.kde.foo"));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QCOMPARE(c->desktopFileName(), QByteArrayLiteral("org.kde.foo"));
|
||
QCOMPARE(c->resourceClass(), QByteArrayLiteral("org.kde.foo"));
|
||
QVERIFY(c->resourceName().startsWith("testShellClient"));
|
||
// the desktop file does not exist, so icon should be generic Wayland
|
||
QCOMPARE(c->icon().name(), QStringLiteral("wayland"));
|
||
|
||
QSignalSpy desktopFileNameChangedSpy(c, &AbstractClient::desktopFileNameChanged);
|
||
QVERIFY(desktopFileNameChangedSpy.isValid());
|
||
QSignalSpy iconChangedSpy(c, &ShellClient::iconChanged);
|
||
QVERIFY(iconChangedSpy.isValid());
|
||
shellSurface->setAppId(QByteArrayLiteral("org.kde.bar"));
|
||
QVERIFY(desktopFileNameChangedSpy.wait());
|
||
QCOMPARE(c->desktopFileName(), QByteArrayLiteral("org.kde.bar"));
|
||
QCOMPARE(c->resourceClass(), QByteArrayLiteral("org.kde.bar"));
|
||
QVERIFY(c->resourceName().startsWith("testShellClient"));
|
||
// icon should still be wayland
|
||
QCOMPARE(c->icon().name(), QStringLiteral("wayland"));
|
||
QVERIFY(iconChangedSpy.isEmpty());
|
||
|
||
const QString dfPath = QFINDTESTDATA("data/example.desktop");
|
||
shellSurface->setAppId(dfPath.toUtf8());
|
||
QVERIFY(desktopFileNameChangedSpy.wait());
|
||
QCOMPARE(iconChangedSpy.count(), 1);
|
||
QCOMPARE(QString::fromUtf8(c->desktopFileName()), dfPath);
|
||
QCOMPARE(c->icon().name(), QStringLiteral("kwin"));
|
||
}
|
||
|
||
void TestShellClient::testCaptionSimplified()
|
||
{
|
||
// this test verifies that caption is properly trimmed
|
||
// see BUG 323798 comment #12
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
// only done for xdg-shell as ShellSurface misses the setter
|
||
QScopedPointer<XdgShellSurface> shellSurface(qobject_cast<XdgShellSurface*>(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV5, surface.data())));
|
||
const QString origTitle = QString::fromUtf8(QByteArrayLiteral("Was tun, wenn Schüler Autismus haben?\342\200\250\342\200\250\342\200\250 – Marlies Hübner - Mozilla Firefox"));
|
||
shellSurface->setTitle(origTitle);
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->caption() != origTitle);
|
||
QCOMPARE(c->caption(), origTitle.simplified());
|
||
}
|
||
|
||
void TestShellClient::testCaptionMultipleWindows()
|
||
{
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface(qobject_cast<XdgShellSurface*>(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV5, surface.data())));
|
||
shellSurface->setTitle(QStringLiteral("foo"));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QCOMPARE(c->caption(), QStringLiteral("foo"));
|
||
QCOMPARE(c->captionNormal(), QStringLiteral("foo"));
|
||
QCOMPARE(c->captionSuffix(), QString());
|
||
|
||
QScopedPointer<Surface> surface2(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface2(qobject_cast<XdgShellSurface*>(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV5, surface2.data())));
|
||
shellSurface2->setTitle(QStringLiteral("foo"));
|
||
auto c2 = Test::renderAndWaitForShown(surface2.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c2);
|
||
QCOMPARE(c2->caption(), QStringLiteral("foo <2>"));
|
||
QCOMPARE(c2->captionNormal(), QStringLiteral("foo"));
|
||
QCOMPARE(c2->captionSuffix(), QStringLiteral(" <2>"));
|
||
|
||
QScopedPointer<Surface> surface3(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface3(qobject_cast<XdgShellSurface*>(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV5, surface3.data())));
|
||
shellSurface3->setTitle(QStringLiteral("foo"));
|
||
auto c3 = Test::renderAndWaitForShown(surface3.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c3);
|
||
QCOMPARE(c3->caption(), QStringLiteral("foo <3>"));
|
||
QCOMPARE(c3->captionNormal(), QStringLiteral("foo"));
|
||
QCOMPARE(c3->captionSuffix(), QStringLiteral(" <3>"));
|
||
|
||
QScopedPointer<Surface> surface4(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface4(qobject_cast<XdgShellSurface*>(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV5, surface4.data())));
|
||
shellSurface4->setTitle(QStringLiteral("bar"));
|
||
auto c4 = Test::renderAndWaitForShown(surface4.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c4);
|
||
QCOMPARE(c4->caption(), QStringLiteral("bar"));
|
||
QCOMPARE(c4->captionNormal(), QStringLiteral("bar"));
|
||
QCOMPARE(c4->captionSuffix(), QString());
|
||
QSignalSpy captionChangedSpy(c4, &ShellClient::captionChanged);
|
||
QVERIFY(captionChangedSpy.isValid());
|
||
shellSurface4->setTitle(QStringLiteral("foo"));
|
||
QVERIFY(captionChangedSpy.wait());
|
||
QCOMPARE(captionChangedSpy.count(), 1);
|
||
QCOMPARE(c4->caption(), QStringLiteral("foo <4>"));
|
||
QCOMPARE(c4->captionNormal(), QStringLiteral("foo"));
|
||
QCOMPARE(c4->captionSuffix(), QStringLiteral(" <4>"));
|
||
}
|
||
|
||
void TestShellClient::testUnresponsiveWindow_data()
|
||
{
|
||
QTest::addColumn<QString>("shellInterface");//see env selection in qwaylandintegration.cpp
|
||
QTest::addColumn<bool>("socketMode");
|
||
|
||
//wl-shell ping is not implemented
|
||
//QTest::newRow("wl-shell display") << "wl-shell" << false;
|
||
//QTest::newRow("wl-shell socket") << "wl-shell" << true;
|
||
QTest::newRow("xdgv5 display") << "xdg-shell-v5" << false;
|
||
QTest::newRow("xdgv5 socket") << "xdg-shell-v5" << true;
|
||
QTest::newRow("xdgv6 display") << "xdg-shell-v6" << false;
|
||
QTest::newRow("xdgv6 socket") << "xdg-shell-v6" << true;
|
||
|
||
//TODO add XDG WM Base when Kwin relies on Qt 5.12
|
||
}
|
||
|
||
void TestShellClient::testUnresponsiveWindow()
|
||
{
|
||
// this test verifies that killWindow properly terminates a process
|
||
// for this an external binary is launched
|
||
const QString kill = QFINDTESTDATA(QStringLiteral("kill"));
|
||
QVERIFY(!kill.isEmpty());
|
||
QSignalSpy shellClientAddedSpy(waylandServer(), &WaylandServer::shellClientAdded);
|
||
QVERIFY(shellClientAddedSpy.isValid());
|
||
|
||
QScopedPointer<QProcess> process(new QProcess);
|
||
QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
|
||
|
||
QFETCH(QString, shellInterface);
|
||
QFETCH(bool, socketMode);
|
||
env.insert("QT_WAYLAND_SHELL_INTEGRATION", shellInterface);
|
||
if (socketMode) {
|
||
int sx[2];
|
||
QVERIFY(socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, sx) >= 0);
|
||
waylandServer()->display()->createClient(sx[0]);
|
||
int socket = dup(sx[1]);
|
||
QVERIFY(socket != -1);
|
||
env.insert(QStringLiteral("WAYLAND_SOCKET"), QByteArray::number(socket));
|
||
env.remove("WAYLAND_DISPLAY");
|
||
} else {
|
||
env.insert("WAYLAND_DISPLAY", s_socketName);
|
||
}
|
||
process->setProcessEnvironment(env);
|
||
process->setProcessChannelMode(QProcess::ForwardedChannels);
|
||
process->setProgram(kill);
|
||
QSignalSpy processStartedSpy{process.data(), &QProcess::started};
|
||
QVERIFY(processStartedSpy.isValid());
|
||
process->start();
|
||
QVERIFY(processStartedSpy.wait());
|
||
|
||
AbstractClient *killClient = nullptr;
|
||
if (shellClientAddedSpy.isEmpty()) {
|
||
QVERIFY(shellClientAddedSpy.wait());
|
||
}
|
||
killClient = shellClientAddedSpy.first().first().value<AbstractClient*>();
|
||
QSignalSpy unresponsiveSpy(killClient, &AbstractClient::unresponsiveChanged);
|
||
QSignalSpy killedSpy(process.data(), static_cast<void(QProcess::*)(int,QProcess::ExitStatus)>(&QProcess::finished));
|
||
QSignalSpy deletedSpy(killClient, &QObject::destroyed);
|
||
|
||
qint64 startTime = QDateTime::currentMSecsSinceEpoch();
|
||
|
||
//wait for the process to be frozen
|
||
QTest::qWait(10);
|
||
|
||
//pretend the user clicked the close button
|
||
killClient->closeWindow();
|
||
|
||
//client should not yet be marked unresponsive nor killed
|
||
QVERIFY(!killClient->unresponsive());
|
||
QVERIFY(killedSpy.isEmpty());
|
||
|
||
QVERIFY(unresponsiveSpy.wait());
|
||
//client should be marked unresponsive but not killed
|
||
auto elapsed1 = QDateTime::currentMSecsSinceEpoch() - startTime;
|
||
QVERIFY(elapsed1 > 900 && elapsed1 < 1200); //ping timer is 1s, but coarse timers on a test across two processes means we need a fuzzy compare
|
||
QVERIFY(killClient->unresponsive());
|
||
QVERIFY(killedSpy.isEmpty());
|
||
|
||
QVERIFY(deletedSpy.wait());
|
||
if (!socketMode) {
|
||
//process was killed - because we're across process this could happen in either order
|
||
QVERIFY(killedSpy.count() || killedSpy.wait());
|
||
}
|
||
|
||
auto elapsed2 = QDateTime::currentMSecsSinceEpoch() - startTime;
|
||
QVERIFY(elapsed2 > 1800); //second ping comes in a second later
|
||
}
|
||
|
||
void TestShellClient::testX11WindowId_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testX11WindowId()
|
||
{
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(c->windowId() != 0);
|
||
QCOMPARE(c->window(), 0u);
|
||
}
|
||
|
||
void TestShellClient::testAppMenu()
|
||
{
|
||
//register a faux appmenu client
|
||
QVERIFY (QDBusConnection::sessionBus().registerService("org.kde.kappmenu"));
|
||
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(Test::ShellSurfaceType::XdgShellV6, surface.data()));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QScopedPointer<AppMenu> menu(Test::waylandAppMenuManager()->create(surface.data()));
|
||
QSignalSpy spy(c, &ShellClient::hasApplicationMenuChanged);
|
||
menu->setAddress("service.name", "object/path");
|
||
spy.wait();
|
||
QCOMPARE(c->hasApplicationMenu(), true);
|
||
QCOMPARE(c->applicationMenuServiceName(), QString("service.name"));
|
||
QCOMPARE(c->applicationMenuObjectPath(), QString("object/path"));
|
||
|
||
QVERIFY (QDBusConnection::sessionBus().unregisterService("org.kde.kappmenu"));
|
||
}
|
||
|
||
void TestShellClient::testNoDecorationModeRequested_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("wlShell") << Test::ShellSurfaceType::WlShell;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testNoDecorationModeRequested()
|
||
{
|
||
// this test verifies that the decoration follows the default mode if no mode is explicitly requested
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<QObject> shellSurface(Test::createShellSurface(type, surface.data()));
|
||
QScopedPointer<ServerSideDecoration> deco(Test::waylandServerSideDecoration()->create(surface.data()));
|
||
QSignalSpy decoSpy(deco.data(), &ServerSideDecoration::modeChanged);
|
||
QVERIFY(decoSpy.isValid());
|
||
if (deco->mode() != ServerSideDecoration::Mode::Server) {
|
||
QVERIFY(decoSpy.wait());
|
||
}
|
||
QCOMPARE(deco->mode(), ServerSideDecoration::Mode::Server);
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QCOMPARE(c->noBorder(), false);
|
||
QCOMPARE(c->isDecorated(), true);
|
||
}
|
||
|
||
void TestShellClient::testSendClientWithTransientToDesktop_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testSendClientWithTransientToDesktop()
|
||
{
|
||
// this test verifies that when sending a client to a desktop all transients are also send to that desktop
|
||
|
||
VirtualDesktopManager::self()->setCount(2);
|
||
QScopedPointer<Surface> surface{Test::createSurface()};
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<XdgShellSurface> shellSurface{qobject_cast<XdgShellSurface*>(Test::createShellSurface(type, surface.data()))};
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
|
||
// let's create a transient window
|
||
QScopedPointer<Surface> transientSurface{Test::createSurface()};
|
||
QScopedPointer<XdgShellSurface> transientShellSurface{qobject_cast<XdgShellSurface*>(Test::createShellSurface(type, transientSurface.data()))};
|
||
transientShellSurface->setTransientFor(shellSurface.data());
|
||
|
||
auto transient = Test::renderAndWaitForShown(transientSurface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(transient);
|
||
QCOMPARE(workspace()->activeClient(), transient);
|
||
QCOMPARE(transient->transientFor(), c);
|
||
QVERIFY(c->transients().contains(transient));
|
||
|
||
QCOMPARE(c->desktop(), 1);
|
||
QVERIFY(!c->isOnAllDesktops());
|
||
QCOMPARE(transient->desktop(), 1);
|
||
QVERIFY(!transient->isOnAllDesktops());
|
||
workspace()->slotWindowToDesktop(2);
|
||
|
||
QCOMPARE(c->desktop(), 1);
|
||
QCOMPARE(transient->desktop(), 2);
|
||
|
||
// activate c
|
||
workspace()->activateClient(c);
|
||
QCOMPARE(workspace()->activeClient(), c);
|
||
QVERIFY(c->isActive());
|
||
|
||
// and send it to the desktop it's already on
|
||
QCOMPARE(c->desktop(), 1);
|
||
QCOMPARE(transient->desktop(), 2);
|
||
workspace()->slotWindowToDesktop(1);
|
||
|
||
// which should move the transient back to the desktop
|
||
QCOMPARE(c->desktop(), 1);
|
||
QCOMPARE(transient->desktop(), 1);
|
||
}
|
||
|
||
void TestShellClient::testMinimizeWindowWithTransients_data()
|
||
{
|
||
QTest::addColumn<Test::ShellSurfaceType>("type");
|
||
|
||
QTest::newRow("xdgShellV5") << Test::ShellSurfaceType::XdgShellV5;
|
||
QTest::newRow("xdgShellV6") << Test::ShellSurfaceType::XdgShellV6;
|
||
QTest::newRow("xdgWmBase") << Test::ShellSurfaceType::XdgShellStable;
|
||
}
|
||
|
||
void TestShellClient::testMinimizeWindowWithTransients()
|
||
{
|
||
// this test verifies that when minimizing/unminimizing a window all its
|
||
// transients will be minimized/unminimized as well
|
||
|
||
// create the main window
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QFETCH(Test::ShellSurfaceType, type);
|
||
QScopedPointer<XdgShellSurface> shellSurface(qobject_cast<XdgShellSurface *>(
|
||
Test::createShellSurface(type, surface.data())));
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(c);
|
||
QVERIFY(!c->isMinimized());
|
||
|
||
// create a transient window
|
||
QScopedPointer<Surface> transientSurface(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> transientShellSurface(qobject_cast<XdgShellSurface *>(
|
||
Test::createShellSurface(type, transientSurface.data())));
|
||
transientShellSurface->setTransientFor(shellSurface.data());
|
||
auto transient = Test::renderAndWaitForShown(transientSurface.data(), QSize(100, 50), Qt::red);
|
||
QVERIFY(transient);
|
||
QVERIFY(!transient->isMinimized());
|
||
QCOMPARE(transient->transientFor(), c);
|
||
QVERIFY(c->hasTransient(transient, false));
|
||
|
||
// minimize the main window, the transient should be minimized as well
|
||
c->minimize();
|
||
QVERIFY(c->isMinimized());
|
||
QVERIFY(transient->isMinimized());
|
||
|
||
// unminimize the main window, the transient should be unminimized as well
|
||
c->unminimize();
|
||
QVERIFY(!c->isMinimized());
|
||
QVERIFY(!transient->isMinimized());
|
||
}
|
||
|
||
void TestShellClient::testXdgDecoration_data()
|
||
{
|
||
QTest::addColumn<KWayland::Client::XdgDecoration::Mode>("requestedMode");
|
||
QTest::addColumn<KWayland::Client::XdgDecoration::Mode>("expectedMode");
|
||
|
||
QTest::newRow("client side requested") << XdgDecoration::Mode::ClientSide << XdgDecoration::Mode::ClientSide;
|
||
QTest::newRow("server side requested") << XdgDecoration::Mode::ServerSide << XdgDecoration::Mode::ServerSide;
|
||
}
|
||
|
||
void TestShellClient::testXdgDecoration()
|
||
{
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
|
||
QScopedPointer<XdgDecoration> deco(Test::xdgDecorationManager()->getToplevelDecoration(shellSurface.data()));
|
||
|
||
QSignalSpy decorationConfiguredSpy(deco.data(), &XdgDecoration::modeChanged);
|
||
QSignalSpy configureRequestedSpy(shellSurface.data(), &XdgShellSurface::configureRequested);
|
||
|
||
QFETCH(KWayland::Client::XdgDecoration::Mode, requestedMode);
|
||
QFETCH(KWayland::Client::XdgDecoration::Mode, expectedMode);
|
||
|
||
//request a mode
|
||
deco->setMode(requestedMode);
|
||
|
||
//kwin will send a configure
|
||
decorationConfiguredSpy.wait();
|
||
configureRequestedSpy.wait();
|
||
|
||
QCOMPARE(decorationConfiguredSpy.count(), 1);
|
||
QCOMPARE(decorationConfiguredSpy.first()[0].value<KWayland::Client::XdgDecoration::Mode>(), expectedMode);
|
||
QVERIFY(configureRequestedSpy.count() > 0);
|
||
|
||
shellSurface->ackConfigure(configureRequestedSpy.last()[2].toInt());
|
||
|
||
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QCOMPARE(c->userCanSetNoBorder(), expectedMode == XdgDecoration::Mode::ServerSide);
|
||
QCOMPARE(c->isDecorated(), expectedMode == XdgDecoration::Mode::ServerSide);
|
||
}
|
||
|
||
WAYLANDTEST_MAIN(TestShellClient)
|
||
#include "shell_client_test.moc"
|