57f8c6d5f8
Theory: ---------- because PresentWindowsEffect::screenCountChanged() is shortcut for "if (!isActive())", but the desktopgrid doesn't call PresentWindowsEffect::setActive (or at least PresentWindowsEffect::screenCountChanged), so the effect can "miss" the increasing screen count change (it sees the signal, but ignores it) and when desktopgrid calls it, it assumes the m_gridSizes array is big enough (but it isn't) Steps: ---------- 1. effects are loaded, 1 screen present 2. 2nd screen gets added, but inactive effects ignore that 3. desktop grid gets activated, updates according to screen count, calls presentwindows for screen #2 4. presentwindows data is only prepared for one screen from step 1 => BOOM BUG: 351724 CCBUG: 326032 FIXED-IN: 5.4.2 REVIEW: 124960
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2009 Lucas Murray <lmurray@undefinedfire.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#include "presentwindows_proxy.h"
|
|
#include "presentwindows.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
PresentWindowsEffectProxy::PresentWindowsEffectProxy(PresentWindowsEffect* effect)
|
|
: m_effect(effect)
|
|
{
|
|
}
|
|
|
|
PresentWindowsEffectProxy::~PresentWindowsEffectProxy()
|
|
{
|
|
}
|
|
|
|
void PresentWindowsEffectProxy::calculateWindowTransformations(EffectWindowList windows, int screen,
|
|
WindowMotionManager& manager)
|
|
{
|
|
return m_effect->calculateWindowTransformations(windows, screen, manager, true);
|
|
}
|
|
|
|
void PresentWindowsEffectProxy::reCreateGrids()
|
|
{
|
|
m_effect->reCreateGrids();
|
|
}
|
|
|
|
} // namespace
|