My KWIN fork where I work on features like per-output virtual desktops
Find a file
Vlad Zahorodnii 13e7cac019 Handle wl_surface destruction in SurfaceCursorSource
Wine/Wayland hides the cursor as follows:

[ 853107.473]  -> wl_pointer@15.set_cursor(172832, wl_surface@38, 0, 0)
...
[ 858989.757]  -> wl_surface@38.destroy()
[ 858989.759]  -> wl_pointer@15.set_cursor(172832, nil, 0, 0)

i.e. it destroys the cursor surface, then calls wl_pointer.set_cursor().

SurfaceCursorSource stores the wl_surface in a QPointer, furthermore it
is going to emit the changed signal, which is needed to force the
CursorItem to update its content, only if either a new hotspot or a
surface has been passed to SurfaceCursorSource::update(). So what happens
is the following:

- The SurfaceInterface object is destroyed and the QPointer resets its
  value to nullptr
- SurfaceCursorSource::update(nullptr, QPointF(0, 0)) gets called in
  response to wl_pointer@15.set_cursor(nil, 0, 0)
- but since m_surface has been implicitly reset to nullptr, no changed
  signal is going to be emitted

This change addresses the issue by making the SurfaceCursorSource track
the SurfaceInterface's destroyed signal.

BUG: 480582
2024-02-09 13:53:04 +02:00
autotests autotests: Use ShapeCursorSource to load reference cursor images in testPointerInput 2024-02-07 08:46:20 +00:00
cmake/modules Drop Qt6WaylandClientMacros.cmake fork 2023-04-23 18:18:34 +00:00
data Remove unneeded includes from headers and cpp files 2024-01-13 11:34:45 +01:00
doc Port usage of kcmshell5 to kcmshell6 2023-05-05 09:22:55 +00:00
examples/quick-effect SVN_SILENT made messages (.desktop file) - always resolve ours 2024-01-31 01:13:52 +00:00
kconf_update kconf_update: Drop kwin-6.0-overview-activities-shortcuts script 2024-02-08 13:48:42 +00:00
LICENSES Remove unused license file 2022-08-23 17:41:55 +02:00
po GIT_SILENT Sync po/docbooks with svn 2024-02-09 01:25:27 +00:00
src Handle wl_surface destruction in SurfaceCursorSource 2024-02-09 13:53:04 +02:00
tests tests: Fix constraint region in pointerconstraints example 2024-01-24 10:23:45 +02:00
.clang-format Run clang-format 2022-03-25 13:25:15 +02:00
.gitignore Run clang-format 2022-03-25 13:25:15 +02:00
.gitlab-ci.yml Allow building KWin without KGlobalAccel 2023-11-27 17:07:28 +01:00
.kde-ci.yml ci: Add plasma-workspace to RuntimeDependencies 2023-12-21 10:40:41 +00:00
CMakeLists.txt Revert "systemd: Set up a watchdog" 2024-02-05 12:54:47 +02:00
CONTRIBUTING.md Fix link to Frameworks Coding Style in CONTRIBUTING 2024-01-14 21:15:26 +00:00
KWinDBusInterfaceConfig.cmake.in plugins/nightcolor: Rename d-bus interface 2024-02-08 14:24:51 +00:00
logo.png
Mainpage.dox
plasma-kwin_wayland.service.in Revert "systemd: Set up a watchdog" 2024-02-05 12:54:47 +02:00
plasma-kwin_x11.service.in
README.md

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contributing to KWin

Please refer to the contributing document for everything you need to know to get started contributing to KWin.

Contacting KWin development team

  • mailing list: kwin@kde.org
  • IRC: #kde-kwin on irc.libera.chat

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.