1d71292e13
Summary: This call is added for the window rules kcm which has a detect functionality. As that detect functionality cannot query any Wayland windows we need to have some functionality in KWin core. Furthermore this allows to simplify the code in the kcm as all the custom X11 interaction can be removed. KWin internally has the functionality to find a window at a given position. From a security perspective adding this dbus method is fine as the user stays in control of the functionality. It requires active click to select a window. The new dbus call is already used in the rules kcm replacing the X11 based detect functionality. That a detect is now able to get information for both X11 and Wayland windows. So far only X11 windows on X11 were supported. So this fills an important gap in the Wayland offerings. It should now be possible to create rules for Wayland windows (though may not be fully functional). Test Plan: Run the kwin_rules_dialog and it detected the window correctly Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D10490
83 lines
2.1 KiB
C++
83 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2004 Lubos Lunak <l.lunak@kde.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
|
|
#ifndef __DETECTWIDGET_H__
|
|
#define __DETECTWIDGET_H__
|
|
|
|
#include <QDialog>
|
|
#include <kwindowsystem.h>
|
|
|
|
#include "../../rules.h"
|
|
//Added by qt3to4:
|
|
#include <QEvent>
|
|
#include <QByteArray>
|
|
|
|
#include "ui_detectwidget.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class DetectWidget
|
|
: public QWidget, public Ui_DetectWidget
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit DetectWidget(QWidget* parent = nullptr);
|
|
};
|
|
|
|
class DetectDialog
|
|
: public QDialog
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit DetectDialog(QWidget* parent = nullptr, const char* name = nullptr);
|
|
void detect(int secs = 0);
|
|
QByteArray selectedClass() const;
|
|
bool selectedWholeClass() const;
|
|
QByteArray selectedRole() const;
|
|
bool selectedWholeApp() const;
|
|
NET::WindowType selectedType() const;
|
|
QString selectedTitle() const;
|
|
Rules::StringMatch titleMatch() const;
|
|
QByteArray selectedMachine() const;
|
|
|
|
const QVariantMap &windowInfo() const {
|
|
return m_windowInfo;
|
|
}
|
|
|
|
Q_SIGNALS:
|
|
void detectionDone(bool);
|
|
private Q_SLOTS:
|
|
void selectWindow();
|
|
private:
|
|
void executeDialog();
|
|
QByteArray wmclass_class;
|
|
QByteArray wmclass_name;
|
|
QByteArray role;
|
|
NET::WindowType type;
|
|
QString title;
|
|
QByteArray extrarole;
|
|
QByteArray machine;
|
|
DetectWidget* widget;
|
|
QVariantMap m_windowInfo;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
#endif
|