996ee34e14
Summary: Rational: unredirect fullscreen windows is a weird beast. It's intended to make fullscreen windows "faster" by not compositing that screen. But that doesn't really work as KWin jumps out of that condition pretty quickly. E.g. whenever a tooltip window is shown. KWin itself has a better functionality by supporting to block compositing completely. The complete code was full of hacks around it to try to ensure that things don't break. Overall unredirect fullscreen has always been the odd one. We had it because a compositor needs to have it, but it never got truly integrated. E.g. effects don't interact with it properly so that some things randomly work, others don't. Will it trigger the screenedge, probably yes, but will it show the highlight: properly no. By removing the functionality we finally acknowledge that this mode is not maintained and has not been maintained for years and that we do not intend to support it better in future. Over the years we tried to make it more and more hidden: it's disabled for Intel GPUs, because it used to crash KWin. It's marked as an "expert" option, etc. It's clearly something we tried to hide from the user that it exists. For Wayland the whole unredirect infrastructure doesn't make sense either. There is no such thing as "unredirecting". We might make use of passing buffers directly to the underlying stack, but that will be done automatically when we know it can be done, not by some magic is this a window of specific size. Test Plan: Compiles, cannot really test as I am an Intel user who never had that working. Reviewers: #kwin, #plasma, #vdg Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2180
175 lines
6.3 KiB
C++
175 lines
6.3 KiB
C++
/**************************************************************************
|
|
* KWin - the KDE window manager *
|
|
* This file is part of the KDE project. *
|
|
* *
|
|
* Copyright (C) 2013 Antonis Tsiapaliokas <kok3rs@gmail.com> *
|
|
* *
|
|
* This program is free software; you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation; either version 2 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* This program is distributed in the hope that it will be useful, *
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
|
|
* GNU General Public License for more details. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
**************************************************************************/
|
|
|
|
|
|
#ifndef COMPOSITING_H
|
|
#define COMPOSITING_H
|
|
|
|
#include <QAbstractItemModel>
|
|
#include <QObject>
|
|
|
|
namespace KWin {
|
|
namespace Compositing {
|
|
|
|
class OpenGLPlatformInterfaceModel;
|
|
|
|
class Compositing : public QObject
|
|
{
|
|
|
|
Q_OBJECT
|
|
Q_PROPERTY(int animationSpeed READ animationSpeed WRITE setAnimationSpeed NOTIFY animationSpeedChanged)
|
|
Q_PROPERTY(int windowThumbnail READ windowThumbnail WRITE setWindowThumbnail NOTIFY windowThumbnailChanged)
|
|
Q_PROPERTY(int glScaleFilter READ glScaleFilter WRITE setGlScaleFilter NOTIFY glScaleFilterChanged)
|
|
Q_PROPERTY(bool xrScaleFilter READ xrScaleFilter WRITE setXrScaleFilter NOTIFY xrScaleFilterChanged)
|
|
Q_PROPERTY(int glSwapStrategy READ glSwapStrategy WRITE setGlSwapStrategy NOTIFY glSwapStrategyChanged)
|
|
Q_PROPERTY(bool glColorCorrection READ glColorCorrection WRITE setGlColorCorrection NOTIFY glColorCorrectionChanged)
|
|
Q_PROPERTY(int compositingType READ compositingType WRITE setCompositingType NOTIFY compositingTypeChanged)
|
|
Q_PROPERTY(bool compositingEnabled READ compositingEnabled WRITE setCompositingEnabled NOTIFY compositingEnabledChanged)
|
|
Q_PROPERTY(KWin::Compositing::OpenGLPlatformInterfaceModel *openGLPlatformInterfaceModel READ openGLPlatformInterfaceModel CONSTANT)
|
|
Q_PROPERTY(int openGLPlatformInterface READ openGLPlatformInterface WRITE setOpenGLPlatformInterface NOTIFY openGLPlatformInterfaceChanged)
|
|
public:
|
|
explicit Compositing(QObject *parent = 0);
|
|
|
|
Q_INVOKABLE bool OpenGLIsUnsafe() const;
|
|
Q_INVOKABLE bool OpenGLIsBroken();
|
|
Q_INVOKABLE void reenableOpenGLDetection();
|
|
int animationSpeed() const;
|
|
int windowThumbnail() const;
|
|
int glScaleFilter() const;
|
|
bool xrScaleFilter() const;
|
|
int glSwapStrategy() const;
|
|
bool glColorCorrection() const;
|
|
int compositingType() const;
|
|
bool compositingEnabled() const;
|
|
int openGLPlatformInterface() const;
|
|
|
|
OpenGLPlatformInterfaceModel *openGLPlatformInterfaceModel() const;
|
|
|
|
void setAnimationSpeed(int speed);
|
|
void setWindowThumbnail(int index);
|
|
void setGlScaleFilter(int index);
|
|
void setXrScaleFilter(bool filter);
|
|
void setGlSwapStrategy(int strategy);
|
|
void setGlColorCorrection(bool correction);
|
|
void setCompositingType(int index);
|
|
void setCompositingEnabled(bool enalbed);
|
|
void setOpenGLPlatformInterface(int interface);
|
|
|
|
void save();
|
|
|
|
public Q_SLOTS:
|
|
void reset();
|
|
void defaults();
|
|
|
|
Q_SIGNALS:
|
|
void changed();
|
|
void animationSpeedChanged(int);
|
|
void windowThumbnailChanged(int);
|
|
void glScaleFilterChanged(int);
|
|
void xrScaleFilterChanged(int);
|
|
void glSwapStrategyChanged(int);
|
|
void glColorCorrectionChanged(bool);
|
|
void compositingTypeChanged(int);
|
|
void compositingEnabledChanged(bool);
|
|
void openGLPlatformInterfaceChanged(int);
|
|
|
|
private:
|
|
int m_animationSpeed;
|
|
int m_windowThumbnail;
|
|
int m_glScaleFilter;
|
|
bool m_xrScaleFilter;
|
|
int m_glSwapStrategy;
|
|
bool m_glColorCorrection;
|
|
int m_compositingType;
|
|
bool m_compositingEnabled;
|
|
bool m_changed;
|
|
OpenGLPlatformInterfaceModel *m_openGLPlatformInterfaceModel;
|
|
int m_openGLPlatformInterface;
|
|
};
|
|
|
|
|
|
struct CompositingData;
|
|
|
|
class CompositingType : public QAbstractItemModel
|
|
{
|
|
|
|
Q_OBJECT
|
|
Q_ENUMS(CompositingTypeIndex)
|
|
|
|
public:
|
|
|
|
enum CompositingTypeIndex {
|
|
OPENGL31_INDEX = 0,
|
|
OPENGL20_INDEX,
|
|
XRENDER_INDEX
|
|
};
|
|
|
|
enum CompositingTypeRoles {
|
|
NameRole = Qt::UserRole +1,
|
|
TypeRole = Qt::UserRole +2
|
|
};
|
|
|
|
explicit CompositingType(QObject *parent = 0);
|
|
|
|
QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
|
|
QModelIndex parent(const QModelIndex &child) const override;
|
|
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
int columnCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
|
|
|
|
virtual QHash< int, QByteArray > roleNames() const override;
|
|
|
|
Q_INVOKABLE int compositingTypeForIndex(int row) const;
|
|
Q_INVOKABLE int indexForCompositingType(int type) const;
|
|
|
|
private:
|
|
void generateCompositing();
|
|
QList<CompositingData> m_compositingList;
|
|
|
|
};
|
|
|
|
struct CompositingData {
|
|
QString name;
|
|
CompositingType::CompositingTypeIndex type;
|
|
};
|
|
|
|
class OpenGLPlatformInterfaceModel : public QAbstractListModel
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit OpenGLPlatformInterfaceModel(QObject *parent = nullptr);
|
|
virtual ~OpenGLPlatformInterfaceModel();
|
|
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
|
|
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
|
|
QModelIndex indexForKey(const QString &key) const;
|
|
|
|
QHash< int, QByteArray > roleNames() const override;
|
|
|
|
private:
|
|
QStringList m_keys;
|
|
QStringList m_names;
|
|
};
|
|
|
|
}//end namespace Compositing
|
|
}//end namespace KWin
|
|
|
|
Q_DECLARE_METATYPE(KWin::Compositing::OpenGLPlatformInterfaceModel*)
|
|
#endif
|