3c04d5295d
Summary: If KWin fails to start the Wayland server due to XDG_RUNTIME_DIR not being set, kwin_wayland should terminate with an error condition but not crash. This change makes sure that KWin detects that the Wayland server does not work and terminates the startup early and ensures that it doesn't crash while going down. An error message is shown that we could not create the Wayland server. Test Plan: Test case added which verifies that WaylandServer fails to init. Manual testing that kwin_wayland exits with error 1. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2078
104 lines
3.7 KiB
C++
104 lines
3.7 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2015 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "kwin_wayland_test.h"
|
|
#include "platform.h"
|
|
#include "abstract_client.h"
|
|
#include "client.h"
|
|
#include "deleted.h"
|
|
#include "screens.h"
|
|
#include "wayland_server.h"
|
|
#include "workspace.h"
|
|
|
|
#include <KDecoration2/Decoration>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_dont_crash_glxgears-0");
|
|
|
|
class DontCrashGlxgearsTest : public QObject
|
|
{
|
|
Q_OBJECT
|
|
private Q_SLOTS:
|
|
void initTestCase();
|
|
void testGlxgears();
|
|
};
|
|
|
|
void DontCrashGlxgearsTest::initTestCase()
|
|
{
|
|
qRegisterMetaType<KWin::Deleted*>();
|
|
QSignalSpy workspaceCreatedSpy(kwinApp(), &Application::workspaceCreated);
|
|
QVERIFY(workspaceCreatedSpy.isValid());
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
|
QVERIFY(waylandServer()->init(s_socketName.toLocal8Bit()));
|
|
kwinApp()->start();
|
|
QVERIFY(workspaceCreatedSpy.wait());
|
|
}
|
|
|
|
void DontCrashGlxgearsTest::testGlxgears()
|
|
{
|
|
// closing a glxgears window through Aurorae themes used to crash KWin
|
|
// Let's make sure that doesn't happen anymore
|
|
|
|
QSignalSpy clientAddedSpy(workspace(), &Workspace::clientAdded);
|
|
QVERIFY(clientAddedSpy.isValid());
|
|
|
|
QProcess glxgears;
|
|
glxgears.start(QStringLiteral("glxgears"));
|
|
QVERIFY(glxgears.waitForStarted());
|
|
|
|
QVERIFY(clientAddedSpy.wait());
|
|
QCOMPARE(clientAddedSpy.count(), 1);
|
|
QCOMPARE(workspace()->clientList().count(), 1);
|
|
Client *glxgearsClient = workspace()->clientList().first();
|
|
QVERIFY(glxgearsClient->isDecorated());
|
|
QSignalSpy closedSpy(glxgearsClient, &Client::windowClosed);
|
|
QVERIFY(closedSpy.isValid());
|
|
KDecoration2::Decoration *decoration = glxgearsClient->decoration();
|
|
QVERIFY(decoration);
|
|
|
|
// send a mouse event to the position of the close button
|
|
QPointF pos = decoration->rect().topRight() + QPointF(-decoration->borderRight() * 2, decoration->borderRight() * 2);
|
|
QHoverEvent event(QEvent::HoverMove, pos, pos);
|
|
QCoreApplication::instance()->sendEvent(decoration, &event);
|
|
// mouse press
|
|
QMouseEvent mousePressevent(QEvent::MouseButtonPress, pos, pos, Qt::LeftButton, Qt::LeftButton, Qt::NoModifier);
|
|
mousePressevent.setAccepted(false);
|
|
QCoreApplication::sendEvent(decoration, &mousePressevent);
|
|
QVERIFY(mousePressevent.isAccepted());
|
|
// mouse Release
|
|
QMouseEvent mouseReleaseEvent(QEvent::MouseButtonRelease, pos, pos, Qt::LeftButton, Qt::LeftButton, Qt::NoModifier);
|
|
mouseReleaseEvent.setAccepted(false);
|
|
QCoreApplication::sendEvent(decoration, &mouseReleaseEvent);
|
|
QVERIFY(mouseReleaseEvent.isAccepted());
|
|
|
|
QVERIFY(closedSpy.wait());
|
|
QCOMPARE(closedSpy.count(), 1);
|
|
xcb_flush(connection());
|
|
|
|
if (glxgears.state() == QProcess::Running) {
|
|
QVERIFY(glxgears.waitForFinished());
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
WAYLANDTEST_MAIN(KWin::DontCrashGlxgearsTest)
|
|
#include "dont_crash_glxgears.moc"
|