0eba3f3c18
Summary: Libinput returns -1 when calling libinput_event_touch_get_slot on an event from a single-touch touchscreen. The returned value is used in DecorationEventFilter to determine the touch which is acting on it. The value -1 is used to signify that the decoration is not being acted on. Thus when releasing the touch, it checks whether it was being dragged, and as it thinks it isn't, it doesn't handle it and the decoration is still being dragged. Clicking on the decoration then crashes kwin. Test Plan: Move a window by dragging the decoration with a single-touch touchscreen. Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: graesslin, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7854
145 lines
4.7 KiB
C++
145 lines
4.7 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2016 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "mock_libinput.h"
|
|
#include "../../libinput/device.h"
|
|
#include "../../libinput/events.h"
|
|
|
|
#include <QtTest/QtTest>
|
|
|
|
#include <linux/input.h>
|
|
|
|
Q_DECLARE_METATYPE(libinput_event_type)
|
|
|
|
using namespace KWin::LibInput;
|
|
|
|
class TestLibinputTouchEvent : public QObject
|
|
{
|
|
Q_OBJECT
|
|
private Q_SLOTS:
|
|
void init();
|
|
void cleanup();
|
|
|
|
void testType_data();
|
|
void testType();
|
|
void testAbsoluteMotion_data();
|
|
void testAbsoluteMotion();
|
|
void testNoAssignedSlot();
|
|
|
|
private:
|
|
libinput_device *m_nativeDevice = nullptr;
|
|
Device *m_device = nullptr;
|
|
};
|
|
|
|
void TestLibinputTouchEvent::init()
|
|
{
|
|
m_nativeDevice = new libinput_device;
|
|
m_nativeDevice->touch = true;
|
|
m_nativeDevice->deviceSize = QSizeF(12.5, 13.8);
|
|
m_device = new Device(m_nativeDevice);
|
|
}
|
|
|
|
void TestLibinputTouchEvent::cleanup()
|
|
{
|
|
delete m_device;
|
|
m_device = nullptr;
|
|
|
|
delete m_nativeDevice;
|
|
m_nativeDevice = nullptr;
|
|
}
|
|
|
|
void TestLibinputTouchEvent::testType_data()
|
|
{
|
|
QTest::addColumn<libinput_event_type>("type");
|
|
QTest::addColumn<bool>("hasId");
|
|
|
|
QTest::newRow("down") << LIBINPUT_EVENT_TOUCH_DOWN << true;
|
|
QTest::newRow("up") << LIBINPUT_EVENT_TOUCH_UP << true;
|
|
QTest::newRow("motion") << LIBINPUT_EVENT_TOUCH_MOTION << true;
|
|
QTest::newRow("cancel") << LIBINPUT_EVENT_TOUCH_CANCEL << false;
|
|
QTest::newRow("frame") << LIBINPUT_EVENT_TOUCH_FRAME << false;
|
|
}
|
|
|
|
void TestLibinputTouchEvent::testType()
|
|
{
|
|
// this test verifies the initialization of a PointerEvent and the parent Event class
|
|
libinput_event_touch *touchEvent = new libinput_event_touch;
|
|
QFETCH(libinput_event_type, type);
|
|
touchEvent->type = type;
|
|
touchEvent->device = m_nativeDevice;
|
|
touchEvent->slot = 0;
|
|
|
|
QScopedPointer<Event> event(Event::create(touchEvent));
|
|
// API of event
|
|
QCOMPARE(event->type(), type);
|
|
QCOMPARE(event->device(), m_device);
|
|
QCOMPARE(event->nativeDevice(), m_nativeDevice);
|
|
QCOMPARE((libinput_event*)(*event.data()), touchEvent);
|
|
// verify it's a pointer event
|
|
QVERIFY(dynamic_cast<TouchEvent*>(event.data()));
|
|
QCOMPARE((libinput_event_touch*)(*dynamic_cast<TouchEvent*>(event.data())), touchEvent);
|
|
QFETCH(bool, hasId);
|
|
if (hasId) {
|
|
QCOMPARE(dynamic_cast<TouchEvent*>(event.data())->id(), 0);
|
|
}
|
|
}
|
|
|
|
void TestLibinputTouchEvent::testAbsoluteMotion_data()
|
|
{
|
|
QTest::addColumn<libinput_event_type>("type");
|
|
QTest::newRow("down") << LIBINPUT_EVENT_TOUCH_DOWN;
|
|
QTest::newRow("motion") << LIBINPUT_EVENT_TOUCH_MOTION;
|
|
}
|
|
|
|
void TestLibinputTouchEvent::testAbsoluteMotion()
|
|
{
|
|
// this test verifies absolute touch points (either down or motion)
|
|
libinput_event_touch *touchEvent = new libinput_event_touch;
|
|
touchEvent->device = m_nativeDevice;
|
|
QFETCH(libinput_event_type, type);
|
|
touchEvent->type = type;
|
|
touchEvent->absolutePos = QPointF(6.25, 6.9);
|
|
touchEvent->time = 500u;
|
|
touchEvent->slot = 1;
|
|
|
|
QScopedPointer<Event> event(Event::create(touchEvent));
|
|
auto te = dynamic_cast<TouchEvent*>(event.data());
|
|
QVERIFY(te);
|
|
QCOMPARE(te->type(), type);
|
|
QCOMPARE(te->time(), 500u);
|
|
QCOMPARE(te->absolutePos(), QPointF(6.25, 6.9));
|
|
QCOMPARE(te->absolutePos(QSize(1280, 1024)), QPointF(640, 512));
|
|
}
|
|
|
|
void TestLibinputTouchEvent::testNoAssignedSlot()
|
|
{
|
|
// this test verifies that touch events without an assigned slot get id == 0
|
|
libinput_event_touch *touchEvent = new libinput_event_touch;
|
|
touchEvent->type = LIBINPUT_EVENT_TOUCH_UP;
|
|
touchEvent->device = m_nativeDevice;
|
|
// touch events without an assigned slot have slot == -1
|
|
touchEvent->slot = -1;
|
|
|
|
QScopedPointer<Event> event(Event::create(touchEvent));
|
|
QVERIFY(dynamic_cast<TouchEvent*>(event.data()));
|
|
QCOMPARE(dynamic_cast<TouchEvent*>(event.data())->id(), 0);
|
|
}
|
|
|
|
QTEST_GUILESS_MAIN(TestLibinputTouchEvent)
|
|
#include "touch_event_test.moc"
|