8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
140 lines
4 KiB
C++
140 lines
4 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2017 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#include <QTest>
|
|
#include <QX11Info>
|
|
|
|
#include <KPluginLoader>
|
|
#include <KPluginMetaData>
|
|
|
|
#include "main.h"
|
|
#include "utils.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class X11TestApplication : public Application
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
X11TestApplication(int &argc, char **argv);
|
|
~X11TestApplication() override;
|
|
|
|
protected:
|
|
void performStartup() override;
|
|
|
|
};
|
|
|
|
X11TestApplication::X11TestApplication(int &argc, char **argv)
|
|
: Application(OperationModeX11, argc, argv)
|
|
{
|
|
setX11Connection(QX11Info::connection());
|
|
setX11RootWindow(QX11Info::appRootWindow());
|
|
|
|
// move directory containing executable to front, so that KPluginLoader prefers the plugins in
|
|
// the build dir over system installed ones
|
|
const auto ownPath = libraryPaths().last();
|
|
removeLibraryPath(ownPath);
|
|
addLibraryPath(ownPath);
|
|
|
|
const auto plugins = KPluginLoader::findPluginsById(QStringLiteral("org.kde.kwin.platforms"),
|
|
QStringLiteral("KWinX11Platform"));
|
|
if (plugins.empty()) {
|
|
quit();
|
|
return;
|
|
}
|
|
initPlatform(plugins.first());
|
|
}
|
|
|
|
X11TestApplication::~X11TestApplication()
|
|
{
|
|
}
|
|
|
|
void X11TestApplication::performStartup()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
class X11TimestampUpdateTest : public QObject
|
|
{
|
|
Q_OBJECT
|
|
private Q_SLOTS:
|
|
void testGrabAfterServerTime();
|
|
void testBeforeLastGrabTime();
|
|
};
|
|
|
|
void X11TimestampUpdateTest::testGrabAfterServerTime()
|
|
{
|
|
// this test tries to grab the X keyboard with a timestamp in future
|
|
// that should fail, but after updating the X11 timestamp, it should
|
|
// work again
|
|
KWin::updateXTime();
|
|
QCOMPARE(KWin::grabXKeyboard(), true);
|
|
KWin::ungrabXKeyboard();
|
|
|
|
// now let's change the timestamp
|
|
KWin::kwinApp()->setX11Time(KWin::xTime() + 5 * 60 * 1000);
|
|
|
|
// now grab keyboard should fail
|
|
QCOMPARE(KWin::grabXKeyboard(), false);
|
|
|
|
// let's update timestamp, now it should work again
|
|
KWin::updateXTime();
|
|
QCOMPARE(KWin::grabXKeyboard(), true);
|
|
KWin::ungrabXKeyboard();
|
|
}
|
|
|
|
void X11TimestampUpdateTest::testBeforeLastGrabTime()
|
|
{
|
|
// this test tries to grab the X keyboard with a timestamp before the
|
|
// last grab time on the server. That should fail, but after updating the X11
|
|
// timestamp it should work again
|
|
|
|
// first set the grab timestamp
|
|
KWin::updateXTime();
|
|
QCOMPARE(KWin::grabXKeyboard(), true);
|
|
KWin::ungrabXKeyboard();
|
|
|
|
// now go to past
|
|
const auto timestamp = KWin::xTime();
|
|
KWin::kwinApp()->setX11Time(KWin::xTime() - 5 * 60 * 1000, KWin::Application::TimestampUpdate::Always);
|
|
QCOMPARE(KWin::xTime(), timestamp - 5 * 60 * 1000);
|
|
|
|
// now grab keyboard should fail
|
|
QCOMPARE(KWin::grabXKeyboard(), false);
|
|
|
|
// let's update timestamp, now it should work again
|
|
KWin::updateXTime();
|
|
QVERIFY(KWin::xTime() >= timestamp);
|
|
QCOMPARE(KWin::grabXKeyboard(), true);
|
|
KWin::ungrabXKeyboard();
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
setenv("QT_QPA_PLATFORM", "xcb", true);
|
|
KWin::X11TestApplication app(argc, argv);
|
|
app.setAttribute(Qt::AA_Use96Dpi, true);
|
|
X11TimestampUpdateTest tc;
|
|
return QTest::qExec(&tc, argc, argv);
|
|
}
|
|
|
|
#include "test_x11_timestamp_update.moc"
|