d51b8dc093
Summary: This is an alternative solution to T8707 and in comparision to D13276 a less drastic change to KWin's default behavior. Instead of changing the border size default for all KDecoration plugins by switching the default from border size Normal to None introduce new functionality, which allows a KDecoration plugin to recommend a border size in its metadata. By default KWin listens for these recommendations and sets the border size accordingly. If there is no metadata recommending a border size, KWin falls back to the current setting of Normal sized borders. A user is able to override the recommendations from the KCM, which has been extended accordingly. Test Plan: Manually with adjusted metadata of Breeze. Reviewers: #kwin, #plasma, #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: hpereiradacosta, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin Tags: #kwin Maniphest Tasks: T8707 Differential Revision: https://phabricator.kde.org/D13284
128 lines
4 KiB
C++
128 lines
4 KiB
C++
/*
|
|
* Copyright (c) 2019 Valerio Pilo <vpilo@coldshock.net>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License version 2 as published by the Free Software Foundation.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public License
|
|
* along with this library; see the file COPYING.LIB. If not, write to
|
|
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "utils.h"
|
|
|
|
#include <KQuickAddons/ConfigModule>
|
|
|
|
|
|
class QAbstractItemModel;
|
|
class QSortFilterProxyModel;
|
|
class QQuickItem;
|
|
|
|
namespace KNS3
|
|
{
|
|
class DownloadDialog;
|
|
}
|
|
|
|
namespace KDecoration2
|
|
{
|
|
enum class BorderSize;
|
|
|
|
namespace Preview
|
|
{
|
|
class ButtonsModel;
|
|
}
|
|
namespace Configuration
|
|
{
|
|
class DecorationsModel;
|
|
}
|
|
}
|
|
|
|
class KCMKWinDecoration : public KQuickAddons::ConfigModule
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(QSortFilterProxyModel *themesModel READ themesModel CONSTANT)
|
|
Q_PROPERTY(QStringList borderSizesModel READ borderSizesModel CONSTANT)
|
|
Q_PROPERTY(int borderSize READ borderSize WRITE setBorderSize NOTIFY borderSizeChanged)
|
|
Q_PROPERTY(int recommendedBorderSize READ recommendedBorderSize CONSTANT)
|
|
Q_PROPERTY(bool borderSizeAuto READ borderSizeAuto WRITE setBorderSizeAuto NOTIFY borderSizeAutoChanged)
|
|
Q_PROPERTY(int theme READ theme WRITE setTheme NOTIFY themeChanged)
|
|
Q_PROPERTY(QAbstractListModel *leftButtonsModel READ leftButtonsModel NOTIFY buttonsChanged)
|
|
Q_PROPERTY(QAbstractListModel *rightButtonsModel READ rightButtonsModel NOTIFY buttonsChanged)
|
|
Q_PROPERTY(QAbstractListModel *availableButtonsModel READ availableButtonsModel CONSTANT)
|
|
Q_PROPERTY(bool closeOnDoubleClickOnMenu READ closeOnDoubleClickOnMenu WRITE setCloseOnDoubleClickOnMenu NOTIFY closeOnDoubleClickOnMenuChanged)
|
|
Q_PROPERTY(bool showToolTips READ showToolTips WRITE setShowToolTips NOTIFY showToolTipsChanged)
|
|
|
|
public:
|
|
KCMKWinDecoration(QObject *parent, const QVariantList &arguments);
|
|
|
|
QSortFilterProxyModel *themesModel() const;
|
|
QAbstractListModel *leftButtonsModel();
|
|
QAbstractListModel *rightButtonsModel();
|
|
QAbstractListModel *availableButtonsModel() const;
|
|
QStringList borderSizesModel() const;
|
|
int borderSize() const;
|
|
int recommendedBorderSize() const;
|
|
bool borderSizeAuto() const;
|
|
int theme() const;
|
|
bool closeOnDoubleClickOnMenu() const;
|
|
bool showToolTips() const;
|
|
|
|
void setBorderSize(int index);
|
|
void setBorderSize(KDecoration2::BorderSize size);
|
|
void setBorderSizeAuto(bool set);
|
|
void setTheme(int index);
|
|
void setCloseOnDoubleClickOnMenu(bool enable);
|
|
void setShowToolTips(bool show);
|
|
|
|
Q_INVOKABLE void getNewStuff(QQuickItem *context);
|
|
|
|
Q_SIGNALS:
|
|
void themeChanged();
|
|
void buttonsChanged();
|
|
void borderSizeChanged();
|
|
void borderSizeAutoChanged();
|
|
void closeOnDoubleClickOnMenuChanged();
|
|
void showToolTipsChanged();
|
|
|
|
public Q_SLOTS:
|
|
void load() override;
|
|
void save() override;
|
|
void defaults() override;
|
|
|
|
private Q_SLOTS:
|
|
void updateNeedsSave();
|
|
void reloadKWinSettings();
|
|
|
|
private:
|
|
KDecoration2::Configuration::DecorationsModel *m_themesModel;
|
|
QSortFilterProxyModel *m_proxyThemesModel;
|
|
|
|
KDecoration2::Preview::ButtonsModel *m_leftButtonsModel;
|
|
KDecoration2::Preview::ButtonsModel *m_rightButtonsModel;
|
|
KDecoration2::Preview::ButtonsModel *m_availableButtonsModel;
|
|
|
|
QPointer<KNS3::DownloadDialog> m_newStuffDialog;
|
|
|
|
struct Settings
|
|
{
|
|
KDecoration2::BorderSize borderSize;
|
|
bool borderSizeAuto;
|
|
int themeIndex;
|
|
bool closeOnDoubleClickOnMenu;
|
|
bool showToolTips;
|
|
DecorationButtonsList buttonsOnLeft;
|
|
DecorationButtonsList buttonsOnRight;
|
|
};
|
|
|
|
Settings m_savedSettings;
|
|
Settings m_currentSettings;
|
|
};
|